* [PATCH v1] ARM: dts: rockchip: Update LEDs to work with the last leds-gpio driver on radxarock
@ 2014-11-23 16:19 Romain Perier
[not found] ` <1416759575-774-1-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Romain Perier @ 2014-11-23 16:19 UTC (permalink / raw)
To: heiko-4mtYJXux2i+zQB+pC5nmwQ
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
The leds-gpio driver recently switched to the device property API. The device_node
name is no longer retrieved if the "label" devicetree property is not found.
In this case the driver tries to create entries with (null) name in
/sys/class/leds, which is wrong and generates backtrace as several gpio_leds have
the same name. Also renamed subnode "yellow" to "blue" to match the last
schematics updates.
Signed-off-by: Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/rk3188-radxarock.dts | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts
index 6eb62c0..9a09579 100644
--- a/arch/arm/boot/dts/rk3188-radxarock.dts
+++ b/arch/arm/boot/dts/rk3188-radxarock.dts
@@ -43,16 +43,19 @@
compatible = "gpio-leds";
green {
+ label = "rock:green:user1";
gpios = <&gpio0 12 GPIO_ACTIVE_LOW>;
default-state = "off";
};
- yellow {
+ blue {
+ label = "rock:blue:user2";
gpios = <&gpio0 14 GPIO_ACTIVE_LOW>;
default-state = "off";
};
sleep {
+ label = "rock:red:power";
gpios = <&gpio0 15 0>;
default-state = "off";
};
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1416759575-774-1-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v1] ARM: dts: rockchip: Update LEDs to work with the last leds-gpio driver on radxarock [not found] ` <1416759575-774-1-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> @ 2014-11-23 16:20 ` Romain Perier [not found] ` <CABgxDoLwqYttcPYc+Wth3B17P=e2cbV8G=hqbRfWx+PVTiAPig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2014-12-01 0:06 ` Heiko Stübner 1 sibling, 1 reply; 4+ messages in thread From: Romain Perier @ 2014-11-23 16:20 UTC (permalink / raw) To: Heiko Stübner Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org See https://www.kernel.org/doc/Documentation/leds/leds-class.txt for LEDs device naming 2014-11-23 17:19 GMT+01:00 Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>: > The leds-gpio driver recently switched to the device property API. The device_node > name is no longer retrieved if the "label" devicetree property is not found. > In this case the driver tries to create entries with (null) name in > /sys/class/leds, which is wrong and generates backtrace as several gpio_leds have > the same name. Also renamed subnode "yellow" to "blue" to match the last > schematics updates. > > Signed-off-by: Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > arch/arm/boot/dts/rk3188-radxarock.dts | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts > index 6eb62c0..9a09579 100644 > --- a/arch/arm/boot/dts/rk3188-radxarock.dts > +++ b/arch/arm/boot/dts/rk3188-radxarock.dts > @@ -43,16 +43,19 @@ > compatible = "gpio-leds"; > > green { > + label = "rock:green:user1"; > gpios = <&gpio0 12 GPIO_ACTIVE_LOW>; > default-state = "off"; > }; > > - yellow { > + blue { > + label = "rock:blue:user2"; > gpios = <&gpio0 14 GPIO_ACTIVE_LOW>; > default-state = "off"; > }; > > sleep { > + label = "rock:red:power"; > gpios = <&gpio0 15 0>; > default-state = "off"; > }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <CABgxDoLwqYttcPYc+Wth3B17P=e2cbV8G=hqbRfWx+PVTiAPig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH v1] ARM: dts: rockchip: Update LEDs to work with the last leds-gpio driver on radxarock [not found] ` <CABgxDoLwqYttcPYc+Wth3B17P=e2cbV8G=hqbRfWx+PVTiAPig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-11-30 14:10 ` Romain Perier 0 siblings, 0 replies; 4+ messages in thread From: Romain Perier @ 2014-11-30 14:10 UTC (permalink / raw) To: Heiko Stübner Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org ping :) 2014-11-23 17:20 GMT+01:00 Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>: > See https://www.kernel.org/doc/Documentation/leds/leds-class.txt for > LEDs device naming > > 2014-11-23 17:19 GMT+01:00 Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>: >> The leds-gpio driver recently switched to the device property API. The device_node >> name is no longer retrieved if the "label" devicetree property is not found. >> In this case the driver tries to create entries with (null) name in >> /sys/class/leds, which is wrong and generates backtrace as several gpio_leds have >> the same name. Also renamed subnode "yellow" to "blue" to match the last >> schematics updates. >> >> Signed-off-by: Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> >> --- >> arch/arm/boot/dts/rk3188-radxarock.dts | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts >> index 6eb62c0..9a09579 100644 >> --- a/arch/arm/boot/dts/rk3188-radxarock.dts >> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts >> @@ -43,16 +43,19 @@ >> compatible = "gpio-leds"; >> >> green { >> + label = "rock:green:user1"; >> gpios = <&gpio0 12 GPIO_ACTIVE_LOW>; >> default-state = "off"; >> }; >> >> - yellow { >> + blue { >> + label = "rock:blue:user2"; >> gpios = <&gpio0 14 GPIO_ACTIVE_LOW>; >> default-state = "off"; >> }; >> >> sleep { >> + label = "rock:red:power"; >> gpios = <&gpio0 15 0>; >> default-state = "off"; >> }; >> -- >> 1.9.1 >> -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1] ARM: dts: rockchip: Update LEDs to work with the last leds-gpio driver on radxarock [not found] ` <1416759575-774-1-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2014-11-23 16:20 ` Romain Perier @ 2014-12-01 0:06 ` Heiko Stübner 1 sibling, 0 replies; 4+ messages in thread From: Heiko Stübner @ 2014-12-01 0:06 UTC (permalink / raw) To: Romain Perier Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Am Sonntag, 23. November 2014, 16:19:35 schrieb Romain Perier: > The leds-gpio driver recently switched to the device property API. The > device_node name is no longer retrieved if the "label" devicetree property > is not found. In this case the driver tries to create entries with (null) > name in /sys/class/leds, which is wrong and generates backtrace as several > gpio_leds have the same name. Also renamed subnode "yellow" to "blue" to > match the last schematics updates. > > Signed-off-by: Romain Perier <romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> applied to my dts branch -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-01 0:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-23 16:19 [PATCH v1] ARM: dts: rockchip: Update LEDs to work with the last leds-gpio driver on radxarock Romain Perier
[not found] ` <1416759575-774-1-git-send-email-romain.perier-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-23 16:20 ` Romain Perier
[not found] ` <CABgxDoLwqYttcPYc+Wth3B17P=e2cbV8G=hqbRfWx+PVTiAPig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-30 14:10 ` Romain Perier
2014-12-01 0:06 ` Heiko Stübner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).