Re: [PATCH 2/3] dt-bindings: pinctrl: Add EcoNet EN7528 pin controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/08/2026 16:33, Ahmed Naseef wrote:
> On Fri, Aug 28, 2026 at 08:59:57AM +0200, Krzysztof Kozlowski wrote:
>> On Sun, Aug 09, 2026 at 12:04:59PM +0400, Ahmed Naseef wrote:
>>> +maintainers:
>>> +  - Lorenzo Bianconi <lorenzo@kernel.org>
>>> +
>>> +description:
>>> +  The EcoNet EN7528 pin controller is used to control SoC pins. It shares the
>>> +  IP with the Airoha pin controllers, but its IOMUX and pin configuration
>>> +  registers have a different layout.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    const: econet,en7528-pinctrl
>>> +
>>> +  airoha,chip-scu:
>>> +    description: phandle to the chip SCU syscon
>>> +    $ref: /schemas/types.yaml#/definitions/phandle
>>
>> If the entire address space is part of the SCU, then this device should
>> be part of the SCU, e.g. its subnode.
> 
> It is not: the registers are split over two blocks. The GPIO, interrupt
> and PWM flash-mode registers are in the block the node sits under, and
> the IOMUX and pin configuration registers are in the SCU. Both are
> needed, so whichever of the two is the parent, the other one has to come
> in by phandle.

Sure, one is parent and other is sibling. This is standard. But
non-standard is to claim to have no MMIO but then get that MMIO from
someone else...


Best regards,
Krzysztof