From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBFA11A316C for ; Tue, 25 Feb 2025 16:45:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740501904; cv=none; b=IY9vOO9NHsbXxCH1ktrI3Q1XIUQnW3S0mjQaRjmgSEaqwdxtMqboVB0V8pIsGPRAZb6ASOMLBZH4k0iy6Gx5IjS/SoSolOsHYxL7hCUZVbVpkOtzMsbHDtFolnxKZRi8naHmfs3fVjxhn2kRnmX5o5pU2CiKBLYmE+o8/euPJ2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740501904; c=relaxed/simple; bh=L2FmnGukcA0y4f65aXO6bVtDOK+71WB4L3u56d6qH0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eRyD4ysxfhd10IQC8nOl0dPNAKTM/9epOsyoG9ORdZXBhNcVVJF9AXMI+2ay9UdGL5SdEY9hShUkOjVYcZ+Mz1bBLezMLmjCvQBfDfA0cyOv1HRspTRnj29ZSx3vUTocqsg+eZIfPbvtU4+0k3nO9ruJ6YekxXTvNaI+5Ph0ZeA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kzWYpvpT; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kzWYpvpT" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51P8GbNY012766 for ; Tue, 25 Feb 2025 16:45:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ULUpptJwI6ThaUvM4CSWgxzRITrdZBlHcTREM3kcByM=; b=kzWYpvpTjBl8zND8 95vNpAKACM6V2TErk2q+N3/vSaSJ+UrON9VohH9ngZ6Y0VELEmspHxdnS88TtOV7 s08ike/9NvKa1Ht+g1W7U/qbYuNFpcPonMBAVgsZzhVlpPg+hUdJQI/d4GFTExjY FhcMx5uHcGxO4KpTbqE3GwRw+jMVnH/ro4r30x6U2cAmayCi71rokVL4iP1MrHyQ 3pWtQwZy/cYw5RwcFv+RsvhldVozHYbNKDGZwUN6wNAQUFNOfG42FHcHkuED751j LZQO4rZwHpE+rkbgS60lchf9n+wTY7WoVDEFo/dPJfvsur37++hi6lNjdlto7Wqd wFlKWA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44y65y1h37-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 25 Feb 2025 16:45:01 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2f81a0d0a18so12573840a91.3 for ; Tue, 25 Feb 2025 08:45:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740501900; x=1741106700; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ULUpptJwI6ThaUvM4CSWgxzRITrdZBlHcTREM3kcByM=; b=tKtS5pZ/HreJojBCyFL1q2UMz5oxMV57CLVgs5uk1cVXQwDkBjsmsMj0JI9MTkM388 LqnbCdQ+CaosYLrij+LKQAnJrYTFTWe1u27ryoKwzhrISlLhnLgbCO3TGVYI6ocpX6a+ sXOA4FLcrRpRnkQ1CvUN+D4fJIyQUFhu38M7uUHur++G2yA6zDas16D/ePitA/+v2cxh A5j3Po4nFzcRgqylBR2woXn3YteCPhtUQ1eoYgfUpP6uR/UZL2f2xJhZz0DstqgXYsbP YMv40AvnZYZMa9kNo+lL7IPueVzFYaIzFWYXYJ+wcAOBeR8tH5GiBZt84jhbUIk0RSol bhQQ== X-Forwarded-Encrypted: i=1; AJvYcCXimwVEEPtCVsHo3IjDPDAtVNCvTLifYcABXmDhC4sgFBEOdlgGCz0ovApirN9pVzqzgPhKL+HRh4M7@vger.kernel.org X-Gm-Message-State: AOJu0YySD16aU8eMkxqTU72yuZ7N+Y1RW+UKFLgMCpyBK5G22bEwgvsE QWLnTRKb1T+GBwn9QDV71tE9XSMf1Cdx/y7IXdigiCJrAhkHS63jjXD6AXeDYZ9o6lWpzQ0yGgQ wD+c2VfYkvprgVz3CgrhTaWeFs+Ymq1/lcDvKxJfE65UR5zTS+aD0li9E9b1/ X-Gm-Gg: ASbGncvub4k1z4VDeHTfuNTUqRd+m8M+jLTKPcTJNhbPYiNBUUL2sJl70jN+EJvS2P3 S18dj0yFgTab9xsxnVNK9hqRcC6cTrl+k87dQQtpvt8TpSAQn5jrhrjKbVijfInjYYF/5s2MfiN 5N6iubg87CfmqG61p8DbZrTUlhoyYnQ5derFyML9V77HMxJF7xTxkAMwdPtQz4U3t4ZTch9K4J9 SK96p0Mi5WExzinliLnixtiBOmxbumnO2d0b9zoIlFGqv+iQELwzYVaHrbKj7nwHd++TahXgf2f 88WGns9O3nqrDzfTYkQDiFb+BmGTmmLz9cYNHKeKFBbpzFnZxKZ5BhnxCechWj64NqPY3Ps= X-Received: by 2002:a05:6a21:7a93:b0:1ee:e785:a08a with SMTP id adf61e73a8af0-1f0fc781da5mr7421850637.29.1740501900067; Tue, 25 Feb 2025 08:45:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzhySqJhghGiZsMKmpZdjhwmssEsTGd4irosiubrI41LuqK1kzfshthHtszlA7LkJtnyROAA== X-Received: by 2002:a05:6a21:7a93:b0:1ee:e785:a08a with SMTP id adf61e73a8af0-1f0fc781da5mr7421800637.29.1740501899691; Tue, 25 Feb 2025 08:44:59 -0800 (PST) Received: from [10.227.110.203] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7347a7f8258sm1727164b3a.112.2025.02.25.08.44.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Feb 2025 08:44:59 -0800 (PST) Message-ID: <21ad3381-4d65-4c68-892d-9f485bf13735@oss.qualcomm.com> Date: Tue, 25 Feb 2025 08:44:57 -0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: x1e80100-slim7x: Drop incorrect qcom,ath12k-calibration-variant To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Jeff Johnson , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org References: <20250225093051.58406-1-krzysztof.kozlowski@linaro.org> <7b54e965-3395-4349-8ae7-51a28c759235@linaro.org> From: Jeff Johnson Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: o2-VdkqXpI8NWkR9uA0lazuOW0VfNv7R X-Proofpoint-ORIG-GUID: o2-VdkqXpI8NWkR9uA0lazuOW0VfNv7R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-25_05,2025-02-25_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 adultscore=0 mlxlogscore=795 impostorscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502250107 On 2/25/2025 4:14 AM, Krzysztof Kozlowski wrote: > On 25/02/2025 12:45, Dmitry Baryshkov wrote: >> On Tue, Feb 25, 2025 at 11:22:25AM +0100, Krzysztof Kozlowski wrote: >>> On 25/02/2025 10:50, Dmitry Baryshkov wrote: >>>> On Tue, Feb 25, 2025 at 10:30:51AM +0100, Krzysztof Kozlowski wrote: >>>>> There is no such property as qcom,ath12k-calibration-variant: neither in >>>>> the bindings nor in the driver. See dtbs_check: >>>>> >>>>> x1e80100-lenovo-yoga-slim7x.dtb: wifi@0: 'qcom,ath12k-calibration-variant' does not match any of the regexes: 'pinctrl-[0-9]+' >>>>> >>>> >>>> Adding Jeff and ath12k@ to the cc list. Is the driver able to find the >>>> calibration variant in case it is not running on the ACPI system? I see >>>> that it uses dmi_walk. Does it work in the non-ACPI case? >>> >>> >>> But nothing parses such string as 'qcom,ath12k-calibration-variant' (see >>> git grep), so how would driver use it? >> >> That's what I'm asking: is the property redundant or is it correct and >> it is a driver that needs to be fixed? > > I assume driver will need something like that property, but that's not a > reason to accept incorrect one in DTS. One cannot add properties to DTS > without bindings, so bypassing bindings review, and then claim "but my > driver needs them". Send proper patches for driver first which will get > a review. We definitely need a calibration variant entry. I've pinged the development team to get the driver patch. I'm also verifying internally that there are no issues with your renaming proposal: qcom,ath1*k-calibration-variant => qcom,calibration-variant https://msgid.link/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@linaro.org /jeff