From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B04644E649 for ; Mon, 21 Sep 2026 08:06:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789977962; cv=none; b=Zxf65EDc68CPhIjBLOK9iJ2psTx4vPvHtMESJYqWPAKGtF7aElIh7u80Zbe2qqr5/wimzxhOCl0cV/vy7nt0ne06KLPOYkOdATGgmFWnxjwHrB66jzeennehLkT5BnLBeU8vq5kzo1xs4FjCs8BZvQoEoOby3gyjG+s/nqY7BzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789977962; c=relaxed/simple; bh=qA+sfwYzHhJ7yBQQa+Jpqy8+4pxE8vXtXtY16x7quWc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AwDBYgE30CwCFvBNiCJiI8SPeYS/z/2UqXfNTK6jhG9qfAJKQuOGdJBH5zPUFoIoZcY0aenczlCDIZVcE1804QqmrduJ0JvrzOG/pi5A+o2aMRcK79+pad6mPoolGvu6z180/qkczurfKYwaTKMd6t3qX700RMta1xCqzS+ss1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=M4X2Xqi/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EX37xoAJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="M4X2Xqi/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EX37xoAJ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68L7EHrw759262 for ; Mon, 21 Sep 2026 08:05:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z79Try10M8mBO4B/q2nr1hKgnYNAKB8UXw+vU+u74Rc=; b=M4X2Xqi/v44u4tKK w+LVJIagX+aNoy10oOp0dN+F3hkp2q7bfNKNs/39oRMTIs9v6dFfkyUT0eoKCDZn FHbbWVfL0MelxtauREK5xCAiuZeHogGZzOxl5bOJ/judbOr+paGJ79Z0eYf8GTpE YGv8Qj7/qn+rC9I+9HBTGeA60TOm+Ymp8fIM/65EBfFJFQRr+eNFqwFUaBbZgi4o n6w2CZ6FD5SRKB7X4M7V9A3gLRO/urFkPT211lBEW7OYPHuavpmTreeRhMqpmNsq OBVhXHkc6fz2eOOWZh6LbRlYRfIy3MmFDX2UTYCufyMe1J+TqDAxvYBXT1zbxlIR FFzeWw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gu01186d3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 21 Sep 2026 08:05:59 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-93821883e26so124484185a.2 for ; Mon, 21 Sep 2026 01:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789977958; x=1790582758; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=z79Try10M8mBO4B/q2nr1hKgnYNAKB8UXw+vU+u74Rc=; b=EX37xoAJzPPdfi/ZZRSt5IQSnt6weF9GNp9Ik9svzCLh1Vg/9StDBU0mTFunryBt4D EBlZh3nz6oW+HyccOlxsfvaAVZE+kREbDpX4IdUMGBvM84Zv4zgh23CwZm81oltWKQIq RatS+oDk2FwgddyABSXU7CI6FNa2jbNg4LTLpCdIp/Befmt5vS5ZGS+0EwIAEwB4UH8K fTigx99AwnN/caKMNKiCiLZ+0tjVb/cS+awACj17Hh+p3MctsTDpkkSmwnc+O2m9Eqz9 dElKcltWWGmlssDSOAU0w1HT4Q63XfLZ4WGdz5QvIb/dQEymDiw8bLoBW41SjqY9OtFz skjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789977958; x=1790582758; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z79Try10M8mBO4B/q2nr1hKgnYNAKB8UXw+vU+u74Rc=; b=gULYlEOey5AcNwrghvvnyqlFKC+dCxGkhfgyKCNYRcQjkWzrK0EPiA4+4M76+OsgYn TiEpxBIvDPErCxHamoU3/j753wVldzQVLNU1bcvLAYpdm5eY5ToQpRuZdpyNFbNtoE53 prrdWvnDjXvu8ZOvcIgkIpxYifybHmJTwOtWTKF25134u0279Yf7krwerp+qil49IwK/ /xqaUEklawUKWI1z+d+L64Gwc3LquMj53G+vnf2sZq1eng9ohXdkLZ7qLRiaA8AJwf1o 0dRPmJaWrFP5woCNj77f/MXqDXC4VaOV46SxHIa4O4sRoyk7ix1juMfM2F8K16x0iT+l 0LCg== X-Forwarded-Encrypted: i=1; AKwUvBwvjnSTGAoKYsOKzQ3FCDdkW6VkqPL9Eq4A2hbOQssVlpsOae/toePXKDZ/eky8I80xYKhAD1X/+JjC@vger.kernel.org X-Gm-Message-State: AFuF++lO0A1EVmfs0k0bxS89n8dV21R0AuxcyxEOUgJVcCKVE3gdjISY zXuuDRQ0gvfOEDpfl1ZGOYD/yLrRpmz/KEb7nPTWTNOszUFad84P00U84DznyZ1OC4kd5e/kAaV J2SfzPj+fnAZ9BPTCbB60kTXDcQgvK52m9oO5GZ3+ysKpwzqaHjbbqgyUW1mpgq63 X-Gm-Gg: AYBFou3FwZ9j550JcJSuB+lLgavcfm9X8Gqq7IDdsu8HTvWVRJkioViKmdaGLhDCX0B lYRjJsi9OLAiJL/Zf41mNi7KSYDTZqArxi2XQoa9RS9g/1IaGOW6ZGs9BVYkBgOJOtcHhBLgNJ8 7vhhstNvq3sxgfhgz1nmz0qDq1eqGe7c5o+eAeRgkbcyEvowLmBQhujyB2wVV47ASBvQ59Oy/s2 atEzPKMiz0MZTicxisdifrCEjaQFHNnuwbKhWRy84NCn/QJzL8k+vnOO9MicuXkQ/CpmQWca/YE dutIXkVhYfyLs8ALwneOiXqT2SaobQU5FZWETLy+aXImSeaL1G7qf1/QnHa1oIVmKAt6G1XBobZ H7UTY4A/IcC6DnqqlvFLJig== X-Received: by 2002:a05:620a:2814:b0:93a:1312:ff19 with SMTP id af79cd13be357-93bf580a3dfmr872922685a.5.1789977958616; Mon, 21 Sep 2026 01:05:58 -0700 (PDT) X-Received: by 2002:a05:620a:2814:b0:93a:1312:ff19 with SMTP id af79cd13be357-93bf580a3dfmr872919385a.5.1789977957968; Mon, 21 Sep 2026 01:05:57 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c2a640f9ef5sm168057366b.25.2026.09.21.01.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Sep 2026 01:05:57 -0700 (PDT) Message-ID: <21b8c9c5-db26-45df-87e3-822db9cd11ea@oss.qualcomm.com> Date: Mon, 21 Sep 2026 10:05:54 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sda660-inforce-ifc6560: fix ADV7535 interrupt pin To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , Bartosz Golaszewski , Marijn Suijten , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260920-ifc6560-adv-v1-1-89b1435d00c2@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260920-ifc6560-adv-v1-1-89b1435d00c2@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 5aZxlWN0yahzLQAEMrMbsXU2xMpGgFbO X-Authority-Analysis: v=2.4 cv=dPczC+Zb c=1 sm=1 tr=0 ts=6ab0e567 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=RPWKvmICn8r4TwR_xsAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTIxMDExNSBTYWx0ZWRfX7LC+awbbNcox yk1VBYcOE/2ucRWEJYDXdTy66UpiPRBqaRNvjmk/WuKdsUK4Mju9+lna17UIYzyttRvAhlNWy/q Xou4aB2N7mt6YAVTkkCQhAeVwJKW8tCdm+rVg06E1xtm8VYT/He9dYA/sO4TwcU0s42KNB8xeNB RE/TJNxK700HIWdhTCpsxZIsY/szGJNSZBqHiBSGtzssCjVIutQi/uy9yJSxB5RhCybQuZ5EqPs x3OslTGQV7mFoPjQWANnohCbE3XumXFoeZPPyaIakZ6EXUCHrtbJXP/JXVzHG4Dlz3LXixJa2tM XGv1R11yLZxUsSYOLZIxivpPWzCOhXEp1KD6aUM7LzIQPT+Fzh4dAsx2sdfJCx1UzElQQzFS1td d1zjsj96HZFigQHHoSBFr85jraQ/fZN13RpDrLCCM5vVoXuJb1Wwmz7GUvz0ZOPoG2H+btQvEZR MiBe8QUFgrkfrdW+ARQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwOTIxMDExNSBTYWx0ZWRfX/x2PCTWFjr+u sLHt+6CO84Bt/yTLCXMiAUfGX4uLq7ziq5d5FgNxa3zMPvjDMwF8KqRJK4nMhYSRkrRrnVsN0WH Xdr3EyR0W/2ysg0EkrmQQ0qqnuU3PhQ= X-Proofpoint-ORIG-GUID: 5aZxlWN0yahzLQAEMrMbsXU2xMpGgFbO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-21_03,2026-09-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609210115 On 9/20/26 1:11 PM, Dmitry Baryshkov wrote: > Probing the ADV7535 HDMI bridge fails on the IFC6560: > > gpio gpiochip3: (800f000.spmi:pmic@2:gpio@c000): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ > gpio gpiochip3: (800f000.spmi:pmic@2:gpio@c000): unable to lock HW IRQ 10 for IRQ > > The bridge's interrupt line is PM660L GPIO11, but the board never > configures that pad. pmic_gpio_populate() reads back the state left by > the bootloader, which is PMIC_GPIO_MODE_DIGITAL_OUTPUT, so > pmic_gpio_get_direction() reports GPIO_LINE_DIRECTION_OUT and > gpiochip_lock_as_irq() refuses the line. Requesting the interrupt then > fails and the bridge does not probe. > > Add a default pinctrl state switching the pad to digital input, applied > by pinctrl_bind_pins() before the driver requests the interrupt. The > ADV7535 INT pin is open-drain and pulled up on the board, so leave the > internal bias disabled. > > Fixes: 34279d6e3f32 ("arm64: dts: qcom: sdm660: Add initial Inforce IFC6560 board support") > Assisted-by: LLM > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts > index 9e14f53b552e..fdedae49d1d0 100644 > --- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts > +++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts > @@ -170,6 +170,9 @@ adv7533: hdmi@39 { > interrupt-parent = <&pm660l_gpios>; > interrupts = <11 IRQ_TYPE_EDGE_FALLING>; > > + pinctrl-0 = <&adv7533_int_default>; > + pinctrl-names = "default"; > + > clocks = <&rpmcc RPM_SMD_BB_CLK2>; > clock-names = "cec"; > /* > @@ -285,6 +288,16 @@ sw_ctrl_default: sw-ctrl-default-state { > }; > }; > > +&pm660l_gpios { > + adv7533_int_default: adv7533-int-default-state { > + pins = "gpio11"; > + function = "normal"; > + > + input-enable; strange \n in the middle > + bias-disable; Plus you'd likely want a PU here, unless there's one onboard Konrad