From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?U8O2cmVu?= Brinkmann Subject: Re: [RFC PATCH] edac: zynq: Added EDAC support for zynq ddr ecc controller Date: Tue, 11 Mar 2014 08:50:57 -0700 Message-ID: <21bfd874-8084-4d23-b973-42a0e50157bc@AM1EHSMHS009.ehs.local> References: <4adb2b4b-2ad6-42b9-929e-cc062f817245@TX2EHSMHS021.ehs.local> <20140310105655.GH14999@e106331-lin.cambridge.arm.com> <531DA900.5060202@monstr.eu> <531ECA33.8050803@monstr.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <531ECA33.8050803@monstr.eu> Sender: linux-kernel-owner@vger.kernel.org To: Michal Simek Cc: Mark Rutland , Punnaiah Choudary Kalluri , "dougthompson@xmission.com" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "michal.simek@xilinx.com" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "rob@landley.net" , "kpc528@gmail.com" , "kalluripunnaiahchoudary@gmail.com" punnai List-Id: devicetree@vger.kernel.org On Tue, 2014-03-11 at 09:32AM +0100, Michal Simek wrote: > On 03/10/2014 11:32 PM, S=C3=B6ren Brinkmann wrote: > > On Mon, 2014-03-10 at 12:58PM +0100, Michal Simek wrote: > >> On 03/10/2014 11:56 AM, Mark Rutland wrote: > >>> On Sun, Mar 09, 2014 at 02:57:16AM +0000, Punnaiah Choudary Kallu= ri wrote: > >>>> Added EDAC support for reporting the ecc errors of zynq ddr cont= roller. > >>>> The ddr ecc controller corrects single bit errors and detects do= uble bit > >>>> errors > >>>> > >>>> Signed-off-by: Punnaiah Choudary Kalluri > >>>> --- > >>>> .../devicetree/bindings/edac/zynq_edac.txt | 18 + > >>>> drivers/edac/Kconfig | 7 + > >>>> drivers/edac/Makefile | 1 + > >>>> drivers/edac/zynq_edac.c | 613 +++++= +++++++++++++++ > >>>> 4 files changed, 639 insertions(+), 0 deletions(-) > >>>> create mode 100644 Documentation/devicetree/bindings/edac/zynq_= edac.txt > >>>> create mode 100644 drivers/edac/zynq_edac.c > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/edac/zynq_edac.tx= t b/Documentation/devicetree/bindings/edac/zynq_edac.txt > >>>> new file mode 100644 > >>>> index 0000000..c21ff83 > >>>> --- /dev/null > >>>> +++ b/Documentation/devicetree/bindings/edac/zynq_edac.txt > >>>> @@ -0,0 +1,18 @@ > >>>> +Zynq EDAC driver, it does reports the DDR ECC single bit errors= that are > >>>> +corrected and double bit ecc errors that are detected by the DD= R ECC controller. > >>>> +ECC support for DDR is available in half-bus width(16 bit) conf= iguration only. > >>>> + > >>>> +Required properties: > >>>> +- compatible: Should be "xlnx,ps7-ddrc" or "xlnx,ps7-ddrc-1.00.= a" > >>> > >>> Is this an or or a xor? > >> > >> Compatible string should be just xlnx,zynq-ddrc-1.00.a. > >> Nothing with ps7. > >=20 > > Isn't this vendor IP? IMHO, this should be something completely > > different. Or if you want some Zynq-specific compat string it shoul= d > > refer to an actual version string associated with Zynq. 1.00.a is n= ot, > > AFAIK. >=20 > I have checked with Punnaiah that this is Synopsys DDR memory control= ler. > Zynq is based on 1.4 version with some customization. > It means I think reasonable solution is > call it drivers/edac/synopsys_edac.c > rename zynq_ in driver to synopsys_ and > use xlnx,zynq-ddrc-1.00.a compatible string because zynq is not using > clean synopsys version. >=20 > I am not getting point why you don't like 1.00.a suffix here. > Because of historical point of view compatible strings should be diff= erent > for early silicon, silicon v1, silicon v2, silicon v3, etc > but we haven't used it at all that's why we can use xilinx scheme > which we are using for our soft IPs. Well, but you refer to Zynq which has silicon revisions you can use to refer to a specific Zynq version. That matches data sheets. Zynq-1.00.a is just completely made up and wouldn't be found in any data sheet. S=C3=B6ren