From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>,
avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
olivia@selenic.com, herbert@gondor.apana.org.au,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: openbmc@lists.ozlabs.org, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 2/2] hwrng: npcm: Add NPCM8XX support
Date: Thu, 22 Sep 2022 17:08:34 +0200 [thread overview]
Message-ID: <21cc4e52-d0d9-8f07-fa74-ea62bb01432a@linaro.org> (raw)
In-Reply-To: <20220922142216.17581-3-tmaimon77@gmail.com>
On 22/09/2022 16:22, Tomer Maimon wrote:
> static int npcm_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait)
> @@ -102,6 +103,11 @@ static int npcm_rng_probe(struct platform_device *pdev)
> pm_runtime_use_autosuspend(&pdev->dev);
> pm_runtime_enable(&pdev->dev);
>
> + if (of_device_is_compatible(pdev->dev.of_node, "nuvoton,npcm750-rng"))
> + priv->clkp = NPCM_RNG_CLK_SET_25MHZ;
> + if (of_device_is_compatible(pdev->dev.of_node, "nuvoton,npcm845-rng"))
> + priv->clkp = NPCM_RNG_CLK_SET_62_5MHZ;
No, don't sprinkle compatibles here and there. Driver data is for this.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-09-22 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 14:22 [PATCH v1 0/2] rng: npcm: add Arbel NPCM8XX support Tomer Maimon
2022-09-22 14:22 ` [PATCH v1 1/2] dt-bindings: rng: nuvoton,npcm-rng: Add npcm845 compatible string Tomer Maimon
2022-09-22 15:08 ` Krzysztof Kozlowski
2022-09-22 17:30 ` Krzysztof Kozlowski
2022-09-22 17:29 ` Krzysztof Kozlowski
2022-09-22 14:22 ` [PATCH v1 2/2] hwrng: npcm: Add NPCM8XX support Tomer Maimon
2022-09-22 15:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21cc4e52-d0d9-8f07-fa74-ea62bb01432a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox