From: Andrew Davis <afd@ti.com>
To: Achal Verma <a-verma1@ti.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4: Add initial PCIe/SerDes support for J784S4
Date: Fri, 19 May 2023 12:46:14 -0500 [thread overview]
Message-ID: <21d73701-c8dc-765d-8d2f-bf15ea4caad0@ti.com> (raw)
In-Reply-To: <20230515070219.2381457-1-a-verma1@ti.com>
On 5/15/23 2:02 AM, Achal Verma wrote:
> From: Matt Ranostay <mranostay@ti.com>
>
> J784S4 SoC supports two PCIE instances as follows:
> * PCIE0 - 4x lanes
> * PCIE1 - 4x lanes
>
> J784S4 EVM board has the following PCIE connectors:
> * PCIE0 - 4x lanes
> * PCIE1 - 2x lanes
>
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> Signed-off-by: Achal Verma <a-verma1@ti.com>
> ---
>
> This patch depends on:
> https://lore.kernel.org/all/20230310111630.743023-1-s-vadapalli@ti.com/
> https://lore.kernel.org/all/20230425131607.290707-1-j-choudhary@ti.com/
> https://lore.kernel.org/all/20230401112633.2406604-1-a-verma1@ti.com/
>
> arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 65 +++++++++++
> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 126 +++++++++++++++++++++
I would split this into two patches, first add the nodes to the MAIN domain
dtsi file. Then after enable the SerDes and PCIe nodes for the EVM board.
Also, drop the pcie0_ep nodes, reasoning here:
https://lore.kernel.org/lkml/20230515172137.474626-2-afd@ti.com/
Andrew
prev parent reply other threads:[~2023-05-19 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 7:02 [PATCH] arm64: dts: ti: k3-j784s4: Add initial PCIe/SerDes support for J784S4 Achal Verma
2023-05-16 15:47 ` kernel test robot
2023-05-19 17:46 ` Andrew Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21d73701-c8dc-765d-8d2f-bf15ea4caad0@ti.com \
--to=afd@ti.com \
--cc=a-verma1@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).