From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7034FC49EA7 for ; Fri, 25 Jun 2021 17:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D92061879 for ; Fri, 25 Jun 2021 17:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229573AbhFYRdM (ORCPT ); Fri, 25 Jun 2021 13:33:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbhFYRdM (ORCPT ); Fri, 25 Jun 2021 13:33:12 -0400 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C292C061574; Fri, 25 Jun 2021 10:30:51 -0700 (PDT) Received: by mail-pg1-x52b.google.com with SMTP id p9so8294169pgb.1; Fri, 25 Jun 2021 10:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AEVXAtzRdBnXjTYBUkXKyLLq/QP8vZTU+6eBNnFCfNY=; b=JsNQ1EOdCmRHmdIUMwk7W+3dSlif5ZBdGuIrCU8FRyUfISBFd88dg511IEs/lMsHdL LV9N0ecJcHXNEXDQfGQkEGsfuJjznIUkVg+8s+omlLDP3TxJ6A5yMAIE+CZQBjJyIEVz Rz9/drioEC6VrGur/BAVgAjVXvPI67EKYTP5d/jXaLn952AjsxZdMsWVI1Mpr5KJaN4z 68wrlMzUIS7LmmgVj5IfkfOuTLDSRCqB9SuTV+kZif8MzkFwQD7WvGx610ND2q966zcW WYqQRK1QWoog9mca9wdW1eP93dN4aGk5DFi8kdrS78VttsAP7Y5lVigkE7uRfxFQuysm SAqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AEVXAtzRdBnXjTYBUkXKyLLq/QP8vZTU+6eBNnFCfNY=; b=I4nbjTYREcCtsRoDHsd1op2TgKjJZyhMpfA1Kr5f5zxM+2xGRHcseVKjOuPMV13r+j x1qCdP9ixJTwuUQOkgmUe6PpUk1wt05mUqqzu0xe5dGPMwlI12oxyz6WE3+VmgqRnPIB djW1/fiRK6/zlR2rJ5LONqBus+H3LN3nVMdz8DHlDt4rJhFRd5LZHVFAweU2DR4BH2FE wgjeDu+LPHeCfPyN9M5WMd1369XuNDPbcLDeCoawqdEWF0ER7pRG2o8Jcalmt1+BbvMW kgxJZtTTG9n0R1XZFjQujianSCrd7eIMqQQbKi9ZfLvP+sSfS2WSl10tohqngPgSsBNz ql6g== X-Gm-Message-State: AOAM5326TwwVaz7g6l1Maz7IdAr+xgHAF6Fb8MC0+zJH0H7aLe7ksBhC keulOouQHwKN6yXVvFQyTsg= X-Google-Smtp-Source: ABdhPJzluJfbq3Os5qaSBw+XQr/q4Y3cVOkWhKV4j4z/zfh1dpyOtoQhTFB7QOgto30AvTYLOOyS1Q== X-Received: by 2002:a63:fc51:: with SMTP id r17mr8472427pgk.403.1624642250621; Fri, 25 Jun 2021 10:30:50 -0700 (PDT) Received: from [10.67.49.104] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id s13sm6216158pgi.36.2021.06.25.10.30.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Jun 2021 10:30:49 -0700 (PDT) Subject: Re: [PATCH v4 2/4] ARM: dts: NSP: Add DT files for Meraki MX64 series To: Matthew Hagan , Arnd Bergmann List-Id: Cc: Florian Fainelli , Vladimir Oltean , Rob Herring , Olof Johansson , SoC Team , Ray Jui , Scott Branden , bcm-kernel-feedback-list , Viresh Kumar , Sam Ravnborg , Geert Uytterhoeven , DTML , Linux Kernel Mailing List , Linux ARM References: <20210625095000.3358973-1-mnhagan88@gmail.com> <20210625095000.3358973-3-mnhagan88@gmail.com> From: Florian Fainelli Message-ID: <21e895e9-0211-0c97-5e9e-781e6d2fe6dd@gmail.com> Date: Fri, 25 Jun 2021 10:30:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 6/25/21 10:26 AM, Matthew Hagan wrote: > On 25/06/2021 10:59, Arnd Bergmann wrote: > >> On Fri, Jun 25, 2021 at 11:52 AM Matthew Hagan wrote: >>> MX64 & MX64W Hardware info: >>> - CPU: Broadcom BCM58625 Cortex A9 @ 1200Mhz >>> - RAM: 2 GB (4 x 4Gb SK Hynix H5TC4G83CFR) >>> - Storage: 1 GB (Micron MT29F8G08ABACA) >>> - Networking: BCM58625 internal switch (5x 1GbE ports) >>> - USB: 1x USB2.0 >>> - Serial: Internal header >>> - WLAN(MX64W only): 2x Broadcom BCM43520KMLG on the PCI bus >>> >>> This patch adds the Meraki MX64 series-specific bindings. Since some >>> devices make use of the older A0 SoC, changes need to be made to >>> accommodate this case, including removal of coherency options and >>> modification to the secondary-boot-reg. >>> >>> Signed-off-by: Matthew Hagan >> Removing the dma-coherent flags in the dts file seemed really odd until >> I read the text above. It would seem more logical to me to have a .dtsi file >> that has all the a0 revision specific changes, and include that from the >> dts file. > > How about having separate bcm-nsp-ax and bcm-nsp-bx dtsi files with the > appropriate secondary-boot-reg and dma-coherent (or lack of) > properties, which then include bcm-nsp.dtsi. Thus we can also avoid use > of /delete-property/. Would this be preferable? Is there any way that the Ax platforms could use a small shim between the boot loader and the kernel which could all of the necessary DT adaptation so the kernel only contains a single Device Tree source? Using something like this: https://github.com/zonque/pxa-impedance-matcher/ could be useful. > >> >> On the other hand, the /chosen, /aliases and /memory nodes that you have >> in the .dtsi file should probably get moved into the .dts files, as these tend >> to be board specific settings, even if the examples you have are all >> the same. > > I did not come across any convention regarding this, though there are > plenty of cases where the /chosen, /aliases and /memory nodes are > defined in a .dtsi file and used by multiple similar boards. Also note > in this case /aliases is defined in bcm-nsp.dtsi, not by me. Would we > not prefer to avoid having 6x duplication? > >> Arnd >> > Matthew > -- Florian