From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jun Guo <jun.guo@cixtech.com>
Cc: peter.chen@cixtech.com, fugang.duan@cixtech.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
ychuang3@nuvoton.com, schung@nuvoton.com, robin.murphy@arm.com,
Frank.Li@kernel.org, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
cix-kernel-upstream@cixtech.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/3] dt-bindings: dma: arm-dma350: document generic and combined IRQ topologies
Date: Fri, 20 Mar 2026 14:12:27 +0100 [thread overview]
Message-ID: <21ef18ef-a6e8-41a1-8280-73ee058fdc74@kernel.org> (raw)
In-Reply-To: <40fc5cb7-a5f2-4b86-8dba-1b39e1ea0da4@cixtech.com>
On 20/03/2026 11:28, Jun Guo wrote:
>>> + description: |
>>> + The DMA controller may be configured with separate interrupts for each channel,
>>> + or with a single combined interrupt for all channels, depending on the SoC integration.
>>
>> And more important - you must review the LLM microslop output before
>> posting and adjust it to Linux kernel coding style. Don't send
>> unredacted tool output.
>>
> Actually, this part of the description was not AI-generated. However,
> I’d like to confirm the issue you mentioned: are you saying that this
> description is written too verbosely?
> Then, do you think there are still issues with the revised version?
> interrupts:
> minItems: 1
> maxItems: 8
> description:
> Either one interrupt per channel (8 interrupts), or one
> combined interrupt for all channels.
No, it is not wrapped according to Linux coding style.
Please wrap code according to the preferred limit expressed in Kernel
coding style (checkpatch is not a coding style description, but only a
tool). However don't wrap blindly (see Kernel coding style).
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-20 13:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 10:17 [PATCH v3 0/3] dmaengine: arm-dma350: support combined IRQ topology Jun Guo
2026-03-19 10:17 ` [PATCH v3 1/3] dt-bindings: dma: arm-dma350: document generic and combined IRQ topologies Jun Guo
2026-03-20 9:12 ` Krzysztof Kozlowski
2026-03-20 9:38 ` Peter Chen
2026-03-20 9:43 ` Krzysztof Kozlowski
2026-03-20 9:58 ` Peter Chen
2026-03-20 10:04 ` Krzysztof Kozlowski
2026-03-23 2:09 ` Jun Guo
2026-03-23 7:27 ` Krzysztof Kozlowski
2026-03-23 7:51 ` Jun Guo
2026-03-20 10:28 ` Jun Guo
2026-03-20 13:12 ` Krzysztof Kozlowski [this message]
2026-03-21 8:20 ` Jun Guo
2026-03-19 10:17 ` [PATCH v3 2/3] dma: arm-dma350: support combined IRQ mode with runtime IRQ topology detection Jun Guo
2026-03-19 10:17 ` [PATCH v3 3/3] arm64: dts: cix: add DT nodes for DMA Jun Guo
2026-03-20 9:13 ` Krzysztof Kozlowski
2026-03-20 10:08 ` Jun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21ef18ef-a6e8-41a1-8280-73ee058fdc74@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fugang.duan@cixtech.com \
--cc=jun.guo@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=schung@nuvoton.com \
--cc=vkoul@kernel.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox