From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Szyprowski Subject: Re: [RFT v4 5/8] ARM: dts: exynos: Remove MCT subnode for interrupt map on Exynos4412 Date: Tue, 24 Sep 2019 08:58:44 +0200 Message-ID: <21fdac03-cb35-34eb-c48e-52985377aa16@samsung.com> References: <20190923161411.9236-1-krzk@kernel.org> <20190923161411.9236-5-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190923161411.9236-5-krzk@kernel.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski , Daniel Lezcano , Thomas Gleixner , Rob Herring , Mark Rutland , Kukjin Kim , Andrzej Hajda , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: Sylwester Nawrocki List-Id: devicetree@vger.kernel.org On 23.09.2019 18:14, Krzysztof Kozlowski wrote: > Multi Core Timer node has interrupts routed to two different parents - > GIC and combiner. This was modeled with a interrupt-map within a > subnode but can be expressed in an easier and more common way, directly > in the node itself. > > Tested on Odroid U3 (Exynos4412). > > Signed-off-by: Krzysztof Kozlowski Tested-by: Marek Szyprowski Works fine on Trats2 board. > --- > > Changes since v3: > 1. Use interrupts-extended instead of interrupts-map. > --- > arch/arm/boot/dts/exynos4412.dtsi | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi > index 8b6d5875c75d..9b5fb4e54d7c 100644 > --- a/arch/arm/boot/dts/exynos4412.dtsi > +++ b/arch/arm/boot/dts/exynos4412.dtsi > @@ -246,22 +246,13 @@ > timer@10050000 { > compatible = "samsung,exynos4412-mct"; > reg = <0x10050000 0x800>; > - interrupt-parent = <&mct_map>; > - interrupts = <0>, <1>, <2>, <3>, <4>; > clocks = <&clock CLK_FIN_PLL>, <&clock CLK_MCT>; > clock-names = "fin_pll", "mct"; > - > - mct_map: mct-map { > - #interrupt-cells = <1>; > - #address-cells = <0>; > - #size-cells = <0>; > - interrupt-map = > - <0 &gic 0 57 IRQ_TYPE_LEVEL_HIGH>, > - <1 &combiner 12 5>, > - <2 &combiner 12 6>, > - <3 &combiner 12 7>, > - <4 &gic 1 12 IRQ_TYPE_LEVEL_HIGH>; > - }; > + interrupts-extended = <&gic 0 57 IRQ_TYPE_LEVEL_HIGH>, > + <&combiner 12 5>, > + <&combiner 12 6>, > + <&combiner 12 7>, > + <&gic 1 12 IRQ_TYPE_LEVEL_HIGH>; > }; > > watchdog: watchdog@10060000 { Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland