From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: renesas,fcp: Document RZ/{G2,V2}L FCPVD bindings
Date: Wed, 31 Aug 2022 18:38:03 +0300 [thread overview]
Message-ID: <22006cfb-d0d6-8364-dc93-23a430ecbb37@linaro.org> (raw)
In-Reply-To: <OS0PR01MB5922C8F9B25D2F54716CD73086789@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On 31/08/2022 18:32, Biju Das wrote:
>>> properties:
>>> compatible:
>>> - enum:
>>> - - renesas,fcpv # FCP for VSP
>>> - - renesas,fcpf # FCP for FDP
>>> + oneOf:
>>> + - items:
>>
>> No items here. You have just one item, so it is not a list.
>
> So you mean, it should be like below.
> Can you please confirm my understanding is correct?
>
> oneOf:
> - enum:
> - renesas,fcpv # FCP for VSP
> - renesas,fcpf # FCP for FDP
> - items:
> - enum:
> - renesas,r9a07g044-fcpvd # RZ/G2{L,LC}
> - renesas,r9a07g054-fcpvd # RZ/V2L
> - const: renesas,fcpv # generic FCP for VSP fallback
Yes
>
>
>>> + - renesas,fcpv # FCP for VSP
>>> + - renesas,fcpf # FCP for FDP
>>
>>> + - enum:
>>> + - renesas,fcpv # FCP for VSP
>>> + - renesas,fcpf # FCP for FDP
>>> +
>>> + - items:
>>> + - enum:
>>> + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC}
>>> + - renesas,r9a07g054-fcpvd # RZ/V2L
>>> + - const: renesas,fcpv # generic FCP for VSP fallback
>>>
>>> reg:
>>> maxItems: 1
>>>
>>> - clocks:
>>> - maxItems: 1
>>> + clocks: true
>>> + clock-names: true
>>
>> Both should have here the widest constraints: minItems:1 and maxItems:3.
>
> It is taken care in conditional schema right?
>
> It is same as [1], where wider people including you added Rb tag.
Yeah, it's fine.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-31 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 14:37 [PATCH v2 0/3] Enable {fcpvd,vspd} on RZ/G2L SoC Biju Das
2022-08-31 14:37 ` [PATCH v2 1/3] media: dt-bindings: media: renesas,fcp: Document RZ/{G2,V2}L FCPVD bindings Biju Das
2022-08-31 15:20 ` Krzysztof Kozlowski
2022-08-31 15:32 ` Biju Das
2022-08-31 15:38 ` Krzysztof Kozlowski [this message]
2022-08-31 14:37 ` [PATCH v2 2/3] arm64: dts: renesas: r9a07g044: Add fcpvd node Biju Das
2022-08-31 14:37 ` [PATCH v2 3/3] arm64: dts: renesas: r9a07g044: Add vspd node Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22006cfb-d0d6-8364-dc93-23a430ecbb37@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).