From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E3B8C0502A for ; Wed, 31 Aug 2022 15:38:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231872AbiHaPiJ (ORCPT ); Wed, 31 Aug 2022 11:38:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231721AbiHaPiI (ORCPT ); Wed, 31 Aug 2022 11:38:08 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C7FED8B3E for ; Wed, 31 Aug 2022 08:38:07 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id s15so9901771ljp.5 for ; Wed, 31 Aug 2022 08:38:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Z3ZI4XvX+f6Y7cApAgLVkRdYETFbOath1sGNU9vupZ4=; b=b1POBbSM7lSo25v8dwP/s4rQgN8da2aHfdWJn4/7tA5zV+NX2j6t90LqAqGdIAobhZ KBKs3BA72gEuVdgH2XeXiM/bHSbU9ka3o9ebQYyEeotDSimoNq85eQ1+A/T+ih2bI0+T Btjb7dr/NMENhTYIEKPgorXhk6m9Y94ZMl0iv8tZiA871/uJpK7pkaxUyXsr7OU8e/zQ 49jIlJTLFlasPHVQ35sXP6+brdo2LbuFt6rWoruC3UGxcndWYkNeIEKMvXkVAfY33TWe ll9ptzpEyIy70Ton+SaM5XyCKnTjVlvbft9hRQ4SJzC16AY7/3a+xBljrCimMLLBKh8q pRnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Z3ZI4XvX+f6Y7cApAgLVkRdYETFbOath1sGNU9vupZ4=; b=WjjsjU2/iEdycSsr4LzXPYvXZ2S+/FPBc/21TuNtuOcjTkMJphwrOeXttZqJBd1P9z R1vYBwSpXF6B+Wg3pIM/pgRwFTnCH7Bhz9CxJL07Qd9El1oGN6ix1h6kXSLRrsztg/gs yluskReR/oki7+BH/Kp6Fh9RLVlTpnTWO9I2dRDkxAvqnNnOcuJeFVjfrz6wb9Ri0q3P WyzVerT7vgA9gZpXgemUiYuCy+MX1JuQORTUhMGPCcXlDwHTH9H5bqVMU6G9osHv4IoH VFTXtBUP37gqHsor8ZJDA9BXT+Q6OrxZrFuHTHuFSwQChQ1fDG4CiST4Af3zh1/Fb3LP 7lXQ== X-Gm-Message-State: ACgBeo00P8Y6jxYl4xV6JbeFucr7T2p8j3gLkpR9pdZMDKemz8jfizfx rfVSVWHJEFHpceycLKvh8Ke8eg== X-Google-Smtp-Source: AA6agR7kqv/zHnly8NtxvS/C0gaan2dRtMD0fcbLdjkGIwJppHTSaRBuicOkowl2LkL1zlTcDp7Ckg== X-Received: by 2002:a2e:9e81:0:b0:268:894f:8118 with SMTP id f1-20020a2e9e81000000b00268894f8118mr1233938ljk.371.1661960285601; Wed, 31 Aug 2022 08:38:05 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id p15-20020ac24ecf000000b0049484d936ccsm402329lfr.24.2022.08.31.08.38.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 08:38:04 -0700 (PDT) Message-ID: <22006cfb-d0d6-8364-dc93-23a430ecbb37@linaro.org> Date: Wed, 31 Aug 2022 18:38:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: renesas,fcp: Document RZ/{G2,V2}L FCPVD bindings Content-Language: en-US To: Biju Das , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski Cc: Laurent Pinchart , "linux-media@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad References: <20220831143722.2067457-1-biju.das.jz@bp.renesas.com> <20220831143722.2067457-2-biju.das.jz@bp.renesas.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/08/2022 18:32, Biju Das wrote: >>> properties: >>> compatible: >>> - enum: >>> - - renesas,fcpv # FCP for VSP >>> - - renesas,fcpf # FCP for FDP >>> + oneOf: >>> + - items: >> >> No items here. You have just one item, so it is not a list. > > So you mean, it should be like below. > Can you please confirm my understanding is correct? > > oneOf: > - enum: > - renesas,fcpv # FCP for VSP > - renesas,fcpf # FCP for FDP > - items: > - enum: > - renesas,r9a07g044-fcpvd # RZ/G2{L,LC} > - renesas,r9a07g054-fcpvd # RZ/V2L > - const: renesas,fcpv # generic FCP for VSP fallback Yes > > >>> + - renesas,fcpv # FCP for VSP >>> + - renesas,fcpf # FCP for FDP >> >>> + - enum: >>> + - renesas,fcpv # FCP for VSP >>> + - renesas,fcpf # FCP for FDP >>> + >>> + - items: >>> + - enum: >>> + - renesas,r9a07g044-fcpvd # RZ/G2{L,LC} >>> + - renesas,r9a07g054-fcpvd # RZ/V2L >>> + - const: renesas,fcpv # generic FCP for VSP fallback >>> >>> reg: >>> maxItems: 1 >>> >>> - clocks: >>> - maxItems: 1 >>> + clocks: true >>> + clock-names: true >> >> Both should have here the widest constraints: minItems:1 and maxItems:3. > > It is taken care in conditional schema right? > > It is same as [1], where wider people including you added Rb tag. Yeah, it's fine. Best regards, Krzysztof