From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 3/4] ARM: dts: UniPhier: add support for UniPhier SoCs and boards Date: Thu, 16 Apr 2015 11:44:49 +0200 Message-ID: <2204571.AOVr95oO32@wuerfel> References: <1429170038-16757-1-git-send-email-yamada.masahiro@socionext.com> <1429170038-16757-4-git-send-email-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1429170038-16757-4-git-send-email-yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Masahiro Yamada Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kumar Gala , Ian Campbell , Rob Herring , Pawel Moll , Mark Rutland , Olof Johansson List-Id: devicetree@vger.kernel.org On Thursday 16 April 2015 16:40:37 Masahiro Yamada wrote: > + > +/ { > + model = "UniPhier PH1-LD4 Reference Board"; > + compatible = "socionext,ph1-ld4-ref", "socionext,ph1-ld4"; > + > + memory { > + device_type = "memory"; > + reg = <0x80000000 0x20000000>; > + }; > + > + chosen { > + bootargs = "console=ttyS0,115200 earlyprintk"; > + }; I would remove the 'earlyprintk' option here. You don't add any options for the platform in Kconfig.debug, and I hope that we can eventually start using earlycon. Please add an appropriate stdio-path property here, but note that we are still lacking the fixmap patches to make earlycon work. Otherwise looks good. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html