From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Imran Shaik <imran.shaik@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Brian Masney <bmasney@redhat.com>,
Dmitry Baryshkov <lumag@kernel.org>
Cc: Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 14/19] clk: qcom: gpucc-qcm2290: Keep the critical clocks always-on from probe
Date: Fri, 3 Jul 2026 09:30:18 +0200 [thread overview]
Message-ID: <221133d2-758a-4dd0-90d4-ac3f3525ab42@oss.qualcomm.com> (raw)
In-Reply-To: <20260703-shikra-dispcc-gpucc-v5-14-cc13826d4d5a@oss.qualcomm.com>
On 7/2/26 8:31 PM, Imran Shaik wrote:
> Drop modelling of gpu_cc_ahb_clk and keep it always enabled from probe
> similar to other critical clocks, since marking it as CLK_IS_CRITICAL
> causes the clock framework to invoke clk_pm_runtime_get() during prepare,
> which prevents the associated power domains from collapsing.
>
> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
> ---
Fixes: 8cab033628b1 ("clk: qcom: Add QCM2290 GPU clock controller driver")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-07-03 7:30 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 18:31 [PATCH v5 00/19] clk: qcom: Add DISPCC and GPUCC support for the Qualcomm Shikra SoC Imran Shaik
2026-07-02 18:31 ` [PATCH v5 01/19] clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe Imran Shaik
2026-07-04 0:12 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 02/19] dt-bindings: clock: qcom,qcm2290-dispcc: Add DSI1 PHY and sleep clocks Imran Shaik
2026-07-03 6:13 ` Krzysztof Kozlowski
2026-07-02 18:31 ` [PATCH v5 03/19] dt-bindings: clock: qcom,qcm2290-dispcc: Add missing power-domains property Imran Shaik
2026-07-03 6:15 ` Krzysztof Kozlowski
2026-07-02 18:31 ` [PATCH v5 04/19] dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller Imran Shaik
2026-07-03 6:14 ` Krzysztof Kozlowski
2026-07-02 18:31 ` [PATCH v5 05/19] dt-bindings: clock: qcom: Add Qualcomm Shikra GPU " Imran Shaik
2026-07-03 6:14 ` Krzysztof Kozlowski
2026-07-02 18:31 ` [PATCH v5 06/19] clk: qcom: dispcc-qcm2290: Move to the latest common qcom_cc_probe() model Imran Shaik
2026-07-03 7:13 ` Konrad Dybcio
2026-07-02 18:31 ` [PATCH v5 07/19] clk: qcom: dispcc-qcm2290: Switch to DT index based clk lookup Imran Shaik
2026-07-03 7:15 ` Konrad Dybcio
2026-07-04 0:17 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 08/19] clk: qcom: dispcc-qcm2290: Set HW_CTRL_TRIGGER flag for GDSC Imran Shaik
2026-07-03 7:24 ` Konrad Dybcio
2026-07-02 18:31 ` [PATCH v5 09/19] clk: qcom: qcm2290: Set POLL_CFG_GDSCR flag for DISPCC and GPUCC GDSCs Imran Shaik
2026-07-03 7:28 ` Konrad Dybcio
2026-07-04 0:18 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 10/19] clk: qcom: qcm2290: Add RETAIN_FF_ENABLE " Imran Shaik
2026-07-04 0:19 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 11/19] clk: qcom: qcm2290: Update DISPCC and GPUCC GDSC *wait_val values Imran Shaik
2026-07-03 7:19 ` Konrad Dybcio
2026-07-04 0:19 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 12/19] clk: qcom: gpucc-qcm2290: Drop pm_clk handling Imran Shaik
2026-07-03 7:29 ` Konrad Dybcio
2026-07-04 0:19 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 13/19] clk: qcom: gpucc-qcm2290: Move to the latest common qcom_cc_probe() model Imran Shaik
2026-07-03 7:11 ` Konrad Dybcio
2026-07-04 0:20 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 14/19] clk: qcom: gpucc-qcm2290: Keep the critical clocks always-on from probe Imran Shaik
2026-07-03 7:30 ` Konrad Dybcio [this message]
2026-07-04 0:21 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 15/19] clk: qcom: gpucc-qcm2290: Park RCG's clk source at XO during disable Imran Shaik
2026-07-03 7:42 ` Konrad Dybcio
2026-07-04 0:23 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 16/19] clk: qcom: Add support for Qualcomm GPU Clock Controller on Shikra Imran Shaik
2026-07-02 18:31 ` [PATCH v5 17/19] arm64: dts: qcom: agatti: Add DSI1 PHY and sleep clocks to DISPCC node Imran Shaik
2026-07-02 18:31 ` [PATCH v5 18/19] arm64: dts: qcom: agatti: Add missing CX power domain to DISPCC Imran Shaik
2026-07-03 7:09 ` Konrad Dybcio
2026-07-04 0:24 ` Dmitry Baryshkov
2026-07-02 18:31 ` [PATCH v5 19/19] arm64: dts: qcom: shikra: Add support for DISPCC/GPUCC nodes Imran Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=221133d2-758a-4dd0-90d4-ac3f3525ab42@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imran.shaik@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=lumag@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox