From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] libata, dt: Add clocks to sata_rcar bindings Date: Sun, 19 Jan 2014 21:16:42 +0100 Message-ID: <2218997.BjldcaRU33@avalon> References: <1389910062-17777-1-git-send-email-valentine.barshak@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1389910062-17777-1-git-send-email-valentine.barshak@cogentembedded.com> Sender: linux-ide-owner@vger.kernel.org To: Valentine Barshak Cc: linux-sh@vger.kernel.org, linux-ide@vger.kernel.org, devicetree@vger.kernel.org, Tejun Heo , Simon Horman , Magnus Damm , Kuninori Morimoto List-Id: devicetree@vger.kernel.org Hi Valentine, Thank you for the patch. On Friday 17 January 2014 02:07:42 Valentine Barshak wrote: > Now that the clocks are available in the R-Car Gen2 DT, > add clocks property description to the sata_rcar bindings. > The clocks have been tested on r8a7791 so we use that > as an example of the R-Car SATA node. > > The patch is against for-next branch of the libata git repo. > > Signed-off-by: Valentine Barshak > --- > Documentation/devicetree/bindings/ata/sata_rcar.txt | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt > b/Documentation/devicetree/bindings/ata/sata_rcar.txt index > 1e61113..6da60c0 100644 > --- a/Documentation/devicetree/bindings/ata/sata_rcar.txt > +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt > @@ -7,12 +7,14 @@ Required properties: > - "renesas,sata-r8a7791" for R-Car M2 > - reg : address and length of the SATA registers; > - interrupts : must consist of one interrupt specifier. > +- clocks : must contain a phandle and clock-specifier pair. I would say "must contain a reference to the functional clock.", as the clock could be referenced by a phandle only depending on the SATA IP core integration in the SoC. Wouldn't it be time to have standard wordings for clocks (and interrupt) bindings ? > Example: > > -sata: sata@fc600000 { > - compatible = "renesas,sata-r8a7779"; > - reg = <0xfc600000 0x2000>; > +sata0: sata@ee300000 { > + compatible = "renesas,sata-r8a7791"; > + reg = <0 0xee300000 0 0x2000>; > interrupt-parent = <&gic>; > - interrupts = <0 100 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0 105 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&mstp8_clks R8A7791_CLK_SATA0>; > }; -- Regards, Laurent Pinchart