devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Caleb Connolly <caleb.connolly@linaro.org>
To: Conor Dooley <conor@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH 1/6] dt-bindings: mfd: qcom,spmi-pmic: Document pmi8998 charger
Date: Wed, 24 May 2023 20:53:27 +0100	[thread overview]
Message-ID: <221cbac5-c882-0f5f-0b5b-d1fc9cadc2d7@linaro.org> (raw)
In-Reply-To: <20230524-cache-gonad-fde614bbea50@spud>



On 24/05/2023 20:02, Conor Dooley wrote:
> Hey Caleb,
> 
> On Wed, May 24, 2023 at 06:38:52PM +0100, Caleb Connolly wrote:
>> Document the new pmi8998 charger bindings
> 
> This commit message looks a bit odd compared to the contents of the
> diff. Did you forget to git add something?

Well, it's not my finest commit message... The binding is in the series
linked in the cover letter (or [1]), I missed this addition when sending
that.

Would it be better to just squash this patch into the bindings and
respin the other series?

[1]:
https://lore.kernel.org/linux-arm-msm/20230524-pmi8998-charger-v8-0-b87ffcd9864d@linaro.org/
> 
> Cheers,
> Conor.
> 
>>
>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> index 36de335a33aa..44590dc112be 100644
>> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
>> @@ -133,6 +133,7 @@ patternProperties:
>>      oneOf:
>>        - $ref: /schemas/power/supply/qcom,pm8941-charger.yaml#
>>        - $ref: /schemas/power/supply/qcom,pm8941-coincell.yaml#
>> +      - $ref: /schemas/power/supply/qcom,pmi8998-charger.yaml#
>>  
>>    "gpio@[0-9a-f]+$":
>>      type: object
>>
>> -- 
>> 2.40.1
>>

-- 
// Caleb (they/them)

  reply	other threads:[~2023-05-24 19:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 17:38 [PATCH 0/6] Enable PMI8998 charger on supported devices Caleb Connolly
2023-05-24 17:38 ` [PATCH 1/6] dt-bindings: mfd: qcom,spmi-pmic: Document pmi8998 charger Caleb Connolly
2023-05-24 18:24   ` Rob Herring
2023-05-24 19:02   ` Conor Dooley
2023-05-24 19:53     ` Caleb Connolly [this message]
2023-05-24 20:08       ` Conor Dooley
2023-05-24 17:38 ` [PATCH 2/6] arm64: dts: qcom: pmi8998: enable rradc by default Caleb Connolly
2023-05-26 19:46   ` Konrad Dybcio
2023-05-24 17:38 ` [PATCH 3/6] arm64: dts: qcom: pmi8998: add charger node Caleb Connolly
2023-05-26 19:46   ` Konrad Dybcio
2023-05-26 21:39     ` Caleb Connolly
2023-05-26 21:41       ` Konrad Dybcio
2023-05-24 17:38 ` [PATCH 4/6] arm64: dts: qcom: sdm845-oneplus: enable pmi8998 charger Caleb Connolly
2023-05-24 17:38 ` [PATCH 5/6] arm64: dts: qcom: sdm845-shift-axolotl: " Caleb Connolly
2023-05-26 19:47   ` Konrad Dybcio
2023-05-24 17:38 ` [PATCH 6/6] arm64: dts: qcom: sdm845-xiaomi-beryllium: " Caleb Connolly
2023-05-26 19:47   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=221cbac5-c882-0f5f-0b5b-d1fc9cadc2d7@linaro.org \
    --to=caleb.connolly@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).