[PATCH 1/2] of: add bq and radxa vendor prefixes

[PATCH 1/2] of: add bq and radxa vendor prefixes

[Beniamino Galvani]

Add new vendor prefixes for:

    * bq, a company that sells multimedia devices and 3D printers
    * Radxa, manufacturer of ARM boards

Signed-off-by: Beniamino Galvani <b.galvani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 Documentation/devicetree/bindings/vendor-prefixes.txt |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index abc3080..6f8177c 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -21,6 +21,7 @@ atmel	Atmel Corporation
 auo	AU Optronics Corporation
 avago	Avago Technologies
 bosch	Bosch Sensortec GmbH
+bq	bq
 brcm	Broadcom Corporation
 buffalo	Buffalo, Inc.
 calxeda	Calxeda
@@ -98,6 +99,7 @@ powervr	PowerVR (deprecated, use img)
 qca	Qualcomm Atheros, Inc.
 qcom	Qualcomm Technologies, Inc
 qnap	QNAP Systems, Inc.
+radxa	Radxa
 raidsonic	RaidSonic Technology GmbH
 ralink	Mediatek/Ralink Technology Corp.
 ramtron	Ramtron International
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: dts: rockchip: add root compatible properties

[Beniamino Galvani]

Add the missing 'compatible' property to device tree root node of

 - rk3066a-bqcurie2.dts
 - rk3188-radxarock.dts

and document the new values.

Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
---
 Documentation/devicetree/bindings/arm/rockchip.txt |   10 ++++++++++
 arch/arm/boot/dts/rk3066a-bqcurie2.dts             |    1 +
 arch/arm/boot/dts/rk3188-radxarock.dts             |    1 +
 3 files changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/rockchip.txt

diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
new file mode 100644
index 0000000..12b84e7
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/rockchip.txt
@@ -0,0 +1,10 @@
+Rockchip platforms device tree bindings
+---------------------------------------
+
+- bq Curie 2 tablet:
+    Required root node properties:
+      - compatible = "bq,curie2", "rockchip,rk3066a";
+
+- Radxa Rock board:
+    Required root node properties:
+      - compatible = "radxa,rock", "rockchip,rk3188";
diff --git a/arch/arm/boot/dts/rk3066a-bqcurie2.dts b/arch/arm/boot/dts/rk3066a-bqcurie2.dts
index 035df40..7616bd9 100644
--- a/arch/arm/boot/dts/rk3066a-bqcurie2.dts
+++ b/arch/arm/boot/dts/rk3066a-bqcurie2.dts
@@ -18,6 +18,7 @@
 
 / {
 	model = "bq Curie 2";
+	compatible = "bq,curie2", "rockchip,rk3066a";
 
 	memory {
 		reg = <0x60000000 0x40000000>;
diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts
index 3ba1968..a5eee55 100644
--- a/arch/arm/boot/dts/rk3188-radxarock.dts
+++ b/arch/arm/boot/dts/rk3188-radxarock.dts
@@ -17,6 +17,7 @@
 
 / {
 	model = "Radxa Rock";
+	compatible = "radxa,rock", "rockchip,rk3188";
 
 	memory {
 		reg = <0x60000000 0x80000000>;
-- 
1.7.10.4

Re: [PATCH 1/2] of: add bq and radxa vendor prefixes

[Heiko Stübner]

Hi Beniamino,

Am Donnerstag, 1. Mai 2014, 21:50:34 schrieb Beniamino Galvani:
> Add new vendor prefixes for:
> 
>     * bq, a company that sells multimedia devices and 3D printers

bq is actually only a brandname. The company itself is "Mundo Reader S.L.".
I'm not sure what the actual policy is concerning the vendor prefix, i.e. if it 
should use the visible brand name or the actual company name.

I.e. another possibility would be to add the vendor prefix
	mundoreader	Mundo Reader S.L.
and name the currie
	mundoreader,bq-curie2


Heiko

>     * Radxa, manufacturer of ARM boards
> 
> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> ---
>  Documentation/devicetree/bindings/vendor-prefixes.txt |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> b/Documentation/devicetree/bindings/vendor-prefixes.txt index
> abc3080..6f8177c 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -21,6 +21,7 @@ atmel	Atmel Corporation
>  auo	AU Optronics Corporation
>  avago	Avago Technologies
>  bosch	Bosch Sensortec GmbH
> +bq	bq
>  brcm	Broadcom Corporation
>  buffalo	Buffalo, Inc.
>  calxeda	Calxeda
> @@ -98,6 +99,7 @@ powervr	PowerVR (deprecated, use img)
>  qca	Qualcomm Atheros, Inc.
>  qcom	Qualcomm Technologies, Inc
>  qnap	QNAP Systems, Inc.
> +radxa	Radxa
>  raidsonic	RaidSonic Technology GmbH
>  ralink	Mediatek/Ralink Technology Corp.
>  ramtron	Ramtron International

Re: [PATCH 1/2] of: add bq and radxa vendor prefixes

[Matthias Brugger]

2014-05-02 1:32 GMT+02:00 Heiko Stübner <heiko@sntech.de>:
> Hi Beniamino,
>
> Am Donnerstag, 1. Mai 2014, 21:50:34 schrieb Beniamino Galvani:
>> Add new vendor prefixes for:
>>
>>     * bq, a company that sells multimedia devices and 3D printers
>
> bq is actually only a brandname. The company itself is "Mundo Reader S.L.".
> I'm not sure what the actual policy is concerning the vendor prefix, i.e. if it
> should use the visible brand name or the actual company name.
>
> I.e. another possibility would be to add the vendor prefix
>         mundoreader     Mundo Reader S.L.
> and name the currie
>         mundoreader,bq-curie2

I think we should stick to the brand name, as this is the name people know.

>
>
> Heiko
>
>>     * Radxa, manufacturer of ARM boards
>>
>> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/vendor-prefixes.txt |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> b/Documentation/devicetree/bindings/vendor-prefixes.txt index
>> abc3080..6f8177c 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
>> @@ -21,6 +21,7 @@ atmel       Atmel Corporation
>>  auo  AU Optronics Corporation
>>  avago        Avago Technologies
>>  bosch        Bosch Sensortec GmbH
>> +bq   bq
>>  brcm Broadcom Corporation
>>  buffalo      Buffalo, Inc.
>>  calxeda      Calxeda
>> @@ -98,6 +99,7 @@ powervr     PowerVR (deprecated, use img)
>>  qca  Qualcomm Atheros, Inc.
>>  qcom Qualcomm Technologies, Inc
>>  qnap QNAP Systems, Inc.
>> +radxa        Radxa
>>  raidsonic    RaidSonic Technology GmbH
>>  ralink       Mediatek/Ralink Technology Corp.
>>  ramtron      Ramtron International
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
motzblog.wordpress.com

Re: [PATCH 1/2] of: add bq and radxa vendor prefixes

[Beniamino Galvani]

On Fri, May 02, 2014 at 01:32:37AM +0200, Heiko Stübner wrote:
> Hi Beniamino,
> 
> Am Donnerstag, 1. Mai 2014, 21:50:34 schrieb Beniamino Galvani:
> > Add new vendor prefixes for:
> > 
> >     * bq, a company that sells multimedia devices and 3D printers
> 
> bq is actually only a brandname. The company itself is "Mundo Reader S.L.".
> I'm not sure what the actual policy is concerning the vendor prefix, i.e. if it 
> should use the visible brand name or the actual company name.
> 
> I.e. another possibility would be to add the vendor prefix
> 	mundoreader	Mundo Reader S.L.
> and name the currie
> 	mundoreader,bq-curie2

I've added DT bindings maintainers in CC as I should have done from
the beginning, hoping that someone can clarify this.

My opinion is that the brand name is not relevant since the prefix
represents the company which designs and manufactures the device; so
in this case I agree with your proposal to use mundoreader instead of
bq.

Beniamino

> 
> >     * Radxa, manufacturer of ARM boards
> > 
> > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.txt |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > b/Documentation/devicetree/bindings/vendor-prefixes.txt index
> > abc3080..6f8177c 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > @@ -21,6 +21,7 @@ atmel	Atmel Corporation
> >  auo	AU Optronics Corporation
> >  avago	Avago Technologies
> >  bosch	Bosch Sensortec GmbH
> > +bq	bq
> >  brcm	Broadcom Corporation
> >  buffalo	Buffalo, Inc.
> >  calxeda	Calxeda
> > @@ -98,6 +99,7 @@ powervr	PowerVR (deprecated, use img)
> >  qca	Qualcomm Atheros, Inc.
> >  qcom	Qualcomm Technologies, Inc
> >  qnap	QNAP Systems, Inc.
> > +radxa	Radxa
> >  raidsonic	RaidSonic Technology GmbH
> >  ralink	Mediatek/Ralink Technology Corp.
> >  ramtron	Ramtron International
> 

Re: [PATCH 1/2] of: add bq and radxa vendor prefixes

[Beniamino Galvani]

On Sun, May 04, 2014 at 02:57:52PM +0200, Matthias Brugger wrote:
> 2014-05-02 1:32 GMT+02:00 Heiko Stübner <heiko@sntech.de>:
> > Hi Beniamino,
> >
> > Am Donnerstag, 1. Mai 2014, 21:50:34 schrieb Beniamino Galvani:
> >> Add new vendor prefixes for:
> >>
> >>     * bq, a company that sells multimedia devices and 3D printers
> >
> > bq is actually only a brandname. The company itself is "Mundo Reader S.L.".
> > I'm not sure what the actual policy is concerning the vendor prefix, i.e. if it
> > should use the visible brand name or the actual company name.
> >
> > I.e. another possibility would be to add the vendor prefix
> >         mundoreader     Mundo Reader S.L.
> > and name the currie
> >         mundoreader,bq-curie2
> 
> I think we should stick to the brand name, as this is the name people know.

Personally I don't have a strong preference, so either of the two.

Beniamino

> 
> >
> >
> > Heiko
> >
> >>     * Radxa, manufacturer of ARM boards
> >>
> >> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> >> ---
> >>  Documentation/devicetree/bindings/vendor-prefixes.txt |    2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> >> b/Documentation/devicetree/bindings/vendor-prefixes.txt index
> >> abc3080..6f8177c 100644
> >> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> >> @@ -21,6 +21,7 @@ atmel       Atmel Corporation
> >>  auo  AU Optronics Corporation
> >>  avago        Avago Technologies
> >>  bosch        Bosch Sensortec GmbH
> >> +bq   bq
> >>  brcm Broadcom Corporation
> >>  buffalo      Buffalo, Inc.
> >>  calxeda      Calxeda
> >> @@ -98,6 +99,7 @@ powervr     PowerVR (deprecated, use img)
> >>  qca  Qualcomm Atheros, Inc.
> >>  qcom Qualcomm Technologies, Inc
> >>  qnap QNAP Systems, Inc.
> >> +radxa        Radxa
> >>  raidsonic    RaidSonic Technology GmbH
> >>  ralink       Mediatek/Ralink Technology Corp.
> >>  ramtron      Ramtron International
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 
> 
> 
> -- 
> motzblog.wordpress.com

Re: [PATCH 1/2] of: add bq and radxa vendor prefixes

[Heiko Stübner]

Am Dienstag, 6. Mai 2014, 13:13:46 schrieb Beniamino Galvani:
> On Sun, May 04, 2014 at 02:57:52PM +0200, Matthias Brugger wrote:
> > 2014-05-02 1:32 GMT+02:00 Heiko Stübner <heiko@sntech.de>:
> > > Hi Beniamino,
> > > 
> > > Am Donnerstag, 1. Mai 2014, 21:50:34 schrieb Beniamino Galvani:
> > >> Add new vendor prefixes for:
> > >>     * bq, a company that sells multimedia devices and 3D printers
> > > 
> > > bq is actually only a brandname. The company itself is "Mundo Reader
> > > S.L.".
> > > I'm not sure what the actual policy is concerning the vendor prefix,
> > > i.e. if it should use the visible brand name or the actual company
> > > name.
> > > 
> > > I.e. another possibility would be to add the vendor prefix
> > > 
> > >         mundoreader     Mundo Reader S.L.
> > > 
> > > and name the currie
> > > 
> > >         mundoreader,bq-curie2
> > 
> > I think we should stick to the brand name, as this is the name people
> > know.
> 
> Personally I don't have a strong preference, so either of the two.

According to an IRC conversation I just had, it is supposed to be the real 
company name ... so I guess my option above would be the correct one.


Heiko

> 
> Beniamino
> 
> > > Heiko
> > > 
> > >>     * Radxa, manufacturer of ARM boards
> > >> 
> > >> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> > >> ---
> > >> 
> > >>  Documentation/devicetree/bindings/vendor-prefixes.txt |    2 ++
> > >>  1 file changed, 2 insertions(+)
> > >> 
> > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > >> b/Documentation/devicetree/bindings/vendor-prefixes.txt index
> > >> abc3080..6f8177c 100644
> > >> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > >> @@ -21,6 +21,7 @@ atmel       Atmel Corporation
> > >> 
> > >>  auo  AU Optronics Corporation
> > >>  avago        Avago Technologies
> > >>  bosch        Bosch Sensortec GmbH
> > >> 
> > >> +bq   bq
> > >> 
> > >>  brcm Broadcom Corporation
> > >>  buffalo      Buffalo, Inc.
> > >>  calxeda      Calxeda
> > >> 
> > >> @@ -98,6 +99,7 @@ powervr     PowerVR (deprecated, use img)
> > >> 
> > >>  qca  Qualcomm Atheros, Inc.
> > >>  qcom Qualcomm Technologies, Inc
> > >>  qnap QNAP Systems, Inc.
> > >> 
> > >> +radxa        Radxa
> > >> 
> > >>  raidsonic    RaidSonic Technology GmbH
> > >>  ralink       Mediatek/Ralink Technology Corp.
> > >>  ramtron      Ramtron International
> > > 
> > > _______________________________________________
> > > linux-arm-kernel mailing list
> > > linux-arm-kernel@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH 1/2] of: add bq and radxa vendor prefixes

[Beniamino Galvani]

On Tue, May 06, 2014 at 01:31:24PM +0200, Heiko Stübner wrote:
> Am Dienstag, 6. Mai 2014, 13:13:46 schrieb Beniamino Galvani:
> > On Sun, May 04, 2014 at 02:57:52PM +0200, Matthias Brugger wrote:
> > > 2014-05-02 1:32 GMT+02:00 Heiko Stübner <heiko@sntech.de>:
> > > > Hi Beniamino,
> > > > 
> > > > Am Donnerstag, 1. Mai 2014, 21:50:34 schrieb Beniamino Galvani:
> > > >> Add new vendor prefixes for:
> > > >>     * bq, a company that sells multimedia devices and 3D printers
> > > > 
> > > > bq is actually only a brandname. The company itself is "Mundo Reader
> > > > S.L.".
> > > > I'm not sure what the actual policy is concerning the vendor prefix,
> > > > i.e. if it should use the visible brand name or the actual company
> > > > name.
> > > > 
> > > > I.e. another possibility would be to add the vendor prefix
> > > > 
> > > >         mundoreader     Mundo Reader S.L.
> > > > 
> > > > and name the currie
> > > > 
> > > >         mundoreader,bq-curie2
> > > 
> > > I think we should stick to the brand name, as this is the name people
> > > know.
> > 
> > Personally I don't have a strong preference, so either of the two.
> 
> According to an IRC conversation I just had, it is supposed to be the real 
> company name ... so I guess my option above would be the correct one.

Thanks, I updated the patches.

Beniamino

> > > > 
> > > >>     * Radxa, manufacturer of ARM boards
> > > >> 
> > > >> Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
> > > >> ---
> > > >> 
> > > >>  Documentation/devicetree/bindings/vendor-prefixes.txt |    2 ++
> > > >>  1 file changed, 2 insertions(+)
> > > >> 
> > > >> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > >> b/Documentation/devicetree/bindings/vendor-prefixes.txt index
> > > >> abc3080..6f8177c 100644
> > > >> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > >> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> > > >> @@ -21,6 +21,7 @@ atmel       Atmel Corporation
> > > >> 
> > > >>  auo  AU Optronics Corporation
> > > >>  avago        Avago Technologies
> > > >>  bosch        Bosch Sensortec GmbH
> > > >> 
> > > >> +bq   bq
> > > >> 
> > > >>  brcm Broadcom Corporation
> > > >>  buffalo      Buffalo, Inc.
> > > >>  calxeda      Calxeda
> > > >> 
> > > >> @@ -98,6 +99,7 @@ powervr     PowerVR (deprecated, use img)
> > > >> 
> > > >>  qca  Qualcomm Atheros, Inc.
> > > >>  qcom Qualcomm Technologies, Inc
> > > >>  qnap QNAP Systems, Inc.
> > > >> 
> > > >> +radxa        Radxa
> > > >> 
> > > >>  raidsonic    RaidSonic Technology GmbH
> > > >>  ralink       Mediatek/Ralink Technology Corp.
> > > >>  ramtron      Ramtron International
> > > > 
> > > > _______________________________________________
> > > > linux-arm-kernel mailing list
> > > > linux-arm-kernel@lists.infradead.org
> > > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>