Re: [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi

["Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>]

Am Dienstag, 12. März 2019, 21:41:24 CET schrieb David Summers:
> On 11/03/2019 22:18, Robin Murphy wrote:
> > On 2019-03-09 3:39 pm, David Summers wrote:
> >> Signed-off-by: David Summers <beagleboard-8lkWs+DogrrqRUWtDFdff/XRex20P6io@public.gmane.org>
> >> Signed-off-by: Stefan Wahren <stefan.wahren-eS4NqCHxEME@public.gmane.org>
> >> Tested-by: Tony McKahan <tonymckahan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >> Reviewed-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> > 
> > Erm, I don't think I did... :(
> > 
> > Please see section 13 of Documentation/process/submitting-patches.rst
> > for what that tag means.
> > 
> > FWIW this is the kind of patch I might have considered formally
> > reviewing if I had enough first-hand experience of the Tinker Board or
> > Realtek SDIO modules to judge correctness, but sadly I have zero of
> > either.
> > 
> > Robin.
> > 
> >> Test-by: TheSaint @ ArchLinux ARM
> 
> Apols Robin. I read to much into your understanding of the comments that
> were talked to be added....
> 
> Yes Stefan but at least as much, maybe more work into this patch than I
> did. He was the man that made it close to what we could mainline. I only
> added very little, but then again I was also the one pushing for mainlining.
> 
> So if only one sign off - Probably Stefan did most.

Nope, that was the reason for my Co-developed-by question.
If you look into the submitting patches document there is a special tag
Co-Developed-by to give credit to the author that is not the "patch-from".

And in this case all authors also get a signed-off-by line.

> 
> Heiko: Same question as before do you want me to resend which cleared up
> signoff? Just send me an email - and I'll do whatever is best for you.

As in the other mail, resending for things like that is not necessary in my
case. I just need to hunt down the relevant information as you can see :-D

Heiko