From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v3 2/3] arm: dts: rk3288-tinker.dtsi: Enable WiFi Date: Tue, 12 Mar 2019 21:55:08 +0100 Message-ID: <2230941.OycJZGmSUK@diego> References: <20190217121513.22965-1-beagleboard@davidjohnsummers.uk> <383c9884-4885-34e1-9ef7-96e936bb211d@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: David Summers Cc: Stefan Wahren , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Robin Murphy , linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Tony McKahan , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Am Dienstag, 12. M=E4rz 2019, 21:41:24 CET schrieb David Summers: > On 11/03/2019 22:18, Robin Murphy wrote: > > On 2019-03-09 3:39 pm, David Summers wrote: > >> Signed-off-by: David Summers > >> Signed-off-by: Stefan Wahren > >> Tested-by: Tony McKahan > >> Reviewed-by: Robin Murphy > > = > > Erm, I don't think I did... :( > > = > > Please see section 13 of Documentation/process/submitting-patches.rst > > for what that tag means. > > = > > FWIW this is the kind of patch I might have considered formally > > reviewing if I had enough first-hand experience of the Tinker Board or > > Realtek SDIO modules to judge correctness, but sadly I have zero of > > either. > > = > > Robin. > > = > >> Test-by: TheSaint @ ArchLinux ARM > = > Apols Robin. I read to much into your understanding of the comments that > were talked to be added.... > = > Yes Stefan but at least as much, maybe more work into this patch than I > did. He was the man that made it close to what we could mainline. I only > added very little, but then again I was also the one pushing for mainlini= ng. > = > So if only one sign off - Probably Stefan did most. Nope, that was the reason for my Co-developed-by question. If you look into the submitting patches document there is a special tag Co-Developed-by to give credit to the author that is not the "patch-from". And in this case all authors also get a signed-off-by line. > = > Heiko: Same question as before do you want me to resend which cleared up > signoff? Just send me an email - and I'll do whatever is best for you. As in the other mail, resending for things like that is not necessary in my case. I just need to hunt down the relevant information as you can see :-D Heiko