From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F89CC433EF for ; Tue, 3 May 2022 23:30:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244261AbiECXd7 (ORCPT ); Tue, 3 May 2022 19:33:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244299AbiECXdp (ORCPT ); Tue, 3 May 2022 19:33:45 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CE6442EF9; Tue, 3 May 2022 16:30:08 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nm1xv-0004a6-LY; Wed, 04 May 2022 01:29:59 +0200 From: Heiko Stuebner To: krzk+dt@kernel.org, palmer@dabbelt.com, robh+dt@kernel.org, linux-riscv@lists.infradead.org Cc: conor.dooley@microchip.com, Cyril.Jean@microchip.com, daire.mcnamara@microchip.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, palmer@rivosinc.com, arnd@arndb.de, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Conor Dooley Subject: Re: [PATCH v3 1/8] riscv: dts: microchip: remove icicle memory clocks Date: Wed, 04 May 2022 01:29:57 +0200 Message-ID: <2237223.ElGaqSPkdT@phil> In-Reply-To: <20220501192557.2631936-2-mail@conchuod.ie> References: <20220501192557.2631936-1-mail@conchuod.ie> <20220501192557.2631936-2-mail@conchuod.ie> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Sonntag, 1. Mai 2022, 21:25:52 CEST schrieb Conor Dooley: > From: Conor Dooley > > The clock properties in the icicle kit's memory entries cause dtbs_check > errors: > arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dtb: /: memory@80000000: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+' > > Get rid of the clocks to avoid the errors. > > Reported-by: Palmer Dabbelt > Fixes: 0fa6107eca41 ("RISC-V: Initial DTS for Microchip ICICLE board") > Fixes: 5b28df37d311 ("riscv: dts: microchip: update peripherals in icicle kit device tree") > Signed-off-by: Conor Dooley Reviewed-by: Heiko Stuebner I guess the memory controller consuming this clock will be sitting somewhere in the io-area of the soc instead > --- > arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts > index 3392153dd0f1..c71d6aa6137a 100644 > --- a/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts > +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts > @@ -32,14 +32,12 @@ cpus { > ddrc_cache_lo: memory@80000000 { > device_type = "memory"; > reg = <0x0 0x80000000 0x0 0x2e000000>; > - clocks = <&clkcfg CLK_DDRC>; > status = "okay"; > }; > > ddrc_cache_hi: memory@1000000000 { > device_type = "memory"; > reg = <0x10 0x0 0x0 0x40000000>; > - clocks = <&clkcfg CLK_DDRC>; > status = "okay"; > }; > }; >