From: Krzysztof Kozlowski <krzk@kernel.org>
To: Harry Austen <hpausten@protonmail.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] dt-bindings: clock: xilinx: add description of user monitor interrupt
Date: Sat, 14 Feb 2026 21:59:30 +0100 [thread overview]
Message-ID: <223c900f-e509-4c22-a3ea-3e2051ca6975@kernel.org> (raw)
In-Reply-To: <NptKiK70heOFOIj9x6tz-gtS1m7ueBoa3SNCijidv1yeFPpt9OAPd-LTgBUbrEfAA2u3DTJHzlUDjv17fuddIPZ4m2YEZ1dTaMQuiXDGkD0=@protonmail.com>
On 14/02/2026 21:57, Harry Austen wrote:
>>>
>>> + interrupts:
>>> + items:
>>> + - description: user clock monitor interrupt
>>> +
>>> + interrupt-names:
>>> + items:
>>> + - const: monitor
>>> +
>>> xlnx,static-config:
>>> $ref: /schemas/types.yaml#/definitions/flag
>>> description:
>>> @@ -66,12 +74,24 @@ required:
>>> - xlnx,speed-grade
>>> - xlnx,nr-outputs
>>>
>>> +if:
>>
>> Why isn't this in allOf? Code is fine, but why changing it?
>
> There is only a single if condition, so the allOf is not required. Removed
> for simplicity and reduced indentation.
>
Heh, you might need to add it soon re-indenting everything on adding
just one more if, so for me that was wrong choice. And you got a review :/
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-14 20:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 18:10 [PATCH v4 0/2] clk: clocking-wizard: add user clock monitor support Harry Austen
2026-02-14 18:10 ` [PATCH v4 1/2] dt-bindings: clock: xilinx: add description of user monitor interrupt Harry Austen
2026-02-14 20:39 ` Krzysztof Kozlowski
2026-02-14 20:57 ` Harry Austen
2026-02-14 20:59 ` Krzysztof Kozlowski [this message]
2026-02-14 21:09 ` Harry Austen
2026-02-15 8:45 ` Krzysztof Kozlowski
2026-02-14 18:10 ` [PATCH v4 2/2] clk: clocking-wizard: add user clock monitor support Harry Austen
2026-02-19 6:52 ` Dan Carpenter
2026-02-20 14:33 ` Harry Austen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=223c900f-e509-4c22-a3ea-3e2051ca6975@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hpausten@protonmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox