* Re: [PATCH] ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup [not found] <1377020136-14838-1-git-send-email-t.figa@samsung.com> @ 2013-08-26 17:13 ` Tomasz Figa 2013-09-25 14:10 ` [PATCH RESEND REGRESSION] " Tomasz Figa 0 siblings, 1 reply; 2+ messages in thread From: Tomasz Figa @ 2013-08-26 17:13 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-arm-kernel, devicetree, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Ian Campbell, Kumar Gala, Kyungmin Park On Tuesday 20 of August 2013 19:35:36 Tomasz Figa wrote: > Exynos cpufreq drivers does not support device tree based regulator > lookup, so it can get the VDD ARM regulator only by its name. To get > cpufreq working for now, this patch works this around by renaming the > regulator in board dts files to vdd_arm, which is the name expected by > the driver. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/boot/dts/exynos4210-origen.dts | 7 ++++++- > arch/arm/boot/dts/exynos4210-trats.dts | 7 ++++++- > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4210-origen.dts > b/arch/arm/boot/dts/exynos4210-origen.dts index 382d8c7..46378fe 100644 > --- a/arch/arm/boot/dts/exynos4210-origen.dts > +++ b/arch/arm/boot/dts/exynos4210-origen.dts > @@ -192,7 +192,12 @@ > }; > > buck1_reg: BUCK1 { > - regulator-name = "VDD_ARM_1.2V"; > + /* > + * HACK: The real name is VDD_ARM_1.2V, > + * but exynos-cpufreq does not support > + * DT-based regulator lookup yet. > + */ > + regulator-name = "vdd_arm"; > regulator-min-microvolt = <950000>; > regulator-max-microvolt = <1350000>; > regulator-always-on; > diff --git a/arch/arm/boot/dts/exynos4210-trats.dts > b/arch/arm/boot/dts/exynos4210-trats.dts index 1c164f2..63cc571 100644 > --- a/arch/arm/boot/dts/exynos4210-trats.dts > +++ b/arch/arm/boot/dts/exynos4210-trats.dts > @@ -290,7 +290,12 @@ > }; > > varm_breg: BUCK1 { > - regulator-name = "VARM_1.2V_C210"; > + /* > + * HACK: The real name is VARM_1.2V_C210, > + * but exynos-cpufreq does not support > + * DT-based regulator lookup yet. > + */ > + regulator-name = "vdd_arm"; > regulator-min-microvolt = <900000>; > regulator-max-microvolt = <1350000>; > regulator-always-on; Ping. This patch fixes broken cpufreq on above two boards, so it would be nice to have it merged for 3.12, even if it's a bit hacky, since it's too late for proper solution at the moment. (It's already in development, though.) Best regards, Tomasz ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH RESEND REGRESSION] ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup 2013-08-26 17:13 ` [PATCH] ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup Tomasz Figa @ 2013-09-25 14:10 ` Tomasz Figa 0 siblings, 0 replies; 2+ messages in thread From: Tomasz Figa @ 2013-09-25 14:10 UTC (permalink / raw) To: linux-samsung-soc Cc: linux-arm-kernel, devicetree, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren, Ian Campbell, Kumar Gala, Kyungmin Park, Lukasz Majewski Exynos cpufreq drivers does not support device tree based regulator lookup, so it can get the VDD ARM regulator only by its name. To get cpufreq working for now, this patch works this around by renaming the regulator in board dts files to vdd_arm, which is the name expected by the driver. This fixes a regression introduced by dropping support of board file based bootup of Exynos 4210 boards that rendered cpufreq inoperable on Trats and Origen boards. Signed-off-by: Tomasz Figa <t.figa@samsung.com> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> --- arch/arm/boot/dts/exynos4210-origen.dts | 7 ++++++- arch/arm/boot/dts/exynos4210-trats.dts | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) Resending again, since my mail client previously freaked out and reset message format to HTML... diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts index 382d8c7..46378fe 100644 --- a/arch/arm/boot/dts/exynos4210-origen.dts +++ b/arch/arm/boot/dts/exynos4210-origen.dts @@ -192,7 +192,12 @@ }; buck1_reg: BUCK1 { - regulator-name = "VDD_ARM_1.2V"; + /* + * HACK: The real name is VDD_ARM_1.2V, + * but exynos-cpufreq does not support + * DT-based regulator lookup yet. + */ + regulator-name = "vdd_arm"; regulator-min-microvolt = <950000>; regulator-max-microvolt = <1350000>; regulator-always-on; diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts index 1c164f2..63cc571 100644 --- a/arch/arm/boot/dts/exynos4210-trats.dts +++ b/arch/arm/boot/dts/exynos4210-trats.dts @@ -290,7 +290,12 @@ }; varm_breg: BUCK1 { - regulator-name = "VARM_1.2V_C210"; + /* + * HACK: The real name is VARM_1.2V_C210, + * but exynos-cpufreq does not support + * DT-based regulator lookup yet. + */ + regulator-name = "vdd_arm"; regulator-min-microvolt = <900000>; regulator-max-microvolt = <1350000>; regulator-always-on; -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-25 14:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1377020136-14838-1-git-send-email-t.figa@samsung.com>
2013-08-26 17:13 ` [PATCH] ARM: dts: exynos4210: Work around lack of cpufreq regulator lookup Tomasz Figa
2013-09-25 14:10 ` [PATCH RESEND REGRESSION] " Tomasz Figa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).