* [PATCH 0/2] Document GPIO regulator regulator-type property and use it @ 2013-11-28 15:44 Laurent Pinchart 2013-11-28 15:44 ` [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property Laurent Pinchart 2013-11-28 15:44 ` [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT Laurent Pinchart 0 siblings, 2 replies; 12+ messages in thread From: Laurent Pinchart @ 2013-11-28 15:44 UTC (permalink / raw) To: linux-sh; +Cc: linux-arm-kernel, devicetree Hello, This patch set documents the required regulator-type property for the GPIO regulator DT bindings and uses it in the Renesas Armadillo DT. I've checked the DT files in mainline and all the GPIO regulator nodes but the one in r8a7740-armadillo800eva-reference.dts specify the regulator-type property. Laurent Pinchart (2): regulator: gpio-regulator: Add required regulator-type property ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 ++ 2 files changed, 4 insertions(+) -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property 2013-11-28 15:44 [PATCH 0/2] Document GPIO regulator regulator-type property and use it Laurent Pinchart @ 2013-11-28 15:44 ` Laurent Pinchart 2013-12-05 0:09 ` Mark Brown 2013-11-28 15:44 ` [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT Laurent Pinchart 1 sibling, 1 reply; 12+ messages in thread From: Laurent Pinchart @ 2013-11-28 15:44 UTC (permalink / raw) To: linux-sh; +Cc: linux-arm-kernel, devicetree The gpio-regulator driver requires the regulator-type property to be present. Document it as required in the DT bindings. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- Documentation/devicetree/bindings/regulator/gpio-regulator.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt index 63c6598..a560711 100644 --- a/Documentation/devicetree/bindings/regulator/gpio-regulator.txt +++ b/Documentation/devicetree/bindings/regulator/gpio-regulator.txt @@ -4,6 +4,7 @@ Required properties: - compatible : Must be "regulator-gpio". - states : Selection of available voltages and GPIO configs. if there are no states, then use a fixed regulator +- regulator-type : Must be either "voltage" or "current". Optional properties: - enable-gpio : GPIO to use to enable/disable the regulator. @@ -22,6 +23,7 @@ Example: regulator-name = "mmci-gpio-supply"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <2600000>; + regulator-type = "voltage"; regulator-boot-on; enable-gpio = <&gpio0 23 0x4>; -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property 2013-11-28 15:44 ` [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property Laurent Pinchart @ 2013-12-05 0:09 ` Mark Brown 2013-12-05 0:47 ` Laurent Pinchart 0 siblings, 1 reply; 12+ messages in thread From: Mark Brown @ 2013-12-05 0:09 UTC (permalink / raw) To: Laurent Pinchart; +Cc: linux-sh, devicetree, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 591 bytes --] On Thu, Nov 28, 2013 at 04:44:52PM +0100, Laurent Pinchart wrote: > The gpio-regulator driver requires the regulator-type property to be > present. Document it as required in the DT bindings. It does? That seems needless. It should just default to voltage and provide a way override to current, though frankly I'd be astonished to see a GPIO controlled current regulator at all so I'm not sure I'd even bother writing the code for that until someone needs it. As it is this will most likely just be noise in the DT files and wasted cycles parsing the property. Please CC maintainers... [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property 2013-12-05 0:09 ` Mark Brown @ 2013-12-05 0:47 ` Laurent Pinchart 2014-05-13 0:06 ` Laurent Pinchart 0 siblings, 1 reply; 12+ messages in thread From: Laurent Pinchart @ 2013-12-05 0:47 UTC (permalink / raw) To: Mark Brown, linux-sh; +Cc: devicetree, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 905 bytes --] Hi Mark, On Thursday 05 December 2013 00:09:28 Mark Brown wrote: > On Thu, Nov 28, 2013 at 04:44:52PM +0100, Laurent Pinchart wrote: > > The gpio-regulator driver requires the regulator-type property to be > > present. Document it as required in the DT bindings. > > It does? That seems needless. It should just default to voltage and > provide a way override to current, though frankly I'd be astonished to see a > GPIO controlled current regulator at all so I'm not sure I'd even bother > writing the code for that until someone needs it. As it is this will most > likely just be noise in the DT files and wasted cycles parsing the property. I'm fine with that. The property should still be documented in the DT bindings as optional though. Or be removed completely until a GPIO-controlled current regulator is needed. > Please CC maintainers... My bad, sorry. -- Regards, Laurent Pinchart [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property 2013-12-05 0:47 ` Laurent Pinchart @ 2014-05-13 0:06 ` Laurent Pinchart 2014-05-13 16:59 ` Mark Brown 0 siblings, 1 reply; 12+ messages in thread From: Laurent Pinchart @ 2014-05-13 0:06 UTC (permalink / raw) To: Mark Brown; +Cc: linux-sh, devicetree, linux-arm-kernel Hi Mark, On Thursday 05 December 2013 01:47:04 Laurent Pinchart wrote: > On Thursday 05 December 2013 00:09:28 Mark Brown wrote: > > On Thu, Nov 28, 2013 at 04:44:52PM +0100, Laurent Pinchart wrote: > > > The gpio-regulator driver requires the regulator-type property to be > > > present. Document it as required in the DT bindings. > > > > It does? That seems needless. It should just default to voltage and > > provide a way override to current, though frankly I'd be astonished to see > > a GPIO controlled current regulator at all so I'm not sure I'd even > > bother writing the code for that until someone needs it. As it is this > > will most likely just be noise in the DT files and wasted cycles parsing > > the property. > > I'm fine with that. The property should still be documented in the DT > bindings as optional though. Or be removed completely until a > GPIO-controlled current regulator is needed. What's the status of this ? The gpio regulator driver now defaults to voltage regulator when the regulator-type property is not set. Should the DT bindings document the property as optional (I can submit a patch for that), or do you consider that the gpio regulator driver should support voltage regulators only when used with DT, and just keep the regulator-type property support in the driver for backward compatibility ? > > Please CC maintainers... > > My bad, sorry. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property 2014-05-13 0:06 ` Laurent Pinchart @ 2014-05-13 16:59 ` Mark Brown 2014-05-21 13:44 ` Laurent Pinchart 0 siblings, 1 reply; 12+ messages in thread From: Mark Brown @ 2014-05-13 16:59 UTC (permalink / raw) To: Laurent Pinchart; +Cc: linux-sh, devicetree, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 690 bytes --] On Tue, May 13, 2014 at 02:06:23AM +0200, Laurent Pinchart wrote: > What's the status of this ? The gpio regulator driver now defaults to voltage > regulator when the regulator-type property is not set. Should the DT bindings > document the property as optional (I can submit a patch for that), or do you > consider that the gpio regulator driver should support voltage regulators only > when used with DT, and just keep the regulator-type property support in the > driver for backward compatibility ? I don't really care either way, I did write a patch for the bindings but there was some language lawyering over it and I never cared enough to get round to updating it. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property 2014-05-13 16:59 ` Mark Brown @ 2014-05-21 13:44 ` Laurent Pinchart 2014-05-21 14:22 ` Mark Brown 0 siblings, 1 reply; 12+ messages in thread From: Laurent Pinchart @ 2014-05-21 13:44 UTC (permalink / raw) To: Mark Brown; +Cc: linux-sh, devicetree, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 842 bytes --] On Tuesday 13 May 2014 17:59:21 Mark Brown wrote: > On Tue, May 13, 2014 at 02:06:23AM +0200, Laurent Pinchart wrote: > > What's the status of this ? The gpio regulator driver now defaults to > > voltage regulator when the regulator-type property is not set. Should the > > DT bindings document the property as optional (I can submit a patch for > > that), or do you consider that the gpio regulator driver should support > > voltage regulators only when used with DT, and just keep the > > regulator-type property support in the driver for backward compatibility > > ? > > I don't really care either way, I did write a patch for the bindings but > there was some language lawyering over it and I never cared enough to > get round to updating it. Could you please point me to the patch ? -- Regards, Laurent Pinchart [-- Attachment #2: This is a digitally signed message part. --] [-- Type: application/pgp-signature, Size: 490 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property 2014-05-21 13:44 ` Laurent Pinchart @ 2014-05-21 14:22 ` Mark Brown 0 siblings, 0 replies; 12+ messages in thread From: Mark Brown @ 2014-05-21 14:22 UTC (permalink / raw) To: Laurent Pinchart; +Cc: linux-sh, devicetree, linux-arm-kernel [-- Attachment #1: Type: text/plain, Size: 387 bytes --] On Wed, May 21, 2014 at 03:44:56PM +0200, Laurent Pinchart wrote: > On Tuesday 13 May 2014 17:59:21 Mark Brown wrote: > > I don't really care either way, I did write a patch for the bindings but > > there was some language lawyering over it and I never cared enough to > > get round to updating it. > Could you please point me to the patch ? I appear to have discarded it I'm afraid. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT 2013-11-28 15:44 [PATCH 0/2] Document GPIO regulator regulator-type property and use it Laurent Pinchart 2013-11-28 15:44 ` [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property Laurent Pinchart @ 2013-11-28 15:44 ` Laurent Pinchart 2013-12-05 3:45 ` Simon Horman 1 sibling, 1 reply; 12+ messages in thread From: Laurent Pinchart @ 2013-11-28 15:44 UTC (permalink / raw) To: linux-sh; +Cc: linux-arm-kernel, devicetree The mandatory regulator-type property is missing, add it. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts index 7b80f19..013a7cd 100644 --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts @@ -53,6 +53,8 @@ regulator-name = "SDHI0 VccQ"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; + regulator-type = "voltage"; + vin-supply = <&vcc_sdhi0>; enable-gpio = <&pfc 74 GPIO_ACTIVE_HIGH>; -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT 2013-11-28 15:44 ` [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT Laurent Pinchart @ 2013-12-05 3:45 ` Simon Horman 2013-12-05 5:56 ` Laurent Pinchart 0 siblings, 1 reply; 12+ messages in thread From: Simon Horman @ 2013-12-05 3:45 UTC (permalink / raw) To: Laurent Pinchart; +Cc: linux-sh, linux-arm-kernel, devicetree On Thu, Nov 28, 2013 at 04:44:53PM +0100, Laurent Pinchart wrote: > The mandatory regulator-type property is missing, add it. Thanks, I will queue this up. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > index 7b80f19..013a7cd 100644 > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > @@ -53,6 +53,8 @@ > regulator-name = "SDHI0 VccQ"; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > + regulator-type = "voltage"; > + > vin-supply = <&vcc_sdhi0>; > > enable-gpio = <&pfc 74 GPIO_ACTIVE_HIGH>; > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT 2013-12-05 3:45 ` Simon Horman @ 2013-12-05 5:56 ` Laurent Pinchart 2013-12-05 6:55 ` Simon Horman 0 siblings, 1 reply; 12+ messages in thread From: Laurent Pinchart @ 2013-12-05 5:56 UTC (permalink / raw) To: Simon Horman; +Cc: Laurent Pinchart, linux-sh, linux-arm-kernel, devicetree Hi Simon, On Thursday 05 December 2013 12:45:54 Simon Horman wrote: > On Thu, Nov 28, 2013 at 04:44:53PM +0100, Laurent Pinchart wrote: > > The mandatory regulator-type property is missing, add it. > > Thanks, I will queue this up. Mark has rightfully commented on patch 1/2 in this series that the regulator- type property shouldn't be mandatory but should default to voltage. We could then drop this patch. > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@ideasonboard.com> > > --- > > > > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts index > > 7b80f19..013a7cd 100644 > > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > @@ -53,6 +53,8 @@ > > > > regulator-name = "SDHI0 VccQ"; > > regulator-min-microvolt = <1800000>; > > regulator-max-microvolt = <3300000>; > > > > + regulator-type = "voltage"; > > + > > > > vin-supply = <&vcc_sdhi0>; > > > > enable-gpio = <&pfc 74 GPIO_ACTIVE_HIGH>; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT 2013-12-05 5:56 ` Laurent Pinchart @ 2013-12-05 6:55 ` Simon Horman 0 siblings, 0 replies; 12+ messages in thread From: Simon Horman @ 2013-12-05 6:55 UTC (permalink / raw) To: Laurent Pinchart; +Cc: Laurent Pinchart, linux-sh, linux-arm-kernel, devicetree On Thu, Dec 05, 2013 at 06:56:48AM +0100, Laurent Pinchart wrote: > Hi Simon, > > On Thursday 05 December 2013 12:45:54 Simon Horman wrote: > > On Thu, Nov 28, 2013 at 04:44:53PM +0100, Laurent Pinchart wrote: > > > The mandatory regulator-type property is missing, add it. > > > > Thanks, I will queue this up. > > Mark has rightfully commented on patch 1/2 in this series that the regulator- > type property shouldn't be mandatory but should default to voltage. We could > then drop this patch. I will drop it, thanks. > > > Signed-off-by: Laurent Pinchart > > > <laurent.pinchart+renesas@ideasonboard.com> > > > --- > > > > > > arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > > b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts index > > > 7b80f19..013a7cd 100644 > > > --- a/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > > +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts > > > @@ -53,6 +53,8 @@ > > > > > > regulator-name = "SDHI0 VccQ"; > > > regulator-min-microvolt = <1800000>; > > > regulator-max-microvolt = <3300000>; > > > > > > + regulator-type = "voltage"; > > > + > > > > > > vin-supply = <&vcc_sdhi0>; > > > > > > enable-gpio = <&pfc 74 GPIO_ACTIVE_HIGH>; > -- > Regards, > > Laurent Pinchart > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2014-05-21 14:22 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-11-28 15:44 [PATCH 0/2] Document GPIO regulator regulator-type property and use it Laurent Pinchart 2013-11-28 15:44 ` [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property Laurent Pinchart 2013-12-05 0:09 ` Mark Brown 2013-12-05 0:47 ` Laurent Pinchart 2014-05-13 0:06 ` Laurent Pinchart 2014-05-13 16:59 ` Mark Brown 2014-05-21 13:44 ` Laurent Pinchart 2014-05-21 14:22 ` Mark Brown 2013-11-28 15:44 ` [PATCH 2/2] ARM: shmobile: armadillo: Set vccq_sdhi0 regulator type in DT Laurent Pinchart 2013-12-05 3:45 ` Simon Horman 2013-12-05 5:56 ` Laurent Pinchart 2013-12-05 6:55 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).