From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Xu Yang <xu.yang_2@nxp.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
jun.li@nxp.com
Subject: Re: [PATCH v2 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible
Date: Tue, 13 Jun 2023 21:17:34 +0200 [thread overview]
Message-ID: <224e69e6-ac1e-70c3-c0b3-4b72cc3cb0ad@linaro.org> (raw)
In-Reply-To: <20230608033642.4097956-2-xu.yang_2@nxp.com>
On 08/06/2023 05:36, Xu Yang wrote:
> The imx8ulp and imx8qm are compatible with imx8dxl. This will add such
> compatible.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
>
> ---
> Changes in v2:
> - no change
> ---
> Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> index 1b6b19fdf491..1395a982c387 100644
> --- a/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/fsl,mxs-usbphy.yaml
> @@ -32,7 +32,10 @@ properties:
> - const: fsl,imx7ulp-usbphy
> - const: fsl,imx6ul-usbphy
> - items:
> - - const: fsl,imx8dxl-usbphy
> + - enum:
> + - fsl,imx8ulp-usbphy
> + - fsl,imx8dxl-usbphy
> + - fsl,imx8qm-usbphy
Keep the items sorted. Your previous patch also had wrongly ordered
imx6ul in enum.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-13 19:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 3:36 [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format Xu Yang
2023-06-08 3:36 ` [PATCH v2 2/2] dt-bindings: phy: mxs-usb-phy: add imx8ulp and imx8qm compatible Xu Yang
2023-06-13 19:17 ` Krzysztof Kozlowski [this message]
2023-06-14 2:13 ` [EXT] " Xu Yang
2023-06-08 4:26 ` [PATCH v2 1/2] dt-bindings: phy: mxs-usb-phy: convert to DT schema format Rob Herring
2023-06-08 7:56 ` Stefan Wahren
2023-06-08 10:30 ` [EXT] " Xu Yang
2023-06-08 11:38 ` Stefan Wahren
2023-06-09 9:23 ` Xu Yang
2023-06-09 16:43 ` Krzysztof Kozlowski
2023-06-13 7:30 ` [EXT] " Xu Yang
2023-06-13 7:39 ` Krzysztof Kozlowski
2023-06-13 7:41 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224e69e6-ac1e-70c3-c0b3-4b72cc3cb0ad@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).