Re: [PATCH v3 05/20] ASoC: dt-bindings: replace q6afe bindings with q6dsp-audio-ports

[Srinivas Kandagatla <srinivas.kandagatla@linaro.org>]

Thanks Mark for the review,

On 04/08/2021 18:53, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 01:53:56PM +0100, Srinivas Kandagatla wrote:
>> DSP Audio Ports bindings have been documented with DSP services bindings
>> which makes it difficult to reuse them, so pull them out in to a dedicated
>> bindings.
>> Also as part of this change convert them into yaml format.
> 
>> This patch also removes q6afe bindings as dsp services are now documented in
>> apr bindings.
> 
> This feels like it's multiple changes stuffed into one commit which
> makes it difficult to review, especially since I'm having a hard time
> connecting the code changes with the description.  For example this says
> it removes the "q6afe bindings" but we seem to be adding some in the
> newly added YAML file.  At the very least the commit message needs to be
> improved but I think this probably needs to be split out into separate
> changes each doing one thing.
This patch is doing yaml conversion + removing the "qcom,q6afe" 
compatible from the existing bindings + header file renaming.

I agree, will split the header file renaming and yaml conversions as two 
  patches, that should probably help. I will also update the commit 
message with more details.


--srini
>