* [PATCH 1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions
@ 2022-10-21 17:20 Sebastian Reichel
2022-10-21 19:11 ` Heiko Stübner
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sebastian Reichel @ 2022-10-21 17:20 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski
Cc: Heiko Stuebner, linux-gpio, linux-rockchip, devicetree,
Sebastian Reichel, kernel
Apparently RK3588 pinctrl has 13 different device functions, but dt-validate
only checks for pin configuration being referenced so I did not notice.
Fixes: ed1f77b78322 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions")
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
index b486f41df65f..d6539723f354 100644
--- a/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml
@@ -132,7 +132,7 @@ additionalProperties:
description:
Pin bank index.
- minimum: 0
- maximum: 10
+ maximum: 13
description:
Mux 0 means GPIO and mux 1 to N means
the specific device function.
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions
2022-10-21 17:20 [PATCH 1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions Sebastian Reichel
@ 2022-10-21 19:11 ` Heiko Stübner
2022-10-22 16:09 ` Krzysztof Kozlowski
2022-11-17 9:19 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2022-10-21 19:11 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski,
Sebastian Reichel
Cc: linux-gpio, linux-rockchip, devicetree, Sebastian Reichel, kernel
Am Freitag, 21. Oktober 2022, 19:20:12 CEST schrieb Sebastian Reichel:
> Apparently RK3588 pinctrl has 13 different device functions, but dt-validate
> only checks for pin configuration being referenced so I did not notice.
>
> Fixes: ed1f77b78322 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions")
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions
2022-10-21 17:20 [PATCH 1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions Sebastian Reichel
2022-10-21 19:11 ` Heiko Stübner
@ 2022-10-22 16:09 ` Krzysztof Kozlowski
2022-11-17 9:19 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-10-22 16:09 UTC (permalink / raw)
To: Sebastian Reichel, Linus Walleij, Rob Herring,
Krzysztof Kozlowski
Cc: Heiko Stuebner, linux-gpio, linux-rockchip, devicetree, kernel
On 21/10/2022 13:20, Sebastian Reichel wrote:
> Apparently RK3588 pinctrl has 13 different device functions, but dt-validate
> only checks for pin configuration being referenced so I did not notice.
I think the "but ..." part can be skipped, as it is not really relevant
to the issue being fixed here.
>
> Fixes: ed1f77b78322 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions")
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> Documentation/devicetree/bindings/pinctrl/rockchip,pinctrl.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions
2022-10-21 17:20 [PATCH 1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions Sebastian Reichel
2022-10-21 19:11 ` Heiko Stübner
2022-10-22 16:09 ` Krzysztof Kozlowski
@ 2022-11-17 9:19 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2022-11-17 9:19 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, linux-gpio,
linux-rockchip, devicetree, kernel
On Fri, Oct 21, 2022 at 7:20 PM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> Apparently RK3588 pinctrl has 13 different device functions, but dt-validate
> only checks for pin configuration being referenced so I did not notice.
>
> Fixes: ed1f77b78322 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions")
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-17 9:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-21 17:20 [PATCH 1/1] dt-bindings: pinctrl: rockchip: further increase max amount of device functions Sebastian Reichel
2022-10-21 19:11 ` Heiko Stübner
2022-10-22 16:09 ` Krzysztof Kozlowski
2022-11-17 9:19 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).