From: Arnd Bergmann <arnd@arndb.de>
To: Aleksey Makarov <aleksey.makarov@auriga.com>
Cc: linux-ide@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>,
Vinita Gupta <vgupta@caviumnetworks.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Tejun Heo <tj@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3] SATA: OCTEON: support SATA on OCTEON platform
Date: Sun, 08 Mar 2015 23:48:21 +0100 [thread overview]
Message-ID: <2264145.MknHxHLvY7@wuerfel> (raw)
In-Reply-To: <1425567540-31572-1-git-send-email-aleksey.makarov@auriga.com>
On Thursday 05 March 2015 17:58:58 Aleksey Makarov wrote:
> + ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64));
> + if (ret)
> + return ret;
>
Don't do this, instead you should set the dma-ranges of the parent
bus correctly so that dma_set_mask_and_coherent succeeds.
dma_coerce_mask_and_coherent() was introduced as a hack to
annotate broken drivers that were overriding the dma_mask pointer
themselves.
Arnd
prev parent reply other threads:[~2015-03-08 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 14:58 [PATCH v3] SATA: OCTEON: support SATA on OCTEON platform Aleksey Makarov
2015-03-06 10:06 ` Hans de Goede
[not found] ` <54F97C27.508-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-06 16:25 ` David Daney
2015-03-07 12:06 ` Hans de Goede
2015-03-08 22:48 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2264145.MknHxHLvY7@wuerfel \
--to=arnd@arndb.de \
--cc=aleksey.makarov@auriga.com \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hdegoede@redhat.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
--cc=vgupta@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).