From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v3 6/6] drm/rockchip: cdn-dp: remove the DP phy switch Date: Sat, 17 Feb 2018 01:10:45 +0100 Message-ID: <2266673.GVnnbKjrrE@phil> References: <20180216120956.19034-1-enric.balletbo@collabora.com> <20180216120956.19034-6-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20180216120956.19034-6-enric.balletbo-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Enric Balletbo i Serra Cc: Rob Herring , Kishon Vijay Abraham I , Brian Norris , dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Chris Zhong , William wu , hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kernel-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org List-Id: devicetree@vger.kernel.org Am Freitag, 16. Februar 2018, 13:09:56 CET schrieb Enric Balletbo i Serra: > From: Chris Zhong > > There are 2 Type-c PHYs in RK3399, but only one DP controller. Hence > only one PHY can connect to DP controller at one time, the other should > be disconnected. The GRF_SOC_CON26 register has a switch bit to do it, > set this bit means enable PHY 1, clear this bit means enable PHY 0. > > If the board has 2 Type-C ports, the DP driver get the phy id from > devm_of_phy_get_by_index, and then control this switch according to > this id. But some others board only has one Type-C port, it may be PHY 0 > or PHY 1. The dts node id can not tell us the correct PHY id. Hence move > this switch to PHY driver, the PHY driver can distinguish between PHY 0 > and PHY 1, and then write the correct register bit. > > Signed-off-by: Chris Zhong > Signed-off-by: Enric Balletbo i Serra Reviewed-by: Heiko Stuebner -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html