From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH/RFC v2 05/11] soc: renesas: rcar: Handle clock domain devices in SYSC PM domains Date: Tue, 16 Feb 2016 10:02:36 +0200 Message-ID: <2269681.nQFpo1ggiB@avalon> References: <1455571020-18968-1-git-send-email-geert+renesas@glider.be> <2087210.c20JsV3rp3@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-renesas-soc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Simon Horman , Magnus Damm , linux-renesas-soc@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Linux PM list , "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org Hi Geert, On Tuesday 16 February 2016 08:30:03 Geert Uytterhoeven wrote: > On Mon, Feb 15, 2016 at 11:08 PM, Laurent Pinchart wrote: > > On Monday 15 February 2016 22:16:54 Geert Uytterhoeven wrote: > >> R-Car H3 contains some hardware modules (e.g. VSP and FCP_V) that are > >> not only located in a power area controlled by the SYSC system > >> controller, but that are also part of the generic CPG/MSSR clock domain. > >> Make sure both are handled by enabling module clock PM when the device > >> for such a hardware module is attached to the SYSC PM Domain. > > > > Can't we specify both power domains in the DT power-domains attribute > > instead ? > > While the DT property is called "power-domains" (plural), only the first > entry is parsed by genpd_dev_pm_attach(). Which makes sense for power areas > (if there are multiple, they are nested), but indeed can cause problems > when mixed with clock domains. > > For R-Mobile, I fixed it in a similar way. Still, shouldn't it be fixed in genpd ? -- Regards, Laurent Pinchart