devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: "Michael Niewöhner"
	<mniewoeh-0BV18Q16miHGpFsiFCTsGXqWYbMAw+HU@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: dts: rockchip: add system-power-controller to act8846
Date: Mon, 11 May 2015 23:57:50 +0200	[thread overview]
Message-ID: <2270228.43yCmaWq86@phil> (raw)
In-Reply-To: <64DE272A-FD25-406C-A51B-6C5B76DA5171-0BV18Q16miHGpFsiFCTsGXqWYbMAw+HU@public.gmane.org>

Am Montag, 11. Mai 2015, 22:57:21 schrieb Michael Niewöhner:
> Add system-power-controller to act8846 in rk3188-radxarock.dts in addition
> to the act8846 patch fixing the reboot kernel panic
> 
> Signed-off-by: Michael Niewoehner <mniewoeh-0BV18Q16miHGpFsiFCTsGXqWYbMAw+HU@public.gmane.org>

I have to ask, are you ok with the pending dts relicensing to a gpl2/x11 dual 
license [0]?

Otherwise this looks fine and the act8846 is the power-controller of the 
radxarock in any case, so I'll take this one in any case.


Heiko

[0] http://lists.infradead.org/pipermail/linux-rockchip/2015-March/002644.html


> ---
>  arch/arm/boot/dts/rk3188-radxarock.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts
> b/arch/arm/boot/dts/rk3188-radxarock.dts index bdf8570..225a0eb 100644
> --- a/arch/arm/boot/dts/rk3188-radxarock.dts
> +++ b/arch/arm/boot/dts/rk3188-radxarock.dts
> @@ -152,6 +152,7 @@
>  		compatible = "active-semi,act8846";
>  		reg = <0x5a>;
>  		status = "okay";
> +		system-power-controller;
> 
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&act8846_dvs0_ctl>;

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-05-11 21:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11 20:57 [PATCH 2/2] ARM: dts: rockchip: add system-power-controller to act8846 Michael Niewöhner
     [not found] ` <64DE272A-FD25-406C-A51B-6C5B76DA5171-0BV18Q16miHGpFsiFCTsGXqWYbMAw+HU@public.gmane.org>
2015-05-11 21:57   ` Heiko Stuebner [this message]
2015-05-12  7:22     ` [PATCH 2/2] ARM: dts: rockchip: add system-power-controller toact8846 Michael Niewöhner
2015-05-12 20:44   ` [PATCH 2/2] ARM: dts: rockchip: add system-power-controller to act8846 Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2270228.43yCmaWq86@phil \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mniewoeh-0BV18Q16miHGpFsiFCTsGXqWYbMAw+HU@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).