From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.netcube.li (mail.netcube.li [173.249.15.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 140CE2AD00; Sun, 6 Jul 2025 10:08:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=173.249.15.149 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751796514; cv=none; b=k9B4A7yJ/m8CerlM5s8kX9RJbzCwLabxAQE3h5RxKrzw11LR7TrcwIHUBe8qP/9eY5RIPQ63J/ssi9Aog50Xh4Onvu+nso2qYOUf143uYR6OwOYU0LUOG1HV7J8rj2DJieV4KqFGWP/Ze9emOlvF+CnVEP47vlVvmd180l7CaBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751796514; c=relaxed/simple; bh=n77T+/3wzWMkjN3HwXQrl2Yz514wfjWWjXOH1TaiAf4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Oc+MPoOfclVr2fW0iLNeKKdwqaIucAxJ6GL3ONy48i+WDucia0/y7MmpU5jJcwpldBcDx7tf5nOpGyc1KoLGocpHkbppDAO1jCfbsoRK6bCmnE+lpqLdiNFsTF2RcOSTG6zoPJ9FIIt1uv6Iy179hyZA2O3FXpywAe5JqCT3ltA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=netcube.li; spf=pass smtp.mailfrom=netcube.li; dkim=pass (1024-bit key) header.d=netcube.li header.i=@netcube.li header.b=oyYJcxdv; arc=none smtp.client-ip=173.249.15.149 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=netcube.li Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=netcube.li Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=netcube.li header.i=@netcube.li header.b="oyYJcxdv" dkim-signature: v=1; a=rsa-sha256; d=netcube.li; s=s1; c=relaxed/relaxed; q=dns/txt; h=From:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type:In-Reply-To:References; bh=0T5ERNEDk8sZhawQuX8JVZNNOUKlYRbaNNvCcLZi7To=; b=oyYJcxdvi2HSsrtA0NRNLP07hI9ZWZIgqk6i56SdDxhuilLTawGFGOSVJC912TFRMLct63t8lLnzoG7oTvvmDgV4EQBeh92HD+Ur9BHzL4r4O2nzndjBg/jeI4je5pMqv0FgdW6s+GlBpLEj4MSjeLNSdZYVlPYau+ThN9Towh0= Received: from lukas-hpz440workstation.localnet (cm70-231.liwest.at [212.241.70.231]) by mail.netcube.li with ESMTPSA (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256) ; Sun, 6 Jul 2025 12:08:20 +0200 From: Lukas Schmid To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Maxime Ripard , Krzysztof Kozlowski Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v1 3/7] dt-bindings: arm: sunxi: Add NetCube Systems Nagami Keypad Carrier Board Date: Sun, 06 Jul 2025 12:08:18 +0200 Message-ID: <22754446.EfDdHjke4D@lukas-hpz440workstation> In-Reply-To: <8549188.T7Z3S40VBb@lukas-hpz440workstation> References: <20250705213900.3614963-1-lukas.schmid@netcube.li> <4648f0bf-2957-45bf-a6c1-01787e5d3e88@kernel.org> <8549188.T7Z3S40VBb@lukas-hpz440workstation> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7824363.EvYhyI6sBW"; micalg="pgp-sha512"; protocol="application/pgp-signature" --nextPart7824363.EvYhyI6sBW Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Lukas Schmid Date: Sun, 06 Jul 2025 12:08:18 +0200 Message-ID: <22754446.EfDdHjke4D@lukas-hpz440workstation> In-Reply-To: <8549188.T7Z3S40VBb@lukas-hpz440workstation> MIME-Version: 1.0 On Sonntag, 6. Juli 2025 11:58:16 CEST Lukas Schmid wrote: > On Sonntag, 6. Juli 2025 11:46:46 CEST Krzysztof Kozlowski wrote: > > On 06/07/2025 11:41, Lukas Schmid wrote: > > > On Sonntag, 6. Juli 2025 11:36:34 CEST Krzysztof Kozlowski wrote: > > >> On 06/07/2025 11:07, Lukas Schmid wrote: > > >>> On Sonntag, 6. Juli 2025 09:49:58 CEST Krzysztof Kozlowski wrote: > > >>>> On 05/07/2025 23:38, Lukas Schmid wrote: > > >>>>> The NetCube Systems Nagami Keypad Carrier is a custom board intended > > >>>>> to > > >>>>> fit a standard Ritto Intercom enclosure and provides a Keypad, > > >>>>> NFC-Reader > > >>>>> and Status-LED all controllable over Ethernet with PoE support. > > >>>>> > > >>>>> Signed-off-by: Lukas Schmid > > >>>>> --- > > >>>>> > > >>>>> Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++ > > >>>>> 1 file changed, 6 insertions(+) > > >>>>> > > >>>>> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml > > >>>>> b/Documentation/devicetree/bindings/arm/sunxi.yaml index > > >>>>> 7919b5bf5..a2f16d064 100644 > > >>>>> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > >>>>> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > >>>>> > > >>>>> @@ -610,6 +610,12 @@ properties: > > >>>>> - const: netcube,nagami > > >>>>> - const: allwinner,sun8i-t113s > > >>>>> > > >>>>> + - description: NetCube Systems Nagami Keypad Carrier Board > > >>>>> + items: > > >>>>> + - const: netcube,nagami-keypad-carrier > > >>>> > > >>>> That's just enum with previous entry. Don't make it over-complicated. > > >>>> > > >>>> Best regards, > > >>>> Krzysztof > > >>> > > >>> Just making sure here. The actual bindings are fine, but I should > > >>> merge > > >>> them into one patch, correct? > > >> > > >> No, you got two comments what should be changed in the binding. > > >> > > >> Best regards, > > >> Krzysztof > > > > > > So if I understand correctly you want me to remove the > > > "allwinner,sun8i-t113s" from the carrier boards and keep it for the SoM? > > > > No, I spoke nothing about that compatible. My comment is EXACTLY under > > the line being incorrect. That entry should have been made enum with > > previous board compatible. Look at other vendors, because this file > > repeats that pattern for some reason, eh... > > > > Best regards, > > Krzysztof > > Ah sorry. I think i understand now. You want the carrier boards in a single > entry with the different compatibles as the enum like: > > - description: NetCube Systems Nagami SoM > items: > - const: netcube,nagami > - const: allwinner,sun8i-t113s > > - description: NetCube Systems Nagami SoM based boards > items: > - enum: > - netcube,nagami-basic-carrier > - netcube,nagami-keypad-carrier > - const: netcube,nagami > - const: allwinner,sun8i-t113s > > Best regards, > Lukas Oh, I will then drop the SoM's entry as well since the SoM is already defined in the carrier boards then. So only - description: NetCube Systems Nagami SoM based boards items: - enum: - netcube,nagami-basic-carrier - netcube,nagami-keypad-carrier - const: netcube,nagami - const: allwinner,sun8i-t113s correct? Sorry for the back-and-forth, and thanks for your patience. Best regards, Lukas --nextPart7824363.EvYhyI6sBW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEPv6dcBmn59ssZMkSJnN+drMVRtgFAmhqSxMACgkQJnN+drMV RthYPgf7B7hvP/DGLODPXJ1qjUQvXaRZGtuTOiaLfm61dhyn2IsydYUhpwhhMViQ z6T4DAm9Eg8CcJqiTb1kckKS/dheJ+eom2IBK9LLb2JHbXaetlXlSvDfbWlTS1I2 ofG6QKBDYHccjJiejjI2uEIAYALwCMjqxudUUCoMN2hz8euzwKx8dzEXfdWZmcRj OzeZsdwQkv8RvP+eiii1xdu/GbnMGKixs75n40v535LOdVWD/hptkJKMPW0fNe8A 4Hd6uhLD7lZ3qIuEMZfvcCjOF/iCKafXpjCuK6CdFwfC5j+Sgrr3Z5zMAIJ3WRbr qCBfoSswKd8fkF5d6rVpVOBcBOPa5g== =JbSx -----END PGP SIGNATURE----- --nextPart7824363.EvYhyI6sBW--