* [PATCH] ARM: shmobile: r8a7790: add MLB+ clock
@ 2014-12-18 20:41 Sergei Shtylyov
2014-12-22 0:06 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2014-12-18 20:41 UTC (permalink / raw)
To: horms, linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak
Cc: linux, magnus.damm, linux-arm-kernel
From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
Add MLB+ clock to R8A7790 device tree.
Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
[Sergei: rebased, renamed, added changelog]
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against 'renesas-devel-20141218-v3.18' tag of Simon Horman's
'renesas.git' repo.
arch/arm/boot/dts/r8a7790.dtsi | 13 +++++++------
include/dt-bindings/clock/r8a7790-clock.h | 1 +
2 files changed, 8 insertions(+), 6 deletions(-)
Index: renesas/arch/arm/boot/dts/r8a7790.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi
+++ renesas/arch/arm/boot/dts/r8a7790.dtsi
@@ -1149,16 +1149,17 @@
mstp8_clks: mstp8_clks@e6150990 {
compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
- clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
- <&zs_clk>, <&zs_clk>;
+ clocks = <&hp_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>,
+ <&zg_clk>, <&p_clk>, <&zs_clk>, <&zs_clk>;
#clock-cells = <1>;
clock-indices = <
- R8A7790_CLK_VIN3 R8A7790_CLK_VIN2 R8A7790_CLK_VIN1
- R8A7790_CLK_VIN0 R8A7790_CLK_ETHER R8A7790_CLK_SATA1
- R8A7790_CLK_SATA0
+ R8A7790_CLK_MLB R8A7790_CLK_VIN3 R8A7790_CLK_VIN2
+ R8A7790_CLK_VIN1 R8A7790_CLK_VIN0 R8A7790_CLK_ETHER
+ R8A7790_CLK_SATA1 R8A7790_CLK_SATA0
>;
clock-output-names =
- "vin3", "vin2", "vin1", "vin0", "ether", "sata1", "sata0";
+ "mlb", "vin3", "vin2", "vin1", "vin0", "ether",
+ "sata1", "sata0";
};
mstp9_clks: mstp9_clks@e6150994 {
compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
Index: renesas/include/dt-bindings/clock/r8a7790-clock.h
===================================================================
--- renesas.orig/include/dt-bindings/clock/r8a7790-clock.h
+++ renesas/include/dt-bindings/clock/r8a7790-clock.h
@@ -97,6 +97,7 @@
#define R8A7790_CLK_LVDS0 26
/* MSTP8 */
+#define R8A7790_CLK_MLB 2
#define R8A7790_CLK_VIN3 8
#define R8A7790_CLK_VIN2 9
#define R8A7790_CLK_VIN1 10
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: r8a7790: add MLB+ clock
2014-12-18 20:41 [PATCH] ARM: shmobile: r8a7790: add MLB+ clock Sergei Shtylyov
@ 2014-12-22 0:06 ` Simon Horman
2014-12-22 21:43 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2014-12-22 0:06 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
On Thu, Dec 18, 2014 at 11:41:52PM +0300, Sergei Shtylyov wrote:
> From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
>
> Add MLB+ clock to R8A7790 device tree.
>
> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> [Sergei: rebased, renamed, added changelog]
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against 'renesas-devel-20141218-v3.18' tag of Simon Horman's
> 'renesas.git' repo.
Thanks, I have queued this up.
>
> arch/arm/boot/dts/r8a7790.dtsi | 13 +++++++------
> include/dt-bindings/clock/r8a7790-clock.h | 1 +
> 2 files changed, 8 insertions(+), 6 deletions(-)
>
> Index: renesas/arch/arm/boot/dts/r8a7790.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7790.dtsi
> @@ -1149,16 +1149,17 @@
> mstp8_clks: mstp8_clks@e6150990 {
> compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
> reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> - clocks = <&zg_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>, <&p_clk>,
> - <&zs_clk>, <&zs_clk>;
> + clocks = <&hp_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>,
> + <&zg_clk>, <&p_clk>, <&zs_clk>, <&zs_clk>;
> #clock-cells = <1>;
> clock-indices = <
> - R8A7790_CLK_VIN3 R8A7790_CLK_VIN2 R8A7790_CLK_VIN1
> - R8A7790_CLK_VIN0 R8A7790_CLK_ETHER R8A7790_CLK_SATA1
> - R8A7790_CLK_SATA0
> + R8A7790_CLK_MLB R8A7790_CLK_VIN3 R8A7790_CLK_VIN2
> + R8A7790_CLK_VIN1 R8A7790_CLK_VIN0 R8A7790_CLK_ETHER
> + R8A7790_CLK_SATA1 R8A7790_CLK_SATA0
> >;
> clock-output-names =
> - "vin3", "vin2", "vin1", "vin0", "ether", "sata1", "sata0";
> + "mlb", "vin3", "vin2", "vin1", "vin0", "ether",
> + "sata1", "sata0";
> };
> mstp9_clks: mstp9_clks@e6150994 {
> compatible = "renesas,r8a7790-mstp-clocks", "renesas,cpg-mstp-clocks";
> Index: renesas/include/dt-bindings/clock/r8a7790-clock.h
> ===================================================================
> --- renesas.orig/include/dt-bindings/clock/r8a7790-clock.h
> +++ renesas/include/dt-bindings/clock/r8a7790-clock.h
> @@ -97,6 +97,7 @@
> #define R8A7790_CLK_LVDS0 26
>
> /* MSTP8 */
> +#define R8A7790_CLK_MLB 2
> #define R8A7790_CLK_VIN3 8
> #define R8A7790_CLK_VIN2 9
> #define R8A7790_CLK_VIN1 10
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: r8a7790: add MLB+ clock
2014-12-22 0:06 ` Simon Horman
@ 2014-12-22 21:43 ` Sergei Shtylyov
2014-12-23 0:23 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2014-12-22 21:43 UTC (permalink / raw)
To: Simon Horman
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
On 12/22/2014 03:06 AM, Simon Horman wrote:
>> From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
>> Add MLB+ clock to R8A7790 device tree.
>> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
>> [Sergei: rebased, renamed, added changelog]
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> This patch is against 'renesas-devel-20141218-v3.18' tag of Simon Horman's
>> 'renesas.git' repo.
> Thanks, I have queued this up.
Oops, just saw a formatting issue in this patch...
[...]
>> Index: renesas/include/dt-bindings/clock/r8a7790-clock.h
>> ===================================================================
>> --- renesas.orig/include/dt-bindings/clock/r8a7790-clock.h
>> +++ renesas/include/dt-bindings/clock/r8a7790-clock.h
>> @@ -97,6 +97,7 @@
>> #define R8A7790_CLK_LVDS0 26
>>
>> /* MSTP8 */
>> +#define R8A7790_CLK_MLB 2
Need one more tab here.
>> #define R8A7790_CLK_VIN3 8
>> #define R8A7790_CLK_VIN2 9
>> #define R8A7790_CLK_VIN1 10
Perhaps you still can fix it up, or I can resend? I'm not seeing this
patch in the 'devel' branch yet...
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: r8a7790: add MLB+ clock
2014-12-22 21:43 ` Sergei Shtylyov
@ 2014-12-23 0:23 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2014-12-23 0:23 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
Hi Sergei,
On Tue, Dec 23, 2014 at 12:43:13AM +0300, Sergei Shtylyov wrote:
> On 12/22/2014 03:06 AM, Simon Horman wrote:
>
> >>From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
>
> >>Add MLB+ clock to R8A7790 device tree.
>
> >>Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> >>[Sergei: rebased, renamed, added changelog]
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>---
> >>This patch is against 'renesas-devel-20141218-v3.18' tag of Simon Horman's
> >>'renesas.git' repo.
>
> >Thanks, I have queued this up.
>
> Oops, just saw a formatting issue in this patch...
>
> [...]
> >>Index: renesas/include/dt-bindings/clock/r8a7790-clock.h
> >>===================================================================
> >>--- renesas.orig/include/dt-bindings/clock/r8a7790-clock.h
> >>+++ renesas/include/dt-bindings/clock/r8a7790-clock.h
> >>@@ -97,6 +97,7 @@
> >> #define R8A7790_CLK_LVDS0 26
> >>
> >> /* MSTP8 */
> >>+#define R8A7790_CLK_MLB 2
>
> Need one more tab here.
>
> >> #define R8A7790_CLK_VIN3 8
> >> #define R8A7790_CLK_VIN2 9
> >> #define R8A7790_CLK_VIN1 10
>
> Perhaps you still can fix it up, or I can resend? I'm not seeing this
> patch in the 'devel' branch yet...
Thanks for following up on this.
I had the patch queued up locally but it seems that I forgot to push them.
I have fixed up this patch by adding an extra tab and pushed the result.
The result should be in renesas-devel-20141223-v3.19-rc1
(But kernel.org seems slow today).
Please let me know if I messed things up somehow.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-23 0:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-18 20:41 [PATCH] ARM: shmobile: r8a7790: add MLB+ clock Sergei Shtylyov
2014-12-22 0:06 ` Simon Horman
2014-12-22 21:43 ` Sergei Shtylyov
2014-12-23 0:23 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).