devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: horms@verge.net.au, linux-sh@vger.kernel.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	devicetree@vger.kernel.org, magnus.damm@gmail.com,
	linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support
Date: Wed, 25 Feb 2015 12:11:35 +0200	[thread overview]
Message-ID: <2292882.LbM0mNWfOj@avalon> (raw)
In-Reply-To: <3082195.zNdUtZ8oMM@wasted.cogentembedded.com>

Hi Sergei,

Thank you for the patch.

On Sunday 22 February 2015 01:12:31 Sergei Shtylyov wrote:
> Describe GPIO[0-6] controllers in the R8A7794 device tree.
> 
> Based on original patch by Hisashi Nakamura
> <hisashi.nakamura.ak@renesas.com>.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> ---
>  arch/arm/boot/dts/r8a7794.dtsi |   84 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 84 insertions(+)
> 
> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
> @@ -50,6 +50,90 @@
>  		interrupts = <1 9 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
>  	};
> 
> +	gpio0: gpio@e6050000 {
> +		compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar";
> +		reg = <0 0xe6050000 0 0x50>;
> +		interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +		gpio-ranges = <&pfc 0 0 32>;
> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		clocks = <&mstp9_clks R8A7794_CLK_GPIO0>;
> +	};
> +
> +	gpio1: gpio@e6051000 {
> +		compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar";
> +		reg = <0 0xe6051000 0 0x50>;
> +		interrupts = <0 5 IRQ_TYPE_LEVEL_HIGH>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +		gpio-ranges = <&pfc 0 32 32>;

This GPIO block has 26 GPIOs only.

> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		clocks = <&mstp9_clks R8A7794_CLK_GPIO1>;
> +	};
> +
> +	gpio2: gpio@e6052000 {
> +		compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar";
> +		reg = <0 0xe6052000 0 0x50>;
> +		interrupts = <0 6 IRQ_TYPE_LEVEL_HIGH>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +		gpio-ranges = <&pfc 0 64 32>;
> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		clocks = <&mstp9_clks R8A7794_CLK_GPIO2>;
> +	};
> +
> +	gpio3: gpio@e6053000 {
> +		compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar";
> +		reg = <0 0xe6053000 0 0x50>;
> +		interrupts = <0 7 IRQ_TYPE_LEVEL_HIGH>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +		gpio-ranges = <&pfc 0 96 32>;
> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		clocks = <&mstp9_clks R8A7794_CLK_GPIO3>;
> +	};
> +
> +	gpio4: gpio@e6054000 {
> +		compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar";
> +		reg = <0 0xe6054000 0 0x50>;
> +		interrupts = <0 8 IRQ_TYPE_LEVEL_HIGH>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +		gpio-ranges = <&pfc 0 128 32>;
> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		clocks = <&mstp9_clks R8A7794_CLK_GPIO4>;
> +	};
> +
> +	gpio5: gpio@e6055000 {
> +		compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar";
> +		reg = <0 0xe6055000 0 0x50>;
> +		interrupts = <0 9 IRQ_TYPE_LEVEL_HIGH>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +		gpio-ranges = <&pfc 0 160 32>;

This GPIO block has 28 GPIOs only.

> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		clocks = <&mstp9_clks R8A7794_CLK_GPIO5>;
> +	};
> +
> +	gpio6: gpio@e6055400 {
> +		compatible = "renesas,gpio-r8a7794", "renesas,gpio-rcar";
> +		reg = <0 0xe6055400 0 0x50>;
> +		interrupts = <0 10 IRQ_TYPE_LEVEL_HIGH>;
> +		#gpio-cells = <2>;
> +		gpio-controller;
> +		gpio-ranges = <&pfc 0 192 32>;

This GPIO block has 26 GPIOs only.

> +		#interrupt-cells = <2>;
> +		interrupt-controller;
> +		clocks = <&mstp9_clks R8A7794_CLK_GPIO6>;
> +	};
> +
>  	cmt0: timer@ffca0000 {
>  		compatible = "renesas,cmt-48-gen2";
>  		reg = <0 0xffca0000 0 0x1004>;

-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2015-02-25 10:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-21 22:10 [PATCH 0/2] Add R8A7794 GPIO DT support Sergei Shtylyov
2015-02-21 22:11 ` [PATCH 1/2] ARM: shmobile: r8a7794: add GPIO clocks Sergei Shtylyov
     [not found]   ` <1831753.Dnjo3xKPJv-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org>
2015-02-23 11:08     ` Geert Uytterhoeven
2015-02-25  9:57   ` Laurent Pinchart
2015-02-21 22:12 ` [PATCH 2/2] ARM: shmobile: r8a7794: add GPIO DT support Sergei Shtylyov
2015-02-23 11:11   ` Geert Uytterhoeven
2015-02-25 10:11   ` Laurent Pinchart [this message]
2015-02-25 10:27     ` Geert Uytterhoeven
2015-02-25 22:10       ` Laurent Pinchart
2015-02-25 14:04     ` Sergei Shtylyov
2015-02-25 14:08       ` Laurent Pinchart
2015-02-23 22:00 ` [PATCH 0/2] Add R8A7794 " Simon Horman
2015-02-23 23:19   ` Simon Horman
     [not found]     ` <20150223231901.GD29878-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2015-02-24 14:43       ` Sergei Shtylyov
2015-02-25  8:07         ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2292882.LbM0mNWfOj@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=horms@verge.net.au \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).