From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3F0CC4332F for ; Wed, 16 Nov 2022 12:56:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229868AbiKPM4s (ORCPT ); Wed, 16 Nov 2022 07:56:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231231AbiKPM4r (ORCPT ); Wed, 16 Nov 2022 07:56:47 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51E5E1E3DD for ; Wed, 16 Nov 2022 04:56:45 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id s5so10196555edc.12 for ; Wed, 16 Nov 2022 04:56:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=FpXPXex2pj+shAOqQ1Qkj2iiHvrTjroDhyNWQJmN94Y=; b=uwAyUynBI4H0SytHKL+axjOZPqeGxypmmWoN1PVWXgo2T915dI6384z7FSwUV024hy cy7/wxG94xGD/dy6UADeaz9JgEqWhCfiQ64qZW0bPLfWSXTo+hPEB/H/y9UOuvpJk+xT xGgJjrblQ0vXWIKJ/GjIcn8KVZn1UHvNn4tqdJj2ChPWa/Zjgu5JdeOLoW7uPfIaRvEc Cqs6eSv39AuGnUF8cxG3gg+sWRQ5cab0ZwhsteIwk7p/0taYb3twBj3+G9ZXdjasIkvV 3n6mLodYblv70Xe/0dx36ut3qEe61uaB1V+DIwbedhtCgFPQtRXkA9v8jGbSI+DHC4zP 0f6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FpXPXex2pj+shAOqQ1Qkj2iiHvrTjroDhyNWQJmN94Y=; b=v0WVuSq5P9G5v3D4QspCIZqsrxNzXWAQG1rtJqOaVShprD/mQpcN+r2JQuOWInqMDx /f34IB6zV2qi5khGXfKCxKUhPD8gDLwjGNZXV/wCqSyRuviqy8Y2Agw5l8HYln42Ta53 BRATuaD4YBW/32wQVfPsiq13Y9Lay0/yXN1KqTDGrAWSjVvlbjZjS5DLzzrCwCkNOJWC VphLtkA+iLZTNEPUXLCXiQgFxVuOuJKdrV1p6vilQeB/ccVtuRyLN+72e+iWoVWOVIMM BBeys+qhemuyfjGf8rq/z5SqbXqFGlg1+COOOUVm5fsG2PrJvx+HaZvUYBJkz7IgpiNk tP9g== X-Gm-Message-State: ANoB5pmT5rrdA5SZkzFYoOmi0C+yTOQsQXw8TpDM40Xck2CP8XLoHfND 9EEQG2IFX7ZPA4zjgTz+MigURw== X-Google-Smtp-Source: AA0mqf7lWA/QwqvzGcqFNDfNRicifSvvzr+7KxdPHa48eaUPqyAWOlh4cLsWjWIdcLTzBewgPlGhdQ== X-Received: by 2002:a50:fe19:0:b0:462:70ee:fdb8 with SMTP id f25-20020a50fe19000000b0046270eefdb8mr19532589edt.66.1668603403903; Wed, 16 Nov 2022 04:56:43 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id qq18-20020a17090720d200b0078df3b4464fsm6939633ejb.19.2022.11.16.04.56.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Nov 2022 04:56:43 -0800 (PST) Message-ID: <22a41a8c-9b4a-ecca-ddd2-5e217d00d20c@linaro.org> Date: Wed, 16 Nov 2022 13:56:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8550-mtp: Add UFS host controller and PHY node To: Abel Vesa , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20221116125112.2788318-1-abel.vesa@linaro.org> <20221116125112.2788318-3-abel.vesa@linaro.org> From: Konrad Dybcio In-Reply-To: <20221116125112.2788318-3-abel.vesa@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/11/2022 13:51, Abel Vesa wrote: > Enable UFS host controller and PHY node on SM8550 MTP board. > > Signed-off-by: Abel Vesa > --- > arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > index d4c8d5b2497e..fef7793a7dec 100644 > --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts > @@ -417,3 +417,25 @@ data-pins { > &uart7 { > status = "okay"; > }; > + > +&ufs_mem_hc { > + status = "okay"; Status last, please. > + > + reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>; > + > + vcc-supply = <&vreg_l17b_2p5>; > + vcc-max-microamp = <1300000>; All these -microamp properties are downstream and do not exist in the mainline kernel. Remove them. Konrad > + vccq-supply = <&vreg_l1g_1p2>; > + vccq-max-microamp = <1200000>; > + vccq2-supply = <&vreg_l3g_1p2>; > + vccq2-max-microamp = <100>; > +}; > + > +&ufs_mem_phy { > + status = "okay"; > + > + vdda-phy-supply = <&vreg_l1d_0p88>; > + vdda-phy-max-microamp = <188000>; > + vdda-pll-supply = <&vreg_l3e_1p2>; > + vdda-pll-max-microamp = <18300>; > +};