From: Guenter Roeck <linux@roeck-us.net>
To: "Torreno, Alexis Czezar" <AlexisCzezar.Torreno@analog.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH 5/6] dt-bindings: hwmon: (pmbus/max20830): add max20830c and max20840c support
Date: Tue, 30 Jun 2026 08:06:02 -0700 [thread overview]
Message-ID: <22c253eb-d2bd-4e2d-9d8c-baff07306a30@roeck-us.net> (raw)
In-Reply-To: <PH0PR03MB63512440FF07E171477CD42BF1F72@PH0PR03MB6351.namprd03.prod.outlook.com>
On 6/30/26 01:07, Torreno, Alexis Czezar wrote:
>
>>>
>>> properties:
>>> compatible:
>>> - const: adi,max20830
>>> + oneOf:
>>> + - const: adi,max20830
>>> + - items:
>>> + - enum:
>>> + - adi,max20830c
>>> + - adi,max20840c
>>> + - const: adi,max20830 # Fallback compatible
>>
>> Drop the comment, it is obvious. Can this be not a fallback compatible?
>>
>
> After considering the feedback from patch 6/6 regarding this fallback, I think I
> would not make this fallback compatible. Will edit out.
>
The chips are technically identical (register compatible) except for
the device ID string. That can be evaluated in the driver without
requiring a separate compatible entry in the devicetree description.
Guenter
next prev parent reply other threads:[~2026-06-30 15:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 2:46 [PATCH 0/6] Add support for MAX20830C and MAX20840C step-down DC-DC switching regulator Alexis Czezar Torreno
2026-06-30 2:46 ` [PATCH 1/6] dt-bindings: hwmon: (pmbus/max20830): add enable-gpios property Alexis Czezar Torreno
2026-06-30 2:51 ` sashiko-bot
2026-06-30 7:26 ` Krzysztof Kozlowski
2026-06-30 8:07 ` Torreno, Alexis Czezar
2026-06-30 15:48 ` Guenter Roeck
2026-07-01 1:16 ` Torreno, Alexis Czezar
2026-06-30 2:46 ` [PATCH 2/6] hwmon: (pmbus/max20830): add support for enable GPIO Alexis Czezar Torreno
2026-06-30 2:53 ` sashiko-bot
2026-06-30 3:50 ` Guenter Roeck
2026-06-30 4:51 ` Guenter Roeck
2026-06-30 8:07 ` Torreno, Alexis Czezar
2026-06-30 2:46 ` [PATCH 3/6] dt-bindings: hwmon: (pmbus/max20830): add VOUT feedback resistor properties Alexis Czezar Torreno
2026-06-30 3:02 ` sashiko-bot
2026-06-30 7:39 ` Krzysztof Kozlowski
2026-06-30 2:46 ` [PATCH 4/6] hwmon: (pmbus/max20830): add VOUT feedback resistor scaling support Alexis Czezar Torreno
2026-06-30 3:00 ` sashiko-bot
2026-06-30 4:53 ` Guenter Roeck
2026-06-30 8:07 ` Torreno, Alexis Czezar
2026-06-30 15:34 ` Guenter Roeck
2026-07-01 1:16 ` Torreno, Alexis Czezar
2026-06-30 2:46 ` [PATCH 5/6] dt-bindings: hwmon: (pmbus/max20830): add max20830c and max20840c support Alexis Czezar Torreno
2026-06-30 2:56 ` sashiko-bot
2026-06-30 7:41 ` Krzysztof Kozlowski
2026-06-30 8:07 ` Torreno, Alexis Czezar
2026-06-30 15:06 ` Guenter Roeck [this message]
2026-06-30 2:46 ` [PATCH 6/6] hwmon: (pmbus/max20830): add support for max20830c and max20840c Alexis Czezar Torreno
2026-06-30 2:54 ` sashiko-bot
2026-06-30 3:43 ` Guenter Roeck
2026-06-30 8:07 ` Torreno, Alexis Czezar
2026-06-30 15:04 ` Guenter Roeck
2026-07-02 2:50 ` Torreno, Alexis Czezar
2026-07-02 4:43 ` Guenter Roeck
2026-07-02 7:28 ` Torreno, Alexis Czezar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22c253eb-d2bd-4e2d-9d8c-baff07306a30@roeck-us.net \
--to=linux@roeck-us.net \
--cc=AlexisCzezar.Torreno@analog.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox