devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: horms@verge.net.au, geert@linux-m68k.org,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
	Takeshi Kihara <takeshi.kihara.df@renesas.com>
Subject: Re: [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering
Date: Mon, 05 Nov 2018 14:03:00 +0200	[thread overview]
Message-ID: <2304817.kXOOSB9WQa@avalon> (raw)
In-Reply-To: <1541418561-21977-1-git-send-email-jacopo+renesas@jmondi.org>

Hi Jacopo,

Thank you for the patch.

On Monday, 5 November 2018 13:49:21 EET Jacopo Mondi wrote:
> The VIN driver bindings dictates fixed numbering for VIN endpoints connected
> to CSI-2 endpoints, even when a single endpoint exists.
> 
> Without proper endpoint numbering the VIN driver fails to probe.
> 
> Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2
> device nodes") Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index 9509dc0..97f7e0c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -747,7 +747,8 @@
>  				port@1 {
>  					reg = <1>;
> 
> -					vin4csi40: endpoint {
> +					vin4csi40: endpoint@2 {
> +						reg = <2>;
>  						remote-endpoint= <&csi40vin4>;
>  					};
>  				};
> @@ -771,7 +772,8 @@
>  				port@1 {
>  					reg = <1>;
> 
> -					vin5csi40: endpoint {
> +					vin5csi40: endpoint@2 {
> +						reg = <2>;
>  						remote-endpoint= <&csi40vin5>;
>  					};
>  				};
> --
> 2.7.4


-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2018-11-05 21:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05 11:49 [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering Jacopo Mondi
2018-11-05 12:03 ` Laurent Pinchart [this message]
2018-11-05 12:07 ` Geert Uytterhoeven
2018-11-05 12:46   ` jacopo mondi
2018-11-05 12:57     ` Geert Uytterhoeven
2018-11-05 13:08       ` jacopo mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2304817.kXOOSB9WQa@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=horms@verge.net.au \
    --cc=jacopo+renesas@jmondi.org \
    --cc=koji.matsuoka.xm@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=takeshi.kihara.df@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).