From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=HAag=NQ=vger.kernel.org=devicetree-owner@kernel.org>
Received: from perceval.ideasonboard.com ([213.167.242.64]:58950 "EHLO
        perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726723AbeKEVWP (ORCPT
        <rfc822;devicetree@vger.kernel.org>); Mon, 5 Nov 2018 16:22:15 -0500
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] arm64: dts: renesas: r8a77990: Fix VIN endpoint numbering
Date: Mon, 05 Nov 2018 14:03:00 +0200
Message-ID: <2304817.kXOOSB9WQa@avalon>
In-Reply-To: <1541418561-21977-1-git-send-email-jacopo+renesas@jmondi.org>
References: <1541418561-21977-1-git-send-email-jacopo+renesas@jmondi.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: devicetree-owner@vger.kernel.org
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: horms@verge.net.au, geert@linux-m68k.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, Koji Matsuoka <koji.matsuoka.xm@renesas.com>, Takeshi Kihara <takeshi.kihara.df@renesas.com>
List-ID: <devicetree@vger.kernel.org>

Hi Jacopo,

Thank you for the patch.

On Monday, 5 November 2018 13:49:21 EET Jacopo Mondi wrote:
> The VIN driver bindings dictates fixed numbering for VIN endpoints connected
> to CSI-2 endpoints, even when a single endpoint exists.
> 
> Without proper endpoint numbering the VIN driver fails to probe.
> 
> Fixes: ec70407ae7d7 ("arm64: dts: renesas: r8a77990: Add VIN and CSI-2
> device nodes") Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77990.dtsi index 9509dc0..97f7e0c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -747,7 +747,8 @@
>  				port@1 {
>  					reg = <1>;
> 
> -					vin4csi40: endpoint {
> +					vin4csi40: endpoint@2 {
> +						reg = <2>;
>  						remote-endpoint= <&csi40vin4>;
>  					};
>  				};
> @@ -771,7 +772,8 @@
>  				port@1 {
>  					reg = <1>;
> 
> -					vin5csi40: endpoint {
> +					vin5csi40: endpoint@2 {
> +						reg = <2>;
>  						remote-endpoint= <&csi40vin5>;
>  					};
>  				};
> --
> 2.7.4


-- 
Regards,

Laurent Pinchart