From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 01/13] devicetree/bindings: display: Document common panel properties
Date: Tue, 22 Nov 2016 11:36:55 +0200 [thread overview]
Message-ID: <2307840.2mk6E40XHl@avalon> (raw)
In-Reply-To: <20161121164815.bxca4rfvifloizdh@rob-hp-laptop>
Hi Rob,
On Monday 21 Nov 2016 10:48:15 Rob Herring wrote:
> On Sat, Nov 19, 2016 at 05:28:01AM +0200, Laurent Pinchart wrote:
> > Document properties common to several display panels in a central
> > location that can be referenced by the panel device tree bindings.
>
> Looks good. Just one comment...
>
> [...]
>
> > +Connectivity
> > +------------
> > +
> > +- ports: Panels receive video data through one or multiple connections.
> > While
> > + the nature of those connections is specific to the panel type, the
> > + connectivity is expressed in a standard fashion using ports as
> > specified in
> > + the device graph bindings defined in
> > + Documentation/devicetree/bindings/graph.txt.
>
> We allow panels to either use graph binding or be a child of the display
> controller.
I knew that some display controllers use a phandle to the panel (see the
fsl,panel and nvidia,panel properties), but I didn't know we had panels as
children of display controller nodes. I don't think we should allow that for
anything but DSI panels, as the DT hierarchy is based on control buses. Are
you sure we have other panels instantiated through that mechanism ?
> Using the graph is preferred, but in the simple cases just a child node is
> sufficient. This should be described here or somewhere in this doc.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-11-22 9:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-19 3:28 [PATCH v2 00/13] R-Car DU: Add support for LVDS mode selection Laurent Pinchart
2016-11-19 3:28 ` [PATCH v2 01/13] devicetree/bindings: display: Document common panel properties Laurent Pinchart
2016-11-21 16:48 ` Rob Herring
2016-11-22 9:36 ` Laurent Pinchart [this message]
2016-11-29 8:27 ` Laurent Pinchart
2016-11-29 15:14 ` Rob Herring
2016-11-29 18:23 ` Laurent Pinchart
2016-12-18 20:54 ` Laurent Pinchart
2016-12-19 15:38 ` Rob Herring
2016-12-19 16:54 ` Laurent Pinchart
2017-01-03 22:33 ` Rob Herring
[not found] ` <1479526093-7014-2-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2016-11-22 11:05 ` Thierry Reding
2016-11-22 13:14 ` Laurent Pinchart
2016-11-22 21:10 ` Rob Herring
2017-04-09 11:47 ` Emil Velikov
2017-04-11 5:12 ` Laurent Pinchart
2016-11-19 3:28 ` [PATCH v2 02/13] devicetree/bindings: display: Add bindings for LVDS panels Laurent Pinchart
[not found] ` <1479526093-7014-3-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2016-11-21 16:48 ` Rob Herring
2016-11-22 11:02 ` Thierry Reding
2016-11-22 13:21 ` Laurent Pinchart
[not found] ` <1479526093-7014-1-git-send-email-laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
2016-11-19 3:28 ` [PATCH v2 03/13] devicetree/bindings: display: Add bindings for two Mitsubishi panels Laurent Pinchart
2016-11-21 16:49 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2307840.2mk6E40XHl@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).