From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108
Date: Sun, 13 Aug 2017 14:13:01 +0200 [thread overview]
Message-ID: <2309743.33rDFhBfGp@phil> (raw)
In-Reply-To: <1502423211-31216-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Hi Andy,
Am Freitag, 11. August 2017, 11:46:51 CEST schrieb Andy Yan:
> Add saradc device tree node for rv1108 soc
>
> Signed-off-by: Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> + adc: adc@1038c000 {
> + compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc";
> + reg = <0x1038c000 0x100>;
> + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
> + #io-channel-cells = <1>;
> + io-channel-ranges;
What do you need the io-channel-ranges for?
I.e. according to the documenation it is meant for when the adc is also
a "bus node" and has children that should inherit channels from it.
In all saradc uses so far we only have separate nodes referencing the
adc controller (like adc-keys etc), so this does not look like it is needed?
Heiko
next prev parent reply other threads:[~2017-08-13 12:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 3:36 [PATCH v3 00/13] Support more devices on rockchip rv1108 Andy Yan
[not found] ` <1502422578-30611-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-11 3:38 ` [PATCH v3 01/13] dt-bindings: i2c: rk3x: add support for rv1108 Andy Yan
[not found] ` <1502422709-30672-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-12 14:40 ` Wolfram Sang
2017-08-11 3:39 ` [PATCH v3 02/13] " Andy Yan
2017-08-12 14:01 ` Wolfram Sang
2017-08-12 14:30 ` Andy Yan
2017-08-12 14:38 ` Wolfram Sang
2017-08-12 14:40 ` Wolfram Sang
2017-08-11 3:45 ` [PATCH v3 08/13] ARM: dts: rockchip: add watchdog dt node " Andy Yan
[not found] ` <1502423133-31097-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-13 12:14 ` Heiko Stuebner
2017-08-11 3:46 ` [PATCH v3 09/13] dt-bindings: adc: add description for rv1108 saradc Andy Yan
[not found] ` <1502423180-31154-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-12 12:39 ` Jonathan Cameron
2017-08-11 3:46 ` [PATCH v3 10/13] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan
[not found] ` <1502423211-31216-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-13 12:13 ` Heiko Stuebner [this message]
2017-08-14 1:42 ` Andy Yan
2017-08-11 3:47 ` [PATCH v3 11/13] ARM: dts: rockchip: add pwm backlight for rv1108 evb Andy Yan
2017-08-11 3:49 ` [PATCH v3 13/13] ARM: dts: rockchip: add accelerometer bma250e dt node " Andy Yan
[not found] ` <1502423358-31375-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-13 12:16 ` Heiko Stuebner
2017-08-11 3:39 ` [PATCH v3 03/13] ARM: dts: rockchip: add i2c dt node for rv1108 Andy Yan
[not found] ` <1502422790-30776-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-12 14:40 ` Wolfram Sang
2017-08-13 12:07 ` Heiko Stuebner
2017-08-11 3:48 ` [PATCH v3 12/13] ARM: dts: rockchip: add pmic rk805 dt node for rv1108 evb Andy Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2309743.33rDFhBfGp@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).