[PATCH 0/2] Add HDMI support

[PATCH 0/2] Add HDMI support

[Biju Das]

Hello,

This series aims to add HDMI support for iWave RZ/G1M (R8A7743) board.
This series has been tested against renesas-dev tag 20171018-v4.14-rc5.

This patch dependency on below patches

[1] dt-bindings: display: rcar-du: Document R8A774[35]DU
    https://patchwork.kernel.org/patch/10005091/
[2] drm: rcar-du: Add R8A7743 support
    https://patchwork.kernel.org/patch/10005093/

Fabrizio Castro (2):
  ARM: dts: r8a7743: Add DU support
  ARM: dts: iwg20d-q7-dbcm-ca: Add HDMI video output

 arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi | 75 ++++++++++++++++++++++++++++++++
 arch/arm/boot/dts/r8a7743.dtsi           | 30 +++++++++++++
 2 files changed, 105 insertions(+)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] ARM: dts: r8a7743: Add DU support

[Biju Das]

From: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>

Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
---
 arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
index 7bbba4a..fafb10e 100644
--- a/arch/arm/boot/dts/r8a7743.dtsi
+++ b/arch/arm/boot/dts/r8a7743.dtsi
@@ -1033,6 +1033,36 @@
 			};
 		};
 
+		du: display@feb00000 {
+			compatible = "renesas,du-r8a7743";
+			reg = <0 0xfeb00000 0 0x40000>,
+			      <0 0xfeb90000 0 0x1c>;
+			reg-names = "du", "lvds.0";
+			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 724>,
+				 <&cpg CPG_MOD 723>,
+				 <&cpg CPG_MOD 726>;
+			clock-names = "du.0", "du.1", "lvds.0";
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					du_out_rgb: endpoint {
+					};
+				};
+				port@1 {
+					reg = <1>;
+					du_out_lvds0: endpoint {
+					};
+				};
+			};
+		};
+
 		pci0: pci@ee090000 {
 			compatible = "renesas,pci-r8a7743",
 				     "renesas,pci-rcar-gen2";
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: r8a7743: Add DU support

[Laurent Pinchart]

Hi Biju,

Thank you for the patch.

On Wednesday, 18 October 2017 12:33:46 EEST Biju Das wrote:
> From: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>

> ---
>  arch/arm/boot/dts/r8a7743.dtsi | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7743.dtsi b/arch/arm/boot/dts/r8a7743.dtsi
> index 7bbba4a..fafb10e 100644
> --- a/arch/arm/boot/dts/r8a7743.dtsi
> +++ b/arch/arm/boot/dts/r8a7743.dtsi
> @@ -1033,6 +1033,36 @@
>  			};
>  		};
> 
> +		du: display@feb00000 {
> +			compatible = "renesas,du-r8a7743";
> +			reg = <0 0xfeb00000 0 0x40000>,
> +			      <0 0xfeb90000 0 0x1c>;
> +			reg-names = "du", "lvds.0";
> +			interrupts = <GIC_SPI 256 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 724>,
> +				 <&cpg CPG_MOD 723>,
> +				 <&cpg CPG_MOD 726>;
> +			clock-names = "du.0", "du.1", "lvds.0";
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				port@0 {
> +					reg = <0>;
> +					du_out_rgb: endpoint {
> +					};
> +				};
> +				port@1 {
> +					reg = <1>;
> +					du_out_lvds0: endpoint {
> +					};
> +				};
> +			};
> +		};
> +
>  		pci0: pci@ee090000 {
>  			compatible = "renesas,pci-r8a7743",
>  				     "renesas,pci-rcar-gen2";

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] ARM: dts: r8a7743: Add DU support

[Simon Horman]

On Wed, Oct 18, 2017 at 10:33:46AM +0100, Biju Das wrote:
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Please include some text, preferably motivating this change,
here.

> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

RE: [PATCH 1/2] ARM: dts: r8a7743: Add DU support

[Fabrizio Castro]

Hello Simon,

>
> Please include some text, preferably motivating this change,
> here.

 Will do.

>
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>

Thanks,
Fab



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: dts: iwg20d-q7-dbcm-ca: Add HDMI video output

[Biju Das]

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Although there is a HDMI connector on the q7 carrier board it is not
connected to the RZ/G1M SoC. One must use the HDMI connector on the
camera daughter board.

This patch adds support for this connector.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi | 75 ++++++++++++++++++++++++++++++++
 1 file changed, 75 insertions(+)

diff --git a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
index 31fab5f..45b8167 100644
--- a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
+++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
@@ -13,6 +13,31 @@
 		serial1 = &scif1;
 		serial4 = &hscif1;
 	};
+
+	hdmi-out {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi_con_out: endpoint {
+				remote-endpoint = <&adv7511_out>;
+			};
+		};
+	};
+};
+
+&du {
+	pinctrl-0 = <&du_pins>;
+	pinctrl-names = "default";
+	status = "okay";
+
+	ports {
+		port@0 {
+			endpoint {
+				remote-endpoint = <&adv7511_in>;
+			};
+		};
+	};
 };
 
 &hscif1 {
@@ -23,7 +48,57 @@
 	status = "okay";
 };
 
+&i2c5 {
+	status = "okay";
+	clock-frequency = <400000>;
+
+	cec_clock: cec-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <12000000>;
+	};
+
+	hdmi@39 {
+		compatible = "adi,adv7511w";
+		reg = <0x39>;
+		interrupt-parent = <&gpio0>;
+		interrupts = <13 IRQ_TYPE_LEVEL_LOW>;
+		clocks = <&cec_clock>;
+		clock-names = "cec";
+
+		adi,input-depth = <8>;
+		adi,input-colorspace = "rgb";
+		adi,input-clock = "1x";
+		adi,input-style = <1>;
+		adi,input-justification = "evenly";
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				adv7511_in: endpoint {
+					remote-endpoint = <&du_out_rgb>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				adv7511_out: endpoint {
+					remote-endpoint = <&hdmi_con_out>;
+				};
+			};
+		};
+	};
+};
+
 &pfc {
+	du_pins: du {
+		groups = "du_rgb888", "du_sync", "du_oddf", "du_clk_out_0";
+		function = "du";
+	};
+
 	hscif1_pins: hscif1 {
 		groups = "hscif1_data_c", "hscif1_ctrl_c";
 		function = "hscif1";
-- 
1.9.1

Re: [PATCH 2/2] ARM: dts: iwg20d-q7-dbcm-ca: Add HDMI video output

[Laurent Pinchart]

Hi Biju,

Thank you for the patch.

On Wednesday, 18 October 2017 12:33:47 EEST Biju Das wrote:
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Although there is a HDMI connector on the q7 carrier board it is not
> connected to the RZ/G1M SoC. One must use the HDMI connector on the
> camera daughter board.
> 
> This patch adds support for this connector.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> ---
>  arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi | 75 +++++++++++++++++++++++++++++
>  1 file changed, 75 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi index 31fab5f..45b8167 100644
> --- a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> @@ -13,6 +13,31 @@
>  		serial1 = &scif1;
>  		serial4 = &hscif1;
>  	};
> +
> +	hdmi-out {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi_con_out: endpoint {
> +				remote-endpoint = <&adv7511_out>;
> +			};
> +		};
> +	};
> +};
> +
> +&du {
> +	pinctrl-0 = <&du_pins>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +
> +	ports {
> +		port@0 {
> +			endpoint {
> +				remote-endpoint = <&adv7511_in>;
> +			};
> +		};
> +	};
>  };
> 
>  &hscif1 {
> @@ -23,7 +48,57 @@
>  	status = "okay";
>  };
> 
> +&i2c5 {
> +	status = "okay";
> +	clock-frequency = <400000>;
> +
> +	cec_clock: cec-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <12000000>;
> +	};

I assume this describes a fixed clock generator that is not I2C-controlled. 
The node should thus not be a child of the i2c5 bus node, but should be moved 
to the root node of the DT.

The rest looks good to me. With this fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

However I can't find arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi in linux-next. 
Which tree would you like to get this series merged through ?

> +	hdmi@39 {
> +		compatible = "adi,adv7511w";
> +		reg = <0x39>;
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <13 IRQ_TYPE_LEVEL_LOW>;
> +		clocks = <&cec_clock>;
> +		clock-names = "cec";
> +
> +		adi,input-depth = <8>;
> +		adi,input-colorspace = "rgb";
> +		adi,input-clock = "1x";
> +		adi,input-style = <1>;
> +		adi,input-justification = "evenly";
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				adv7511_in: endpoint {
> +					remote-endpoint = <&du_out_rgb>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +				adv7511_out: endpoint {
> +					remote-endpoint = <&hdmi_con_out>;
> +				};
> +			};
> +		};
> +	};
> +};
> +
>  &pfc {
> +	du_pins: du {
> +		groups = "du_rgb888", "du_sync", "du_oddf", "du_clk_out_0";
> +		function = "du";
> +	};
> +
>  	hscif1_pins: hscif1 {
>  		groups = "hscif1_data_c", "hscif1_ctrl_c";
>  		function = "hscif1";


-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/2] ARM: dts: iwg20d-q7-dbcm-ca: Add HDMI video output

[Geert Uytterhoeven]

Hi Laurent,

On Wed, Oct 18, 2017 at 2:16 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Wednesday, 18 October 2017 12:33:47 EEST Biju Das wrote:
>> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>>
>> Although there is a HDMI connector on the q7 carrier board it is not
>> connected to the RZ/G1M SoC. One must use the HDMI connector on the
>> camera daughter board.
>>
>> This patch adds support for this connector.
>>
>> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

>> --- a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
>> +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi

>> @@ -23,7 +48,57 @@
>>       status = "okay";
>>  };
>>
>> +&i2c5 {
>> +     status = "okay";
>> +     clock-frequency = <400000>;
>> +
>> +     cec_clock: cec-clock {
>> +             compatible = "fixed-clock";
>> +             #clock-cells = <0>;
>> +             clock-frequency = <12000000>;
>> +     };
>
> I assume this describes a fixed clock generator that is not I2C-controlled.
> The node should thus not be a child of the i2c5 bus node, but should be moved
> to the root node of the DT.

Oops, that's something we should fix in r8a7791-koelsch.dts, too
(CC Hans)

> The rest looks good to me. With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> However I can't find arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi in linux-next.
> Which tree would you like to get this series merged through ?

It's been in next as of next-20171012.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 2/2] ARM: dts: iwg20d-q7-dbcm-ca: Add HDMI video output

[Fabrizio Castro]

Hello Geert,

> >
> > I assume this describes a fixed clock generator that is not I2C-controlled.
> > The node should thus not be a child of the i2c5 bus node, but should be moved
> > to the root node of the DT.
>
> Oops, that's something we should fix in r8a7791-koelsch.dts, too
> (CC Hans)

yeah, that's precisely where we copied the layout from :)

Thanks,
Fab

>
> > The rest looks good to me. With this fixed,
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > However I can't find arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi in linux-next.
> > Which tree would you like to get this series merged through ?
>
> It's been in next as of next-20171012.
>
> Gr{oetje,eeting}s,
>
>                         Geert



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/2] ARM: dts: iwg20d-q7-dbcm-ca: Add HDMI video output

[Biju Das]

Hi Laurent,

> On Wednesday, 18 October 2017 12:33:47 EEST Biju Das wrote:
> > From: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> >
> > Although there is a HDMI connector on the q7 carrier board it is not
> > connected to the RZ/G1M SoC. One must use the HDMI connector on the
> > camera daughter board.
> >
> > This patch adds support for this connector.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > Reviewed-by: Biju Das <biju.das-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi | 75
> > +++++++++++++++++++++++++++++
> >  1 file changed, 75 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> > b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi index 31fab5f..45b8167
> > 100644
> > --- a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> > +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi
> > +&i2c5 {
> > +status = "okay";
> > +clock-frequency = <400000>;
> > +
> > +cec_clock: cec-clock {
> > +compatible = "fixed-clock";
> > +#clock-cells = <0>;
> > +clock-frequency = <12000000>;
> > +};
>
> I assume this describes a fixed clock generator that is not I2C-controlled.
> The node should thus not be a child of the i2c5 bus node, but should be moved
> to the root node of the DT.

Thanks, We will send a v2 with above changes.

> The rest looks good to me. With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
>
> However I can't find arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi in linux-next.
> Which tree would you like to get this series merged through ?

Currently it is in renesas devel branch (https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git).
It will be merged with linux-next in coming weeks.

Regards,
Biju





Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 2/2] ARM: dts: iwg20d-q7-dbcm-ca: Add HDMI video output

[Fabrizio Castro]

Hello Laurent,

> >
> > +&i2c5 {
> > +status = "okay";
> > +clock-frequency = <400000>;
> > +
> > +cec_clock: cec-clock {
> > +compatible = "fixed-clock";
> > +#clock-cells = <0>;
> > +clock-frequency = <12000000>;
> > +};
>
> I assume this describes a fixed clock generator that is not I2C-controlled.
> The node should thus not be a child of the i2c5 bus node, but should be moved
> to the root node of the DT.

Will send a v2 to fix this.

Thanks,
Fab

>
> The rest looks good to me. With this fixed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.