Re: [PATCH] arm64: dts: Introduce more nodes to EN7581 SoC evaluation board

[Krzysztof Kozlowski <krzk@kernel.org>]

On 03/02/2025 17:04, Krzysztof Kozlowski wrote:
>> +
>> +		rng@1faa1000 {
>> +			compatible = "airoha,en7581-trng";
>> +			reg = <0x0 0x1faa1000 0x0 0xc04>;
>> +			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
>> +		};
>> +
>> +		system-controller@1fbf0200 {
>> +			compatible = "syscon", "simple-mfd";
> 
> These are never allowed alone. I am pretty sure I added proper checks
> which should point it out, so I think you did not really test your DTS.
> 
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
> Maybe you need to update your dtschema and yamllint. Don't rely on
> distro packages for dtschema and be sure you are using the latest
> released dtschema.
> 

Now I see Rob's report:
arch/arm64/boot/dts/airoha/en7581-evb.dtb: system-controller@1fbf0200:
compatible: ['syscon', 'simple-mfd'] is too short
which confirms untested code. Schema is there for a reason. :(

Best regards,
Krzysztof