From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Javier Carrasco <javier.carrasco@wolfvision.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: usb: tps6598x: add reset-gpios property
Date: Fri, 15 Sep 2023 08:56:04 +0200 [thread overview]
Message-ID: <232585f0-772d-36a4-02de-f2698ec7bb5e@linaro.org> (raw)
In-Reply-To: <20230912-topic-tps6598x_reset-v1-2-78dc0bf61790@wolfvision.net>
On 15/09/2023 08:50, Javier Carrasco wrote:
> The TPS6598x driver supports an optional high-level reset GPIO.
What driver supports or not, it does not matter. The question is (and
commit msg should say) whether hardware has such reset pin or not.
> Document the new property and add it to the example.
>
> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
> ---
> Documentation/devicetree/bindings/usb/ti,tps6598x.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> index 5497a60cddbc..b1a621e06127 100644
> --- a/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> +++ b/Documentation/devicetree/bindings/usb/ti,tps6598x.yaml
> @@ -23,6 +23,10 @@ properties:
> reg:
> maxItems: 1
>
> + reset-gpios:
> + description: GPIO used for the HRESET pin.
This probably answers that yes - it is a pin in hardware...
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2023-09-15 6:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 6:50 [PATCH 0/2] usb: typec: tps6598x: add reset gpio support Javier Carrasco
2023-09-15 6:50 ` [PATCH 1/2] " Javier Carrasco
2023-09-15 6:57 ` Krzysztof Kozlowski
2023-09-15 7:09 ` Javier Carrasco
2023-09-15 9:52 ` Bryan O'Donoghue
2023-09-15 10:03 ` Krzysztof Kozlowski
2023-09-15 10:07 ` Javier Carrasco
2023-09-15 10:23 ` Bryan O'Donoghue
2023-09-15 6:50 ` [PATCH 2/2] dt-bindings: usb: tps6598x: add reset-gpios property Javier Carrasco
2023-09-15 6:56 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=232585f0-772d-36a4-02de-f2698ec7bb5e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=javier.carrasco@wolfvision.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).