From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECE033148B7 for ; Fri, 14 Nov 2025 13:22:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763126525; cv=none; b=GXK+DuJFx/ADYJKUdTI56US3tDn1CvwZhqFG8nwOlxq0y6kR5QossushxX24nPh3fMIcBjBdHfbXk6Gsi2V/tUXW1pv/xGaj2sZBheNSmw1thOhauDym79SbpeVfbmVQsmWuxSjBeJACVGuZOlEi3ZHeYp2eRwQO/Zdi2c+zKaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763126525; c=relaxed/simple; bh=PIhVxornY+xeHydrfUvm8sKztzt4GgYtkzvZxgJ8W40=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mwW+FBZb0F5iEJOfq+uMlmS3+8gTaxylt3c+k3KI4t9Qux+q1vf+UbEDLWvMD7ESVc3n7ed+asp36yEz1K1xRoaBvbcehAWX0Bd4wtIkrk28Id0n42gjR0O72Izs/5coyijfD/7wG+YabLOqf4qPiGdwuxRzaGd8v8JPYjo1Tqg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JLxJBecV; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JLxJBecV" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-37b95f87d4eso17035101fa.1 for ; Fri, 14 Nov 2025 05:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763126522; x=1763731322; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TrtX8x6xiGPlcF3REo6XTaulSDVNKE90sjqlhnGudPU=; b=JLxJBecVTt7ci4MySHtaJCX2RuSWm+47+kgQXd3+q5iCTC6xRsKVeS4VMO2C6iKoUi 7wC7myl8516ZyD8NfP4qhC6InalfcMWDXVAnbtLDFNwJ6ARwpQfEZIrsLX12cgIT1uql lrk6TGIK/1QEbP5uaOpQ8lOu/DJZfSzIb3aiGlYvsoBl6Z+b0tkjB3xpz6kbj1SreGpl da9piGtvNIXkCcYmoDu2sNWR9609OQO1ta0KvjdQNYb4U1AiIS2D9tvNsn+Wv5udjE9n tKW1+Vcx+V8JDmWgyb2Y2iuVQPq4hnOZ7a48Uw3v7Cx5fOHYIAEu4dBdezJxsOSPM0Es tZGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763126522; x=1763731322; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TrtX8x6xiGPlcF3REo6XTaulSDVNKE90sjqlhnGudPU=; b=h6pjwPoxJZ42M8Xop4xmgv3wrw0K2qHDYytrSwwvMH0CAyDLsUYhoxnTJxwoY8lTKL jRbN7gInMILNK91CU5G8/Iu1wiZ3p9i8SGpIEFD4uqLRw1KnPsXlAaHeJT7LE6HzZVO8 u/H7rWBPSmoQqamjWpIvizBIfY07uwCWpiglkipCx+75jI0rMGjVeQg2+ob5gpjlKHzl G0To2W7ZKfFIwv6q6pOSQWRqm2mT+2+D2yz42W6zDdxb2aoMV03LgSo1hyvXwawMavwH aj0P/KeBY2qwcN06iQ3GAzkx4Y2BUfaK62LWKFK9QITYDgRChA43u4YnRPtg8KdOyxa+ J3lQ== X-Forwarded-Encrypted: i=1; AJvYcCU5ntBP32zaKY+xkAj/1zeWA58yCUUEPBNT7CHvrpAbOxhkFRUVyKVAmCuQg81tnmwxxCcZ4SE0gScP@vger.kernel.org X-Gm-Message-State: AOJu0Yy/tGsLiNWScluySI5CGhASZ/MK1tNlwSCz8sWRwp5Y923yRuL0 K+Qw014DDYya4Q3gKZtAc1q2FhKFkM8J8rdpY9umyJs/8Dnzly6xVZ0i X-Gm-Gg: ASbGncv6cbwm2QchK9JYHlgn95DEaGcFVrYgZ/D6/XrHDopt8vvmypjOQQpJqes9zaQ Ji64HtrNFl+TxiAqMOO/WmMt6phhIKng2c7A/Qb1uoZ/O3K8oU4PyJuWRlUlnyDMK3FcWsATy/b PQatAoB9As4m99qJqjTcFH53ysQtRXTHz3M7pIvVhR89pgDhWvC8zyVPEB/uF1dQs1ZFYxA8b/Y 4wo4zwDPKSQrsGOgApOk+f2j5xpLpXxYpqJtHgeChvmmD7/FDhYn+hs0iZ/JEgusw3Uk05eeilr dVAEb8ZiPxcaDhu/pO/wE2ib50uNa75CD45EmxUU76T46mZ04geJH+2vLlIfABvxduLu+2i5ErY Qo59XnwOdZTULuok+d8/PJDfuBB+aFEqbg8ydOcXHVcXKa2FchQAXhGvpjmCNggcW755fn0eq/n HouUH94TuCUhgoZAfGUcsYRdNigi8hnhFuH0h5Scu1gmg9nxFRyNhH4FT5PA== X-Google-Smtp-Source: AGHT+IFJvPwRc3iSb2WexT7/Nxb76MqMei5zXQUBPxVbaOVwZ0mTUJAzGoCKPRFSwFTVf5iDU0WZyw== X-Received: by 2002:a05:651c:418f:b0:378:e3f9:2d26 with SMTP id 38308e7fff4ca-37babd80ac1mr5793261fa.39.1763126521767; Fri, 14 Nov 2025 05:22:01 -0800 (PST) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-37b9ce080a6sm10220141fa.4.2025.11.14.05.22.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 05:22:01 -0800 (PST) Message-ID: <2334e57c-a384-4a1e-9708-19d14b8f082c@gmail.com> Date: Fri, 14 Nov 2025 15:22:00 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 14/16] power: supply: bd71828: Support wider register addresses To: Andreas Kemnade , Matti Vaittinen Cc: Matti Vaittinen , Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sebastian Reichel , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org References: <6248200397d3582fe926938736da66d6bbf9535d.1763022807.git.mazziesaccount@gmail.com> <20251114121509.629d171b@kemnade.info> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20251114121509.629d171b@kemnade.info> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks Andreas, On 14/11/2025 13:15, Andreas Kemnade wrote: > On Thu, 13 Nov 2025 10:55:39 +0200 > Matti Vaittinen wrote: > >> As a side note, we can reduce the "wasted space / member / instance" from >> 3 bytes to 1 byte, by using u16 instead of the unsigned int if needed. I >> rather use unsigned int to be initially prepared for devices with 32 bit >> registers if there is no need to count bytes. > > Well, this is totally internal to the module, so no ABI/API changes, so > there is no advantage of using 32bit now I think. We can switch any time. The only advantage is to avoid the churn if 32bit ICs are to be added. > But we have 32bit stuff in the regmap cache anyways, so that is not above > the general level of wasting space. Exactly. And, I am not sure if sparing ~hundred bytes is worth the hassle - even if it is hassle internal to the driver. But yeah, we can squeeze a few bytes if it is seen beneficial. That's why I mentioned it here :) Yours, -- Matti --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~