From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Chris Ruehl <chris.ruehl@gtsys.com.hk>,
Jensen Huang <jensenhuang@friendlyarm.com>,
Brian Norris <briannorris@chromium.org>,
Doug Anderson <dianders@chromium.org>
Cc: Jensen Huang <jensenhuang@friendlyarm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on rk3399
Date: Tue, 23 Aug 2022 13:53:49 +0200 [thread overview]
Message-ID: <23552842.6Emhk5qWAg@diego> (raw)
In-Reply-To: <20220822074139.3810-1-jensenhuang@friendlyarm.com>
Am Montag, 22. August 2022, 09:41:39 CEST schrieb Jensen Huang:
> Internal pull-down for strobe line (GRF_EMMCPHY_CON2[9]) was disabled
> by commit 8b5c2b45b8f0, which causes I/O error in HS400 mode.
>
> Tested on NanoPC-T4.
>
> Fixes: 8b5c2b45b8f0 ("phy: rockchip: set pulldown for strobe line in dts")
> Signed-off-by: Jensen Huang <jensenhuang@friendlyarm.com>
ok, so this looks like it restores previous functionality.
I'm just wondering as the "offending" patch is from 2020, why this
only turns up now. Any ideas?
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 9d5b0e8c9cca..9491cafbbaa3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1561,6 +1561,7 @@ emmc_phy: phy@f780 {
> clock-names = "emmcclk";
> drive-impedance-ohm = <50>;
> #phy-cells = <0>;
> + rockchip,enable-strobe-pulldown;
> status = "disabled";
> };
>
>
next prev parent reply other threads:[~2022-08-23 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 7:41 [PATCH] arm64: dts: rockchip: add enable-strobe-pulldown to emmc phy on rk3399 Jensen Huang
2022-08-23 11:53 ` Heiko Stübner [this message]
2022-08-23 14:13 ` Doug Anderson
2022-08-24 3:11 ` Jensen Huang
2022-08-24 14:57 ` Doug Anderson
2022-08-26 12:03 ` Jensen Huang
2024-02-27 2:05 ` Alban Browaeys
2024-02-27 10:11 ` Folker Schwesinger
2024-02-27 10:38 ` Christopher Obbard
2024-02-27 13:49 ` Folker Schwesinger
2024-02-27 16:00 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23552842.6Emhk5qWAg@diego \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=chris.ruehl@gtsys.com.hk \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jensenhuang@friendlyarm.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).