From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver Date: Wed, 14 Jan 2015 12:54:25 +0100 Message-ID: <2355599.PaLfD1Yyf4@wuerfel> References: <1420628981-22774-1-git-send-email-rsahu@apm.com> <1701652.4qUlzcU1j2@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rameshwar Sahu Cc: vinod.koul@intel.com, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ddutile@redhat.com, jcm@redhat.com, patches@apm.com, Loc Ho List-Id: devicetree@vger.kernel.org On Wednesday 14 January 2015 14:56:33 Rameshwar Sahu wrote: > > > Also add the correct dma-ranges property in the parent, or else this will > > fail in the future once we add proper checks to dma_set_mask. > > I see arch/arm64 kernel doesn't use dma range value parsed from > dma-range property currently, I will check it more. > It doesn't use dma_pfn_offset value calculated by the dma-ranges in > dma mapping API. > dma-ranges value should test properly before adding. > Is there any use to add this dma-ranges properly if arch code doesn't support ?? Of course: the dt needs to describe the hardware correctly. This is just a bug in the current arm64 code and it will soon be fixed. Arnd