From: yanhong wang <yanhong.wang@starfivetech.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: <linux-riscv@lists.infradead.org>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v1 2/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string
Date: Fri, 9 Dec 2022 10:26:55 +0800 [thread overview]
Message-ID: <236b1b83-9bda-ac09-ea09-9701dccb4ac6@starfivetech.com> (raw)
In-Reply-To: <f6fd99d22a025377e176890cc7641ab9@codethink.co.uk>
On 2022/12/9 9:59, Ben Dooks wrote:
>
>
> On 2022-12-01 09:02, Yanhong Wang wrote:
>> Add "snps,dwmac-5.20" compatible string for 5.20 version that can avoid
>> to define some platform data in the glue layer.
>>
>> Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
>> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> index 50f6b4a14be4..cc3b701af802 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>> @@ -519,7 +519,8 @@ stmmac_probe_config_dt(struct platform_device
>> *pdev, u8 *mac)
>> if (of_device_is_compatible(np, "snps,dwmac-4.00") ||
>> of_device_is_compatible(np, "snps,dwmac-4.10a") ||
>> of_device_is_compatible(np, "snps,dwmac-4.20a") ||
>> - of_device_is_compatible(np, "snps,dwmac-5.10a")) {
>> + of_device_is_compatible(np, "snps,dwmac-5.10a") ||
>> + of_device_is_compatible(np, "snps,dwmac-5.20")) {
>> plat->has_gmac4 = 1;
>> plat->has_gmac = 0;
>> plat->pmt = 1;
>
> out of interest, is the version of the ip autodetectable yet?
> also, we would be better off if having an if (version > 4) check if we use the standard snps ip block code headers
>
Yes, the version of the ip is autodetectable. It is also possible to use the standard "snps, dwmac-5.10a" definition on JH7110（has been tested on the VisionFive v2 boards and works normally）, do you have any better suggestions?
next prev parent reply other threads:[~2022-12-09 2:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 9:02 [PATCH v1 0/7] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2022-12-01 9:02 ` [PATCH v1 1/7] dt-bindings: net: snps,dwmac: Add compatible string for dwmac-5.20 version Yanhong Wang
2022-12-01 16:18 ` Krzysztof Kozlowski
2022-12-02 2:53 ` yanhong wang
2022-12-02 8:01 ` Krzysztof Kozlowski
2022-12-07 13:56 ` Emil Renner Berthing
2022-12-08 1:34 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 2/7] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2022-12-07 13:58 ` Emil Renner Berthing
2022-12-08 1:42 ` yanhong wang
2022-12-09 1:59 ` Ben Dooks
2022-12-09 2:26 ` yanhong wang [this message]
2022-12-01 9:02 ` [PATCH v1 3/7] dt-bindings: net: Add bindings for StarFive dwmac Yanhong Wang
2022-12-01 13:36 ` Rob Herring
2022-12-01 16:45 ` Conor Dooley
2022-12-02 10:52 ` Krzysztof Kozlowski
2022-12-01 16:21 ` Krzysztof Kozlowski
2022-12-01 17:35 ` Conor Dooley
2022-12-01 19:32 ` Rob Herring
2022-12-02 7:16 ` yanhong wang
2022-12-02 8:02 ` Krzysztof Kozlowski
2022-12-02 7:07 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 4/7] net: phy: motorcomm: Add YT8531 phy support Yanhong Wang
2022-12-01 15:40 ` Andrew Lunn
2022-12-06 7:39 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 5/7] net: stmmac: Add StarFive dwmac supoort Yanhong Wang
2022-12-07 14:16 ` Emil Renner Berthing
2022-12-08 2:22 ` yanhong wang
2022-12-09 2:03 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 6/7] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2022-12-01 17:45 ` Conor Dooley
2022-12-02 5:53 ` yanhong wang
2022-12-01 9:02 ` [PATCH v1 7/7] riscv: dts: starfive: visionfive-v2: Add phy delay_chain configuration Yanhong Wang
2022-12-01 17:49 ` Conor Dooley
2022-12-01 19:30 ` Conor Dooley
2022-12-01 19:42 ` Andrew Lunn
2022-12-09 1:28 ` yanhong wang
2022-12-09 1:19 ` yanhong wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=236b1b83-9bda-ac09-ea09-9701dccb4ac6@starfivetech.com \
--to=yanhong.wang@starfivetech.com \
--cc=andrew@lunn.ch \
--cc=ben.dooks@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).