From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23B9F6FC3 for ; Sat, 22 Feb 2025 09:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740217584; cv=none; b=Mbb4VnumvjOgIda4KF+WUy7N8DUwryhhI2pV7dcCSooCn0qrYCJqzCF7kvKrneoGGaJwgUGvHvNDkIBNopbT96bmQM6OncG2h0LKZ5J42jRXhf/ebG3aH6SQlp+LrJgwy/8+o79ft4q4plKOwCz8yOS8JYW7fL4veEGRp4yVbjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740217584; c=relaxed/simple; bh=f3l/C08zZjB4lqhJuTu7gJoa99yZ3UX081PIPlxuiSs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q0J40h3rHE8yQ1XLdMZwU05f1RwYdVzo0PnA+Y5pX+A//HB+nsqYt3lYBE7NZm/zUv6vIXabjdpe1n+sstzQYGDcQ94blOw4u4rjl/Hv0dOMucbnTzJcNVwXYD07XKr7YoRNaNjjcrWPY8e4C42kkOUB/ALz8/2dwAsd04sEznA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JIrX+Nre; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JIrX+Nre" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-38f2b7ce2f3so2126904f8f.0 for ; Sat, 22 Feb 2025 01:46:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740217581; x=1740822381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=41DdFtdJ+j4aD8vxL14dVna+R0FXEc06U5Wqw9eVGxY=; b=JIrX+NreaEoq9yV50mCyUg4ZwQXcgw8XfKH+AwVKoPHr+h6P+D+AQMWGMOeDiRbeuc ecIOAsWEQ1tMpBppZMEQLY7jY0CbPWGFaEBpWIDEbwTcQJ06fagyt/hjdeKEaiEHXFyd DPWBJiyNkU/lFfvrf9GNSBhyywLsevlCtTI49HqFWj/l4m6JYFpzH1FteglTp3tuJDdh u4JH09DB8hrlXwx25nbkDWxEax4ODKxSzRwkYkHMgZChtFUI1MzK3yKEqkcrkaHO6lgA Pw5CE/SUdzTQ3NSaPNYH7JE4n1AhmHlbicpxEIK5L6s6qCZcLK4vmCkwePuQZLFyraTw WL/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740217581; x=1740822381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=41DdFtdJ+j4aD8vxL14dVna+R0FXEc06U5Wqw9eVGxY=; b=q/l9wUKspXmNMdh3hPG018PQgREy7ymYTngR/82iDrFxRLvjdcC0rLUJPDB24PkCx1 dX4EBYeNrNpUP6/NDQ+BbpUYJs69iyG3gGbKCninZfM0IS5N8KHC0ZuQNdemYrmBRm3x Kce+qKqQbJzHaPD2LvCScqPYoTrRxIGRGo7pCt9f3HtbW3cuP3SqUmyjmW/HHLaLNZ/7 smBu8DsRcPCC6Pj0k/+PsgvGpclJrPyTKDYlbDaiFB9ceFdxQqT7Q2LMb0ViU44Yrnyg p9pWdpUoRz3U1TxR9awnem6e29/ijAL/9PSilQRH109/ec+tDppx/Z2IxJ47A1V8DzcP 3rHw== X-Forwarded-Encrypted: i=1; AJvYcCWV3yEVxs26A+QFAzctojXhVk85AkVNuH4z8mTzrOBZls963fHscZ6oP6uXQ9yturoMbCshoWNujLZJ@vger.kernel.org X-Gm-Message-State: AOJu0YxZ5N8a7HssHKHrkFkBr6ZbTifBk8eC5wtzVVG/5RL+4fSTuJE+ iJI7vQppfK0cldPHPUPEpb2/oE1aIx5qlGxsT6XwH6rMqeulc2/a7ejWJjyj X-Gm-Gg: ASbGnctvC8EvEak00De5peiS/RPmDzHs548KXiT+tLlyQwOzLHqYY2A8QpOzD96MGOg JNUQXLXVNBWcS9Gpzv8B6mXmlkuKEEKR2bbc6GRbayuIbxIlyRsufmIG7yNm4VDfSKWpgoH4v+O cF7shuJbA/P5kJIYQ3EC7MWCnHB6lWO7vYfv58vVCBSY253VDvH3RqUVV+a6cqfTkSLTfWCh4DK 12BeYCkCtCkLuuVisTWkSUAZ1egOKAyKUXWVguzYMddnpQgxFHSnz5Qewrzdx7Cx2DdZWuqT1nG NbQyswJi8Up9DumntUiWHU79MnIZm7hbNPjuR0Jead+QFO21QcWGmOehjOryrbvxtlTshgXGeJA VNg== X-Google-Smtp-Source: AGHT+IH9kK+RjWwIPLtZlicr8RC/6yrn6sA09olVzUzJHXrQ6iKk6NZGgzzk5oOay6MNB/ZXKzOgpA== X-Received: by 2002:a5d:64c4:0:b0:38f:6697:af91 with SMTP id ffacd0b85a97d-38f70825fe0mr5475428f8f.39.1740217581325; Sat, 22 Feb 2025 01:46:21 -0800 (PST) Received: from jernej-laptop.localnet (86-58-6-171.dynamic.telemach.net. [86.58.6.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38f258f0597sm25364929f8f.42.2025.02.22.01.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Feb 2025 01:46:21 -0800 (PST) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Samuel Holland , Ryan Walklin Cc: Andre Przywara , Chris Morgan , Hironori KIKUCHI , Philippe Simons , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ryan Walklin Subject: Re: [PATCH 7/8] arm64: dts: allwinner: rg35xx: Enable LCD output Date: Sat, 22 Feb 2025 10:46:19 +0100 Message-ID: <23840170.6Emhk5qWAg@jernej-laptop> In-Reply-To: <20250216092827.15444-8-ryan@testtoast.com> References: <20250216092827.15444-1-ryan@testtoast.com> <20250216092827.15444-8-ryan@testtoast.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dne nedelja, 16. februar 2025 ob 10:27:14 Srednjeevropski standardni =C4=8D= as je Ryan Walklin napisal(a): > The RG35XX has a 640x480 RGB/SPI LCD panel, supported by the SoC display > pipeline and an NV3052C controller. The H616 SOC's GPIO bank D contains > the muxed display pins for RGB and LVDS output support. >=20 > Enable the display engine and LCD timing controller, configure the > panel, and add a fixed 3.3v GPIO-controlled regulator for the panel, and > a VCC supply for the display pins as per the other GPIO banks. >=20 > Signed-off-by: Ryan Walklin > --- > .../sun50i-h700-anbernic-rg35xx-2024.dts | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-20= 24.dts b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts > index a231abf1684ad..388487d4720e2 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts > @@ -175,6 +175,49 @@ reg_vcc5v: regulator-vcc5v { /* USB-C power input */ > regulator-min-microvolt =3D <5000000>; > regulator-max-microvolt =3D <5000000>; > }; > + > + reg_lcd: regulator-gpio-lcd-vdd { > + compatible =3D "regulator-fixed"; > + regulator-min-microvolt =3D <3300000>; > + regulator-max-microvolt =3D <3300000>; > + regulator-name =3D "vdd-lcd"; > + gpio =3D <&pio 8 15 GPIO_ACTIVE_HIGH>; // PI15 > + enable-active-high; > + }; > + > + spi_lcd: spi { > + compatible =3D "spi-gpio"; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + sck-gpios =3D <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9 > + mosi-gpios =3D <&pio 8 10 GPIO_ACTIVE_HIGH>; // PI10 > + cs-gpios =3D <&pio 8 8 GPIO_ACTIVE_HIGH>; // PI8 > + num-chipselects =3D <1>; > + > + panel: panel@0 { > + compatible =3D "anbernic,rg35xx-plus-panel"; > + > + reg =3D <0>; > + > + spi-max-frequency =3D <3125000>; > + spi-3wire; > + > + reset-gpios =3D <&pio 8 14 GPIO_ACTIVE_LOW>; // PI14 > + > + backlight =3D <&backlight>; There is no backlight node at this point. Reverse patches 7 and 8 or better= yet, merge them and put patch 8 message into comment to backlight node. Best regards, Jernej > + power-supply =3D <®_lcd>; > + > + pinctrl-0 =3D <&lcd0_rgb888_pins>; > + pinctrl-names =3D "default"; > + > + port { > + panel_in_rgb: endpoint { > + remote-endpoint =3D <&tcon_lcd0_out_lcd>; > + }; > + }; > + }; > + }; > }; > =20 > &codec { > @@ -187,6 +230,10 @@ &cpu0 { > cpu-supply =3D <®_dcdc1>; > }; > =20 > +&de { > + status =3D "okay"; > +}; > + > &ehci0 { > status =3D "okay"; > }; > @@ -206,6 +253,7 @@ &ohci0 { > &pio { > vcc-pa-supply =3D <®_cldo3>; > vcc-pc-supply =3D <®_cldo3>; > + vcc-pd-supply =3D <®_cldo3>; > vcc-pe-supply =3D <®_cldo3>; > vcc-pf-supply =3D <®_cldo3>; > vcc-pg-supply =3D <®_aldo4>; > @@ -355,3 +403,13 @@ &usbotg { > &usbphy { > status =3D "okay"; > }; > + > +&tcon_lcd0 { > + status =3D "okay"; > +}; > + > +&tcon_lcd0_out { > + tcon_lcd0_out_lcd: endpoint@1 { > + remote-endpoint =3D <&panel_in_rgb>; > + }; > +}; >=20