Re: [PATCH v1 1/2] dt-bindings: i2c: ls2x-i2c: Add clock- related properties

[Krzysztof Kozlowski <krzk@kernel.org>]

On 30/03/2026 09:18, Hongliang Wang wrote:
> 
> On 2026/3/27 下午2:39, Krzysztof Kozlowski wrote:
>> On 27/03/2026 04:09, Hongliang Wang wrote:
>>> The initial idea was that this patch could be used for both ACPI and DTS.
>>>>>> The i2c-ls2x driver is compatible with both Loongson 2K and 3A+7A
>>>>>> platform, parse
>>>>>> the same parameters regardless of dts or acpi parameter passing, So
>>>>>> clock-input
>>>>>> and clock-div attributes are defined to describe input clock of i2c
>>>>>> controller and
>>>>>> divisor of input clock. It can be used on both 2K and 3A+7A platform.
>>>>> And you cannot use them in DTS.
>>> OK
>>>> I need to keep guessing what you want to achieve, because neither your
>>>> message nor commit text was explicit
>>> What I want to achieve is to describe the input clock and divisor of I2C
>>> controller
>> Input clocks are defined as clock inputs obviously in DT, not as
>> integers. Bindings need to describe the hardware, so start with that.
> I can describe the hardware in loongson,ls2x-i2c.yaml, and I would like to
> confirm with you what final implementation plan you agree to? clock 
> framework
> or custom clock-input an clock-div attributes? if clock framework, how 
> can it
> also be used for ACPI?

And you ask DT maintainer for that? It's not relevant. You sent DT
bindings patch, so this patch must be correct and we discuss this patch
here.

Best regards,
Krzysztof