From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2328AC4332F for ; Sun, 20 Nov 2022 10:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229673AbiKTKgi (ORCPT ); Sun, 20 Nov 2022 05:36:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbiKTKgg (ORCPT ); Sun, 20 Nov 2022 05:36:36 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0A077DCA1 for ; Sun, 20 Nov 2022 02:36:34 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id s8so14897306lfc.8 for ; Sun, 20 Nov 2022 02:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bkqr5CITlf9Pw0k+sezW0jUIFDxvpCmwSMWyehFOiNM=; b=l01VxSQh8yun766SjOSDe7zfb3SL3HFlZdKdnKf6D2EiEzXVI2Av+lmCp2NZ3lVlpi Y1vEvHZJw3wFXGX8mBTgR99tBrci4iwdycuAW/irJzmXCKEaLmEYE7tla4U219jYYgbu Ak71A+oY5nA0KSe2u+ozcIWsvG4O2ZWQUiXohw9BlFJCJFvsfSfm2aLpRJ2dQORoJodZ 4qb7oYyFiJcNAQpz4ahaM//QrbawwiBwlOtchNsCfw4bxU1aDWxicQcnRxjMPb6tfVKa lilYfjjOSydFNN055+AMwVyOy7UBFRTHzCkdQlVY+9eDKHuOYZ01pXXvoMEHytic9Ecg dzwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bkqr5CITlf9Pw0k+sezW0jUIFDxvpCmwSMWyehFOiNM=; b=1mWpYOUfI9kUeka5zZvtOCQU7FNxR42nqSjsdLRvdC3P2XTAOKQf2znx1AecIchidc E5QIXSHwOiIwNJV8J+Ih3X3/VvmM5qDvgKhCgVQVl5Nf98EqyomqxnXBPMx1ZzXcVs07 iGkWngq/rZ/Py0aMkvvT+BtKcnefQP2LRAOkkwyMcdWHEEpgxYfdl0KNbkxiA7D/hQal Lae8KWjZOLD5Zd1ZaAvnUjYmZRzP681QNY2PYMA2Z5IiCRwLyd7kyUtKX9e0lhKsTDPl WXr76pHJFH6izjAR7Gfi2H9OyUu9qD3fwtP4nXqSBK3C3OzPpSKTJZ2tl4YvUnmrNt+g ZGXA== X-Gm-Message-State: ANoB5pmzqu2SikmIUVtGropZPdCWDUlcufUdk9l2wM7BEQ65QX7j9mrM xZxePZZxp8LDPoB/hr+8C2vGhg== X-Google-Smtp-Source: AA0mqf6Mn70Z7ivGYWkW2u7n1bmFEm8KUVOAgQ7UoY06kP3Jgu4IpvXfJfXjOWCewEwECTOGz+/xQQ== X-Received: by 2002:a05:6512:b8f:b0:4a2:3953:7e43 with SMTP id b15-20020a0565120b8f00b004a239537e43mr4517786lfv.229.1668940592846; Sun, 20 Nov 2022 02:36:32 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u21-20020a196a15000000b00498f871f33fsm1497394lfu.86.2022.11.20.02.36.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 02:36:32 -0800 (PST) Message-ID: <238f7bf8-578c-5bb4-9f00-50f36334c5cf@linaro.org> Date: Sun, 20 Nov 2022 11:36:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 02/14] dt-bindings: media: rkisp1: Add i.MX8MP ISP example Content-Language: en-US To: Paul Elder Cc: linux-media@vger.kernel.org, Laurent Pinchart , Dafna Hirschfeld , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Helen Koike , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221118093931.1284465-1-paul.elder@ideasonboard.com> <20221118093931.1284465-3-paul.elder@ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/11/2022 07:55, Paul Elder wrote: > On Fri, Nov 18, 2022 at 02:06:14PM +0100, Krzysztof Kozlowski wrote: >> On 18/11/2022 10:39, Paul Elder wrote: >>> From: Laurent Pinchart >>> >>> Add an example to the rockchip-isp1 DT binding that showcases usage of >>> the parallel input of the ISP, connected to the CSI-2 receiver internal >>> to the i.MX8MP. >>> >>> Signed-off-by: Laurent Pinchart >> >> Missing SoB. > > I don't quite understand. I see an SoB right there. Laurent did not sent it. Did you run checkpatch before sending? > >> >>> --- >>> .../bindings/media/rockchip-isp1.yaml | 72 +++++++++++++++++++ >>> 1 file changed, 72 insertions(+) >>> >> >> I don't know what do you demonstrate there... usage of endpoints? That's >> the only difference. Such usage is the same everywhere, nothing specific > > I guess...? Doesn't the same argument apply against the px30 example too > then? > >> to this example. You already have two examples, so I don't think this >> brings anything more. > > We do have usage of this in imx8mp.dtsi and overlays for the ISP, but > those patches haven't been sent/merged yet, so in the meantime I think > there is value in providing an example here for the imx8mp. The examples are not for demonstrating imx8mp or any other soc, but this one given binding. Changing compatibles and few properties is not a different example - from "exampleness" point of view it is very similar. Best regards, Krzysztof