From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Devi Priya <quic_devipriy@quicinc.com>,
andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
richardcochran@gmail.com, geert+renesas@glider.be,
dmitry.baryshkov@linaro.org, neil.armstrong@linaro.org,
arnd@arndb.de, m.szyprowski@samsung.com, nfraprado@collabora.com,
u-kumar1@ti.com, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH V4 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574
Date: Tue, 25 Jun 2024 19:03:27 +0200 [thread overview]
Message-ID: <2391a1a1-46d3-4ced-a31f-c80194fdaf29@linaro.org> (raw)
In-Reply-To: <20240625070536.3043630-6-quic_devipriy@quicinc.com>
On 25.06.2024 9:05 AM, Devi Priya wrote:
> Add Networking Sub System Clock Controller(NSSCC) driver for ipq9574 based
> devices.
>
> Signed-off-by: Devi Priya <quic_devipriy@quicinc.com>
> Tested-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
> ---
[...]
> + struct regmap *regmap;
> + struct qcom_cc_desc nsscc_ipq9574_desc = nss_cc_ipq9574_desc;
Why?
> + struct clk *nsscc_clk;
> + struct device_node *np = (&pdev->dev)->of_node;
> + int ret;
> +
> + nsscc_clk = of_clk_get(np, 11);
> + if (IS_ERR(nsscc_clk))
> + return PTR_ERR(nsscc_clk);
> +
> + ret = clk_prepare_enable(nsscc_clk);
pm_clk_add()? And definitely drop the 11 literal, nobody could ever guess
or maintain magic numbers
Konrad
next prev parent reply other threads:[~2024-06-25 17:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 7:05 [PATCH V4 0/7] Add NSS clock controller support for IPQ9574 Devi Priya
2024-06-25 7:05 ` [PATCH V4 1/7] clk: qcom: clk-alpha-pll: Add NSS HUAYRA ALPHA PLL support for ipq9574 Devi Priya
2024-06-25 7:05 ` [PATCH V4 2/7] dt-bindings: clock: gcc-ipq9574: Add definition for GPLL0_OUT_AUX Devi Priya
2024-06-25 7:05 ` [PATCH V4 3/7] clk: qcom: gcc-ipq9574: Add support for gpll0_out_aux clock Devi Priya
2024-06-25 7:05 ` [PATCH V4 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions Devi Priya
2024-06-25 8:29 ` Rob Herring (Arm)
2024-06-25 7:05 ` [PATCH V4 5/7] clk: qcom: Add NSS clock Controller driver for IPQ9574 Devi Priya
2024-06-25 14:39 ` Andrew Lunn
2024-06-26 14:39 ` Devi Priya
2024-10-04 7:55 ` Manikanta Mylavarapu
2024-10-04 14:02 ` Andrew Lunn
2024-10-09 7:39 ` Manikanta Mylavarapu
2024-06-25 17:03 ` Konrad Dybcio [this message]
2024-06-27 5:37 ` Devi Priya
2024-06-27 15:14 ` Dmitry Baryshkov
2024-06-25 7:05 ` [PATCH V4 6/7] arm64: dts: qcom: ipq9574: Add support for nsscc node Devi Priya
2024-06-25 7:05 ` [PATCH V4 7/7] arm64: defconfig: Build NSS Clock Controller driver for IPQ9574 Devi Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2391a1a1-46d3-4ced-a31f-c80194fdaf29@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_devipriy@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=u-kumar1@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).